Commit 9ee1edcc authored by Andy Wilkinson's avatar Andy Wilkinson

Polishing

parent 771343e3
...@@ -67,7 +67,6 @@ import org.springframework.core.io.support.SpringFactoriesLoader; ...@@ -67,7 +67,6 @@ import org.springframework.core.io.support.SpringFactoriesLoader;
* @see ConditionalOnClass * @see ConditionalOnClass
* @see AutoConfigureAfter * @see AutoConfigureAfter
*/ */
@SuppressWarnings("deprecation")
@Target(ElementType.TYPE) @Target(ElementType.TYPE)
@Retention(RetentionPolicy.RUNTIME) @Retention(RetentionPolicy.RUNTIME)
@Documented @Documented
......
...@@ -39,8 +39,7 @@ import org.springframework.util.MultiValueMap; ...@@ -39,8 +39,7 @@ import org.springframework.util.MultiValueMap;
import org.springframework.util.ObjectUtils; import org.springframework.util.ObjectUtils;
/** /**
* Variant of {@link EnableAutoConfigurationImportSelector} for * Variant of {@link AutoConfigurationImportSelector} for {@link ImportAutoConfiguration}.
* {@link ImportAutoConfiguration}.
* *
* @author Phillip Webb * @author Phillip Webb
* @author Andy Wilkinson * @author Andy Wilkinson
......
...@@ -44,11 +44,11 @@ import org.springframework.data.mapping.model.FieldNamingStrategy; ...@@ -44,11 +44,11 @@ import org.springframework.data.mapping.model.FieldNamingStrategy;
import org.springframework.data.mongodb.MongoDbFactory; import org.springframework.data.mongodb.MongoDbFactory;
import org.springframework.data.mongodb.core.MongoTemplate; import org.springframework.data.mongodb.core.MongoTemplate;
import org.springframework.data.mongodb.core.SimpleMongoDbFactory; import org.springframework.data.mongodb.core.SimpleMongoDbFactory;
import org.springframework.data.mongodb.core.convert.CustomConversions;
import org.springframework.data.mongodb.core.convert.DbRefResolver; import org.springframework.data.mongodb.core.convert.DbRefResolver;
import org.springframework.data.mongodb.core.convert.DefaultDbRefResolver; import org.springframework.data.mongodb.core.convert.DefaultDbRefResolver;
import org.springframework.data.mongodb.core.convert.MappingMongoConverter; import org.springframework.data.mongodb.core.convert.MappingMongoConverter;
import org.springframework.data.mongodb.core.convert.MongoConverter; import org.springframework.data.mongodb.core.convert.MongoConverter;
import org.springframework.data.mongodb.core.convert.MongoCustomConversions;
import org.springframework.data.mongodb.core.mapping.Document; import org.springframework.data.mongodb.core.mapping.Document;
import org.springframework.data.mongodb.core.mapping.MongoMappingContext; import org.springframework.data.mongodb.core.mapping.MongoMappingContext;
import org.springframework.data.mongodb.gridfs.GridFsTemplate; import org.springframework.data.mongodb.gridfs.GridFsTemplate;
...@@ -106,7 +106,7 @@ public class MongoDataAutoConfiguration { ...@@ -106,7 +106,7 @@ public class MongoDataAutoConfiguration {
@ConditionalOnMissingBean(MongoConverter.class) @ConditionalOnMissingBean(MongoConverter.class)
public MappingMongoConverter mappingMongoConverter(MongoDbFactory factory, public MappingMongoConverter mappingMongoConverter(MongoDbFactory factory,
MongoMappingContext context, BeanFactory beanFactory, MongoMappingContext context, BeanFactory beanFactory,
CustomConversions conversions) { MongoCustomConversions conversions) {
DbRefResolver dbRefResolver = new DefaultDbRefResolver(factory); DbRefResolver dbRefResolver = new DefaultDbRefResolver(factory);
MappingMongoConverter mappingConverter = new MappingMongoConverter(dbRefResolver, MappingMongoConverter mappingConverter = new MappingMongoConverter(dbRefResolver,
context); context);
...@@ -117,7 +117,7 @@ public class MongoDataAutoConfiguration { ...@@ -117,7 +117,7 @@ public class MongoDataAutoConfiguration {
@Bean @Bean
@ConditionalOnMissingBean @ConditionalOnMissingBean
public MongoMappingContext mongoMappingContext(BeanFactory beanFactory, public MongoMappingContext mongoMappingContext(BeanFactory beanFactory,
CustomConversions conversions) throws ClassNotFoundException { MongoCustomConversions conversions) throws ClassNotFoundException {
MongoMappingContext context = new MongoMappingContext(); MongoMappingContext context = new MongoMappingContext();
context.setInitialEntitySet(new EntityScanner(this.applicationContext) context.setInitialEntitySet(new EntityScanner(this.applicationContext)
.scan(Document.class, Persistent.class)); .scan(Document.class, Persistent.class));
...@@ -141,8 +141,8 @@ public class MongoDataAutoConfiguration { ...@@ -141,8 +141,8 @@ public class MongoDataAutoConfiguration {
@Bean @Bean
@ConditionalOnMissingBean @ConditionalOnMissingBean
public CustomConversions mongoCustomConversions() { public MongoCustomConversions mongoCustomConversions() {
return new CustomConversions(Collections.emptyList()); return new MongoCustomConversions(Collections.emptyList());
} }
/** /**
......
...@@ -39,7 +39,7 @@ import org.springframework.data.couchbase.config.AbstractCouchbaseDataConfigurat ...@@ -39,7 +39,7 @@ import org.springframework.data.couchbase.config.AbstractCouchbaseDataConfigurat
import org.springframework.data.couchbase.config.BeanNames; import org.springframework.data.couchbase.config.BeanNames;
import org.springframework.data.couchbase.config.CouchbaseConfigurer; import org.springframework.data.couchbase.config.CouchbaseConfigurer;
import org.springframework.data.couchbase.core.CouchbaseTemplate; import org.springframework.data.couchbase.core.CouchbaseTemplate;
import org.springframework.data.couchbase.core.convert.CustomConversions; import org.springframework.data.couchbase.core.convert.CouchbaseCustomConversions;
import org.springframework.data.couchbase.core.mapping.CouchbaseMappingContext; import org.springframework.data.couchbase.core.mapping.CouchbaseMappingContext;
import org.springframework.data.couchbase.core.mapping.event.ValidatingCouchbaseEventListener; import org.springframework.data.couchbase.core.mapping.event.ValidatingCouchbaseEventListener;
import org.springframework.data.couchbase.core.query.Consistency; import org.springframework.data.couchbase.core.query.Consistency;
...@@ -166,8 +166,9 @@ public class CouchbaseDataAutoConfigurationTests { ...@@ -166,8 +166,9 @@ public class CouchbaseDataAutoConfigurationTests {
static class CustomConversionsConfig { static class CustomConversionsConfig {
@Bean(BeanNames.COUCHBASE_CUSTOM_CONVERSIONS) @Bean(BeanNames.COUCHBASE_CUSTOM_CONVERSIONS)
public CustomConversions myCustomConversions() { public CouchbaseCustomConversions myCustomConversions() {
return new CustomConversions(Collections.singletonList(new MyConverter())); return new CouchbaseCustomConversions(
Collections.singletonList(new MyConverter()));
} }
} }
......
...@@ -44,7 +44,7 @@ import org.springframework.data.mapping.model.CamelCaseAbbreviatingFieldNamingSt ...@@ -44,7 +44,7 @@ import org.springframework.data.mapping.model.CamelCaseAbbreviatingFieldNamingSt
import org.springframework.data.mapping.model.FieldNamingStrategy; import org.springframework.data.mapping.model.FieldNamingStrategy;
import org.springframework.data.mapping.model.PropertyNameFieldNamingStrategy; import org.springframework.data.mapping.model.PropertyNameFieldNamingStrategy;
import org.springframework.data.mongodb.core.MongoTemplate; import org.springframework.data.mongodb.core.MongoTemplate;
import org.springframework.data.mongodb.core.convert.CustomConversions; import org.springframework.data.mongodb.core.convert.MongoCustomConversions;
import org.springframework.data.mongodb.core.mapping.BasicMongoPersistentEntity; import org.springframework.data.mongodb.core.mapping.BasicMongoPersistentEntity;
import org.springframework.data.mongodb.core.mapping.MongoMappingContext; import org.springframework.data.mongodb.core.mapping.MongoMappingContext;
import org.springframework.data.mongodb.core.mapping.MongoPersistentProperty; import org.springframework.data.mongodb.core.mapping.MongoPersistentProperty;
...@@ -205,8 +205,8 @@ public class MongoDataAutoConfigurationTests { ...@@ -205,8 +205,8 @@ public class MongoDataAutoConfigurationTests {
static class CustomConversionsConfig { static class CustomConversionsConfig {
@Bean @Bean
public CustomConversions customConversions() { public MongoCustomConversions customConversions() {
return new CustomConversions(Arrays.asList(new MyConverter())); return new MongoCustomConversions(Arrays.asList(new MyConverter()));
} }
} }
......
...@@ -162,6 +162,7 @@ public class DataSourceAutoConfigurationTests { ...@@ -162,6 +162,7 @@ public class DataSourceAutoConfigurationTests {
this.context.refresh(); this.context.refresh();
DataSource bean = this.context.getBean(DataSource.class); DataSource bean = this.context.getBean(DataSource.class);
assertThat(bean).isNotNull(); assertThat(bean).isNotNull();
@SuppressWarnings("resource")
HikariDataSource pool = (HikariDataSource) bean; HikariDataSource pool = (HikariDataSource) bean;
assertThat(pool.getDriverClassName()).isEqualTo("org.hsqldb.jdbcDriver"); assertThat(pool.getDriverClassName()).isEqualTo("org.hsqldb.jdbcDriver");
assertThat(pool.getUsername()).isEqualTo("sa"); assertThat(pool.getUsername()).isEqualTo("sa");
......
...@@ -62,10 +62,9 @@ public class EventPublishingRunListener implements SpringApplicationRunListener, ...@@ -62,10 +62,9 @@ public class EventPublishingRunListener implements SpringApplicationRunListener,
} }
@Override @Override
@SuppressWarnings("deprecation")
public void starting() { public void starting() {
this.initialMulticaster this.initialMulticaster.multicastEvent(
.multicastEvent(new ApplicationStartingEvent(this.application, this.args)); new ApplicationStartingEvent(this.application, this.args));
} }
@Override @Override
......
...@@ -359,7 +359,6 @@ public class SpringApplicationTests { ...@@ -359,7 +359,6 @@ public class SpringApplicationTests {
} }
@Test @Test
@SuppressWarnings("deprecation")
public void eventsOrder() { public void eventsOrder() {
SpringApplication application = new SpringApplication(ExampleConfig.class); SpringApplication application = new SpringApplication(ExampleConfig.class);
application.setWebApplicationType(WebApplicationType.NONE); application.setWebApplicationType(WebApplicationType.NONE);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment