Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
a51fcd07
Commit
a51fcd07
authored
Feb 13, 2018
by
Tommy Ludwig
Committed by
Andy Wilkinson
Feb 13, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Auto-configure FileDescriptorMetrics
See gh-12022
parent
149963bc
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
41 additions
and
0 deletions
+41
-0
MetricsAutoConfiguration.java
...tuate/autoconfigure/metrics/MetricsAutoConfiguration.java
+8
-0
MetricsAutoConfigurationTests.java
.../autoconfigure/metrics/MetricsAutoConfigurationTests.java
+33
-0
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsAutoConfiguration.java
View file @
a51fcd07
...
...
@@ -23,6 +23,7 @@ import io.micrometer.core.instrument.binder.jvm.JvmGcMetrics;
import
io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics
;
import
io.micrometer.core.instrument.binder.jvm.JvmThreadMetrics
;
import
io.micrometer.core.instrument.binder.logging.LogbackMetrics
;
import
io.micrometer.core.instrument.binder.system.FileDescriptorMetrics
;
import
io.micrometer.core.instrument.binder.system.ProcessorMetrics
;
import
io.micrometer.core.instrument.binder.system.UptimeMetrics
;
...
...
@@ -126,6 +127,13 @@ public class MetricsAutoConfiguration {
return
new
ProcessorMetrics
();
}
@Bean
@ConditionalOnProperty
(
name
=
"management.metrics.binders.fds.enabled"
,
matchIfMissing
=
true
)
@ConditionalOnMissingBean
public
FileDescriptorMetrics
fileDescriptorMetrics
()
{
return
new
FileDescriptorMetrics
();
}
}
}
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/MetricsAutoConfigurationTests.java
View file @
a51fcd07
...
...
@@ -26,6 +26,7 @@ import io.micrometer.core.instrument.binder.jvm.JvmGcMetrics;
import
io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics
;
import
io.micrometer.core.instrument.binder.jvm.JvmThreadMetrics
;
import
io.micrometer.core.instrument.binder.logging.LogbackMetrics
;
import
io.micrometer.core.instrument.binder.system.FileDescriptorMetrics
;
import
io.micrometer.core.instrument.binder.system.ProcessorMetrics
;
import
io.micrometer.core.instrument.binder.system.UptimeMetrics
;
import
io.micrometer.core.instrument.composite.CompositeMeterRegistry
;
...
...
@@ -210,6 +211,28 @@ public class MetricsAutoConfigurationTests {
.
hasBean
(
"customProcessorMetrics"
));
}
@Test
public
void
autoConfiguresFileDescriptorMetrics
()
{
this
.
runner
.
run
(
(
context
)
->
assertThat
(
context
)
.
hasSingleBean
(
FileDescriptorMetrics
.
class
));
}
@Test
public
void
allowsFileDescriptorMetricsToBeDisabled
()
{
this
.
runner
.
withPropertyValues
(
"management.metrics.binders.fds.enabled=false"
)
.
run
((
context
)
->
assertThat
(
context
)
.
doesNotHaveBean
(
FileDescriptorMetrics
.
class
));
}
@Test
public
void
allowsCustomFileDescriptorToBeUsed
()
{
this
.
runner
.
withUserConfiguration
(
CustomFileDescriptorMetricsConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
)
.
hasSingleBean
(
FileDescriptorMetrics
.
class
)
.
hasBean
(
"customFileDescriptorMetrics"
));
}
@Configuration
static
class
CustomClockConfiguration
{
...
...
@@ -312,4 +335,14 @@ public class MetricsAutoConfigurationTests {
}
@Configuration
static
class
CustomFileDescriptorMetricsConfiguration
{
@Bean
FileDescriptorMetrics
customFileDescriptorMetrics
()
{
return
new
FileDescriptorMetrics
();
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment