Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
a90c7181
Commit
a90c7181
authored
Jun 01, 2021
by
Stephane Nicoll
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Polish "Add auto-configuration for DiskSpaceMetrics"
See gh-26001
parent
e3f03dd5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
25 deletions
+17
-25
JvmMetricsAutoConfiguration.java
...te/autoconfigure/metrics/JvmMetricsAutoConfiguration.java
+1
-1
JvmMetricsAutoConfigurationTests.java
...toconfigure/metrics/JvmMetricsAutoConfigurationTests.java
+16
-24
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/JvmMetricsAutoConfiguration.java
View file @
a90c7181
/*
* Copyright 2012-202
0
the original author or authors.
* Copyright 2012-202
1
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/JvmMetricsAutoConfigurationTests.java
View file @
a90c7181
/*
* Copyright 2012-20
19
the original author or authors.
* Copyright 2012-20
21
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -27,7 +27,9 @@ import org.junit.jupiter.api.Test;
import
org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.test.context.assertj.AssertableApplicationContext
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.test.context.runner.ContextConsumer
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
...
...
@@ -47,53 +49,43 @@ class JvmMetricsAutoConfigurationTests {
@Test
void
autoConfiguresJvmMetrics
()
{
this
.
contextRunner
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
JvmGcMetrics
.
class
)
.
hasSingleBean
(
JvmMemoryMetrics
.
class
).
hasSingleBean
(
JvmThreadMetrics
.
class
)
.
hasSingleBean
(
ClassLoaderMetrics
.
class
).
hasSingleBean
(
DiskSpaceMetrics
.
class
));
this
.
contextRunner
.
run
(
assertMetricsBeans
());
}
@Test
void
allowsCustomJvmGcMetricsToBeUsed
()
{
this
.
contextRunner
.
withUserConfiguration
(
CustomJvmGcMetricsConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
JvmGcMetrics
.
class
).
hasBean
(
"customJvmGcMetrics"
)
.
hasSingleBean
(
JvmMemoryMetrics
.
class
).
hasSingleBean
(
JvmThreadMetrics
.
class
)
.
hasSingleBean
(
ClassLoaderMetrics
.
class
).
hasSingleBean
(
DiskSpaceMetrics
.
class
));
.
run
(
assertMetricsBeans
().
andThen
((
context
)
->
assertThat
(
context
).
hasBean
(
"customJvmGcMetrics"
)));
}
@Test
void
allowsCustomJvmMemoryMetricsToBeUsed
()
{
this
.
contextRunner
.
withUserConfiguration
(
CustomJvmMemoryMetricsConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
JvmGcMetrics
.
class
)
.
hasSingleBean
(
JvmMemoryMetrics
.
class
).
hasBean
(
"customJvmMemoryMetrics"
)
.
hasSingleBean
(
JvmThreadMetrics
.
class
).
hasSingleBean
(
ClassLoaderMetrics
.
class
)
.
hasSingleBean
(
DiskSpaceMetrics
.
class
));
.
run
(
assertMetricsBeans
().
andThen
((
context
)
->
assertThat
(
context
).
hasBean
(
"customJvmMemoryMetrics"
)));
}
@Test
void
allowsCustomJvmThreadMetricsToBeUsed
()
{
this
.
contextRunner
.
withUserConfiguration
(
CustomJvmThreadMetricsConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
JvmGcMetrics
.
class
)
.
hasSingleBean
(
JvmMemoryMetrics
.
class
).
hasSingleBean
(
JvmThreadMetrics
.
class
)
.
hasBean
(
"customJvmThreadMetrics"
).
hasSingleBean
(
ClassLoaderMetrics
.
class
)
.
hasSingleBean
(
DiskSpaceMetrics
.
class
));
.
run
(
assertMetricsBeans
().
andThen
((
context
)
->
assertThat
(
context
).
hasBean
(
"customJvmThreadMetrics"
)));
}
@Test
void
allowsCustomClassLoaderMetricsToBeUsed
()
{
this
.
contextRunner
.
withUserConfiguration
(
CustomClassLoaderMetricsConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
JvmGcMetrics
.
class
)
.
hasSingleBean
(
JvmMemoryMetrics
.
class
).
hasSingleBean
(
JvmThreadMetrics
.
class
)
.
hasSingleBean
(
ClassLoaderMetrics
.
class
).
hasBean
(
"customClassLoaderMetrics"
)
.
hasSingleBean
(
DiskSpaceMetrics
.
class
));
this
.
contextRunner
.
withUserConfiguration
(
CustomClassLoaderMetricsConfiguration
.
class
).
run
(
assertMetricsBeans
().
andThen
((
context
)
->
assertThat
(
context
).
hasBean
(
"customClassLoaderMetrics"
)));
}
@Test
void
allowsCustomDiskSpaceMetricsToBeUsed
()
{
this
.
contextRunner
.
withUserConfiguration
(
CustomDiskSpaceMetricsConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
JvmGcMetrics
.
class
)
.
hasSingleBean
(
JvmMemoryMetrics
.
class
).
hasSingleBean
(
JvmThreadMetrics
.
class
)
.
hasSingleBean
(
ClassLoaderMetrics
.
class
).
hasSingleBean
(
DiskSpaceMetrics
.
class
)
.
hasBean
(
"customDiskSpaceMetrics"
));
.
run
(
assertMetricsBeans
().
andThen
((
context
)
->
assertThat
(
context
).
hasBean
(
"customDiskSpaceMetrics"
)));
}
private
ContextConsumer
<
AssertableApplicationContext
>
assertMetricsBeans
()
{
return
(
context
)
->
assertThat
(
context
).
hasSingleBean
(
JvmGcMetrics
.
class
).
hasSingleBean
(
JvmMemoryMetrics
.
class
)
.
hasSingleBean
(
JvmThreadMetrics
.
class
).
hasSingleBean
(
ClassLoaderMetrics
.
class
)
.
hasSingleBean
(
DiskSpaceMetrics
.
class
);
}
@Configuration
(
proxyBeanMethods
=
false
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment