Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
ad767ca4
Commit
ad767ca4
authored
Apr 04, 2019
by
Madhura Bhave
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Polish "Simplify the configuration of the ProtocolHandler"
Closes gh-16342
parent
2eaa64f8
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
35 additions
and
19 deletions
+35
-19
ReactiveWebServerFactoryConfiguration.java
...e/web/reactive/ReactiveWebServerFactoryConfiguration.java
+1
-1
ServletWebServerFactoryConfiguration.java
...ure/web/servlet/ServletWebServerFactoryConfiguration.java
+1
-1
ConfigurableTomcatWebServerFactory.java
...b/embedded/tomcat/ConfigurableTomcatWebServerFactory.java
+1
-1
TomcatReactiveWebServerFactory.java
...t/web/embedded/tomcat/TomcatReactiveWebServerFactory.java
+16
-8
TomcatServletWebServerFactory.java
...ot/web/embedded/tomcat/TomcatServletWebServerFactory.java
+16
-8
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/ReactiveWebServerFactoryConfiguration.java
View file @
ad767ca4
...
@@ -78,7 +78,7 @@ abstract class ReactiveWebServerFactoryConfiguration {
...
@@ -78,7 +78,7 @@ abstract class ReactiveWebServerFactoryConfiguration {
public
TomcatReactiveWebServerFactory
tomcatReactiveWebServerFactory
(
public
TomcatReactiveWebServerFactory
tomcatReactiveWebServerFactory
(
ObjectProvider
<
TomcatConnectorCustomizer
>
connectorCustomizers
,
ObjectProvider
<
TomcatConnectorCustomizer
>
connectorCustomizers
,
ObjectProvider
<
TomcatContextCustomizer
>
contextCustomizers
,
ObjectProvider
<
TomcatContextCustomizer
>
contextCustomizers
,
ObjectProvider
<
TomcatProtocolHandlerCustomizer
>
protocolHandlerCustomizers
)
{
ObjectProvider
<
TomcatProtocolHandlerCustomizer
<?>
>
protocolHandlerCustomizers
)
{
TomcatReactiveWebServerFactory
factory
=
new
TomcatReactiveWebServerFactory
();
TomcatReactiveWebServerFactory
factory
=
new
TomcatReactiveWebServerFactory
();
factory
.
getTomcatConnectorCustomizers
().
addAll
(
factory
.
getTomcatConnectorCustomizers
().
addAll
(
connectorCustomizers
.
orderedStream
().
collect
(
Collectors
.
toList
()));
connectorCustomizers
.
orderedStream
().
collect
(
Collectors
.
toList
()));
...
...
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/ServletWebServerFactoryConfiguration.java
View file @
ad767ca4
...
@@ -68,7 +68,7 @@ class ServletWebServerFactoryConfiguration {
...
@@ -68,7 +68,7 @@ class ServletWebServerFactoryConfiguration {
public
TomcatServletWebServerFactory
tomcatServletWebServerFactory
(
public
TomcatServletWebServerFactory
tomcatServletWebServerFactory
(
ObjectProvider
<
TomcatConnectorCustomizer
>
connectorCustomizers
,
ObjectProvider
<
TomcatConnectorCustomizer
>
connectorCustomizers
,
ObjectProvider
<
TomcatContextCustomizer
>
contextCustomizers
,
ObjectProvider
<
TomcatContextCustomizer
>
contextCustomizers
,
ObjectProvider
<
TomcatProtocolHandlerCustomizer
>
protocolHandlerCustomizers
)
{
ObjectProvider
<
TomcatProtocolHandlerCustomizer
<?>
>
protocolHandlerCustomizers
)
{
TomcatServletWebServerFactory
factory
=
new
TomcatServletWebServerFactory
();
TomcatServletWebServerFactory
factory
=
new
TomcatServletWebServerFactory
();
factory
.
getTomcatConnectorCustomizers
().
addAll
(
factory
.
getTomcatConnectorCustomizers
().
addAll
(
connectorCustomizers
.
orderedStream
().
collect
(
Collectors
.
toList
()));
connectorCustomizers
.
orderedStream
().
collect
(
Collectors
.
toList
()));
...
...
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/ConfigurableTomcatWebServerFactory.java
View file @
ad767ca4
...
@@ -74,7 +74,7 @@ public interface ConfigurableTomcatWebServerFactory extends ConfigurableWebServe
...
@@ -74,7 +74,7 @@ public interface ConfigurableTomcatWebServerFactory extends ConfigurableWebServe
* @param tomcatProtocolHandlerCustomizers the customizers to add
* @param tomcatProtocolHandlerCustomizers the customizers to add
*/
*/
void
addProtocolHandlerCustomizers
(
void
addProtocolHandlerCustomizers
(
TomcatProtocolHandlerCustomizer
...
tomcatProtocolHandlerCustomizers
);
TomcatProtocolHandlerCustomizer
<?>
...
tomcatProtocolHandlerCustomizers
);
/**
/**
* Set the character encoding to use for URL decoding. If not specified 'UTF-8' will
* Set the character encoding to use for URL decoding. If not specified 'UTF-8' will
...
...
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TomcatReactiveWebServerFactory.java
View file @
ad767ca4
...
@@ -34,9 +34,11 @@ import org.apache.catalina.core.AprLifecycleListener;
...
@@ -34,9 +34,11 @@ import org.apache.catalina.core.AprLifecycleListener;
import
org.apache.catalina.loader.WebappLoader
;
import
org.apache.catalina.loader.WebappLoader
;
import
org.apache.catalina.startup.Tomcat
;
import
org.apache.catalina.startup.Tomcat
;
import
org.apache.coyote.AbstractProtocol
;
import
org.apache.coyote.AbstractProtocol
;
import
org.apache.coyote.ProtocolHandler
;
import
org.apache.coyote.http2.Http2Protocol
;
import
org.apache.coyote.http2.Http2Protocol
;
import
org.apache.tomcat.util.scan.StandardJarScanFilter
;
import
org.apache.tomcat.util.scan.StandardJarScanFilter
;
import
org.springframework.boot.util.LambdaSafe
;
import
org.springframework.boot.web.reactive.server.AbstractReactiveWebServerFactory
;
import
org.springframework.boot.web.reactive.server.AbstractReactiveWebServerFactory
;
import
org.springframework.boot.web.reactive.server.ReactiveWebServerFactory
;
import
org.springframework.boot.web.reactive.server.ReactiveWebServerFactory
;
import
org.springframework.boot.web.server.WebServer
;
import
org.springframework.boot.web.server.WebServer
;
...
@@ -72,7 +74,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
...
@@ -72,7 +74,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
private
List
<
TomcatConnectorCustomizer
>
tomcatConnectorCustomizers
=
new
ArrayList
<>();
private
List
<
TomcatConnectorCustomizer
>
tomcatConnectorCustomizers
=
new
ArrayList
<>();
private
List
<
TomcatProtocolHandlerCustomizer
>
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>();
private
List
<
TomcatProtocolHandlerCustomizer
<?>
>
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>();
private
String
protocol
=
DEFAULT_PROTOCOL
;
private
String
protocol
=
DEFAULT_PROTOCOL
;
...
@@ -170,10 +172,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
...
@@ -170,10 +172,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
if
(
connector
.
getProtocolHandler
()
instanceof
AbstractProtocol
)
{
if
(
connector
.
getProtocolHandler
()
instanceof
AbstractProtocol
)
{
customizeProtocol
((
AbstractProtocol
<?>)
connector
.
getProtocolHandler
());
customizeProtocol
((
AbstractProtocol
<?>)
connector
.
getProtocolHandler
());
}
}
invokeProtocolHandlerCustomizers
(
connector
);
this
.
tomcatProtocolHandlerCustomizers
.
forEach
(
(
customizer
)
->
customizer
.
customize
(
connector
.
getProtocolHandler
()));
if
(
getUriEncoding
()
!=
null
)
{
if
(
getUriEncoding
()
!=
null
)
{
connector
.
setURIEncoding
(
getUriEncoding
().
name
());
connector
.
setURIEncoding
(
getUriEncoding
().
name
());
}
}
...
@@ -190,6 +189,15 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
...
@@ -190,6 +189,15 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
}
}
}
}
@SuppressWarnings
(
"unchecked"
)
private
void
invokeProtocolHandlerCustomizers
(
Connector
connector
)
{
ProtocolHandler
protocolHandler
=
connector
.
getProtocolHandler
();
LambdaSafe
.
callbacks
(
TomcatProtocolHandlerCustomizer
.
class
,
this
.
tomcatProtocolHandlerCustomizers
,
protocolHandler
)
.
invoke
((
customizer
)
->
customizer
.
customize
(
protocolHandler
));
}
private
void
customizeProtocol
(
AbstractProtocol
<?>
protocol
)
{
private
void
customizeProtocol
(
AbstractProtocol
<?>
protocol
)
{
if
(
getAddress
()
!=
null
)
{
if
(
getAddress
()
!=
null
)
{
protocol
.
setAddress
(
getAddress
());
protocol
.
setAddress
(
getAddress
());
...
@@ -287,7 +295,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
...
@@ -287,7 +295,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
* @param tomcatProtocolHandlerCustomizers the customizers to set
* @param tomcatProtocolHandlerCustomizers the customizers to set
*/
*/
public
void
setTomcatProtocolHandlerCustomizers
(
public
void
setTomcatProtocolHandlerCustomizers
(
Collection
<?
extends
TomcatProtocolHandlerCustomizer
>
tomcatProtocolHandlerCustomizers
)
{
Collection
<?
extends
TomcatProtocolHandlerCustomizer
<?>
>
tomcatProtocolHandlerCustomizers
)
{
Assert
.
notNull
(
tomcatProtocolHandlerCustomizers
,
Assert
.
notNull
(
tomcatProtocolHandlerCustomizers
,
"TomcatProtocolHandlerCustomizers must not be null"
);
"TomcatProtocolHandlerCustomizers must not be null"
);
this
.
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>(
this
.
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>(
...
@@ -301,7 +309,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
...
@@ -301,7 +309,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
*/
*/
@Override
@Override
public
void
addProtocolHandlerCustomizers
(
public
void
addProtocolHandlerCustomizers
(
TomcatProtocolHandlerCustomizer
...
tomcatProtocolHandlerCustomizers
)
{
TomcatProtocolHandlerCustomizer
<?>
...
tomcatProtocolHandlerCustomizers
)
{
Assert
.
notNull
(
tomcatProtocolHandlerCustomizers
,
Assert
.
notNull
(
tomcatProtocolHandlerCustomizers
,
"TomcatProtocolHandlerCustomizers must not be null"
);
"TomcatProtocolHandlerCustomizers must not be null"
);
this
.
tomcatProtocolHandlerCustomizers
this
.
tomcatProtocolHandlerCustomizers
...
@@ -313,7 +321,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
...
@@ -313,7 +321,7 @@ public class TomcatReactiveWebServerFactory extends AbstractReactiveWebServerFac
* will be applied to the Tomcat {@link Connector}.
* will be applied to the Tomcat {@link Connector}.
* @return the customizers that will be applied
* @return the customizers that will be applied
*/
*/
public
Collection
<
TomcatProtocolHandlerCustomizer
>
getTomcatProtocolHandlerCustomizers
()
{
public
Collection
<
TomcatProtocolHandlerCustomizer
<?>
>
getTomcatProtocolHandlerCustomizers
()
{
return
this
.
tomcatProtocolHandlerCustomizers
;
return
this
.
tomcatProtocolHandlerCustomizers
;
}
}
...
...
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TomcatServletWebServerFactory.java
View file @
ad767ca4
...
@@ -58,9 +58,11 @@ import org.apache.catalina.webresources.AbstractResourceSet;
...
@@ -58,9 +58,11 @@ import org.apache.catalina.webresources.AbstractResourceSet;
import
org.apache.catalina.webresources.EmptyResource
;
import
org.apache.catalina.webresources.EmptyResource
;
import
org.apache.catalina.webresources.StandardRoot
;
import
org.apache.catalina.webresources.StandardRoot
;
import
org.apache.coyote.AbstractProtocol
;
import
org.apache.coyote.AbstractProtocol
;
import
org.apache.coyote.ProtocolHandler
;
import
org.apache.coyote.http2.Http2Protocol
;
import
org.apache.coyote.http2.Http2Protocol
;
import
org.apache.tomcat.util.scan.StandardJarScanFilter
;
import
org.apache.tomcat.util.scan.StandardJarScanFilter
;
import
org.springframework.boot.util.LambdaSafe
;
import
org.springframework.boot.web.server.ErrorPage
;
import
org.springframework.boot.web.server.ErrorPage
;
import
org.springframework.boot.web.server.MimeMappings
;
import
org.springframework.boot.web.server.MimeMappings
;
import
org.springframework.boot.web.server.WebServer
;
import
org.springframework.boot.web.server.WebServer
;
...
@@ -117,7 +119,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
...
@@ -117,7 +119,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
private
List
<
TomcatConnectorCustomizer
>
tomcatConnectorCustomizers
=
new
ArrayList
<>();
private
List
<
TomcatConnectorCustomizer
>
tomcatConnectorCustomizers
=
new
ArrayList
<>();
private
List
<
TomcatProtocolHandlerCustomizer
>
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>();
private
List
<
TomcatProtocolHandlerCustomizer
<?>
>
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>();
private
List
<
Connector
>
additionalTomcatConnectors
=
new
ArrayList
<>();
private
List
<
Connector
>
additionalTomcatConnectors
=
new
ArrayList
<>();
...
@@ -305,10 +307,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
...
@@ -305,10 +307,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
if
(
connector
.
getProtocolHandler
()
instanceof
AbstractProtocol
)
{
if
(
connector
.
getProtocolHandler
()
instanceof
AbstractProtocol
)
{
customizeProtocol
((
AbstractProtocol
<?>)
connector
.
getProtocolHandler
());
customizeProtocol
((
AbstractProtocol
<?>)
connector
.
getProtocolHandler
());
}
}
invokeProtocolHandlerCustomizers
(
connector
);
this
.
tomcatProtocolHandlerCustomizers
.
forEach
(
(
customizer
)
->
customizer
.
customize
(
connector
.
getProtocolHandler
()));
if
(
getUriEncoding
()
!=
null
)
{
if
(
getUriEncoding
()
!=
null
)
{
connector
.
setURIEncoding
(
getUriEncoding
().
name
());
connector
.
setURIEncoding
(
getUriEncoding
().
name
());
}
}
...
@@ -331,6 +330,15 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
...
@@ -331,6 +330,15 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
}
}
}
}
@SuppressWarnings
(
"unchecked"
)
private
void
invokeProtocolHandlerCustomizers
(
Connector
connector
)
{
ProtocolHandler
protocolHandler
=
connector
.
getProtocolHandler
();
LambdaSafe
.
callbacks
(
TomcatProtocolHandlerCustomizer
.
class
,
this
.
tomcatProtocolHandlerCustomizers
,
protocolHandler
)
.
invoke
((
customizer
)
->
customizer
.
customize
(
protocolHandler
));
}
private
void
customizeSsl
(
Connector
connector
)
{
private
void
customizeSsl
(
Connector
connector
)
{
new
SslConnectorCustomizer
(
getSsl
(),
getSslStoreProvider
()).
customize
(
connector
);
new
SslConnectorCustomizer
(
getSsl
(),
getSslStoreProvider
()).
customize
(
connector
);
if
(
getHttp2
()
!=
null
&&
getHttp2
().
isEnabled
())
{
if
(
getHttp2
()
!=
null
&&
getHttp2
().
isEnabled
())
{
...
@@ -631,7 +639,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
...
@@ -631,7 +639,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
* @param tomcatProtocolHandlerCustomizer the customizers to set
* @param tomcatProtocolHandlerCustomizer the customizers to set
*/
*/
public
void
setTomcatProtocolHandlerCustomizers
(
public
void
setTomcatProtocolHandlerCustomizers
(
Collection
<?
extends
TomcatProtocolHandlerCustomizer
>
tomcatProtocolHandlerCustomizer
)
{
Collection
<?
extends
TomcatProtocolHandlerCustomizer
<?>
>
tomcatProtocolHandlerCustomizer
)
{
Assert
.
notNull
(
tomcatProtocolHandlerCustomizer
,
Assert
.
notNull
(
tomcatProtocolHandlerCustomizer
,
"TomcatProtocolHandlerCustomizers must not be null"
);
"TomcatProtocolHandlerCustomizers must not be null"
);
this
.
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>(
this
.
tomcatProtocolHandlerCustomizers
=
new
ArrayList
<>(
...
@@ -645,7 +653,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
...
@@ -645,7 +653,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
*/
*/
@Override
@Override
public
void
addProtocolHandlerCustomizers
(
public
void
addProtocolHandlerCustomizers
(
TomcatProtocolHandlerCustomizer
...
tomcatProtocolHandlerCustomizers
)
{
TomcatProtocolHandlerCustomizer
<?>
...
tomcatProtocolHandlerCustomizers
)
{
Assert
.
notNull
(
tomcatProtocolHandlerCustomizers
,
Assert
.
notNull
(
tomcatProtocolHandlerCustomizers
,
"TomcatProtocolHandlerCustomizers must not be null"
);
"TomcatProtocolHandlerCustomizers must not be null"
);
this
.
tomcatProtocolHandlerCustomizers
this
.
tomcatProtocolHandlerCustomizers
...
@@ -657,7 +665,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
...
@@ -657,7 +665,7 @@ public class TomcatServletWebServerFactory extends AbstractServletWebServerFacto
* will be applied to the Tomcat {@link Connector}.
* will be applied to the Tomcat {@link Connector}.
* @return the customizers that will be applied
* @return the customizers that will be applied
*/
*/
public
Collection
<
TomcatProtocolHandlerCustomizer
>
getTomcatProtocolHandlerCustomizers
()
{
public
Collection
<
TomcatProtocolHandlerCustomizer
<?>
>
getTomcatProtocolHandlerCustomizers
()
{
return
this
.
tomcatProtocolHandlerCustomizers
;
return
this
.
tomcatProtocolHandlerCustomizers
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment