Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
aee22bfb
Commit
aee22bfb
authored
Dec 11, 2019
by
med-amine.dahmen
Committed by
Stephane Nicoll
Feb 07, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make Kubernetes detection slightly more efficient
See gh-19002
parent
37575d78
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
36 additions
and
1 deletion
+36
-1
CloudPlatform.java
...in/java/org/springframework/boot/cloud/CloudPlatform.java
+17
-0
CloudPlatformTests.java
...va/org/springframework/boot/cloud/CloudPlatformTests.java
+19
-1
No files found.
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/cloud/CloudPlatform.java
View file @
aee22bfb
...
...
@@ -16,6 +16,8 @@
package
org
.
springframework
.
boot
.
cloud
;
import
java.io.File
;
import
org.springframework.core.env.ConfigurableEnvironment
;
import
org.springframework.core.env.EnumerablePropertySource
;
import
org.springframework.core.env.Environment
;
...
...
@@ -77,8 +79,18 @@ public enum CloudPlatform {
private
static
final
String
SERVICE_PORT_SUFFIX
=
"_SERVICE_PORT"
;
private
static
final
String
SECRET_LOCATION
=
"/var/run/secrets/kubernetes.io"
;
private
static
final
String
KUBERNETES_SERVICE_HOST
=
"KUBERNETES_SERVICE_HOST"
;
private
static
final
String
KUBERNETES_SERVICE_PORT
=
"KUBERNETES_SERVICE_PORT"
;
@Override
public
boolean
isActive
(
Environment
environment
)
{
if
(
environment
.
containsProperty
(
KUBERNETES_SERVICE_HOST
)
||
environment
.
containsProperty
(
KUBERNETES_SERVICE_PORT
)
||
isSecretLocationExists
())
{
return
true
;
}
if
(
environment
instanceof
ConfigurableEnvironment
)
{
return
isActive
((
ConfigurableEnvironment
)
environment
);
}
...
...
@@ -107,6 +119,11 @@ public enum CloudPlatform {
return
false
;
}
private
boolean
isSecretLocationExists
()
{
File
file
=
new
File
(
SECRET_LOCATION
);
return
file
.
exists
()
&&
file
.
isDirectory
();
}
};
/**
...
...
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/cloud/CloudPlatformTests.java
View file @
aee22bfb
...
...
@@ -16,6 +16,7 @@
package
org
.
springframework
.
boot
.
cloud
;
import
java.io.File
;
import
java.util.Collections
;
import
java.util.HashMap
;
import
java.util.Map
;
...
...
@@ -97,6 +98,20 @@ class CloudPlatformTests {
assertThat
(
platform
.
isActive
(
environment
)).
isTrue
();
}
@Test
void
getActiveWhenHasKubernetesHostAndPortShouldReturnKubernetes
()
{
MockEnvironment
environment
=
new
MockEnvironment
();
Map
<
String
,
Object
>
source
=
new
HashMap
<>();
source
.
put
(
"KUBERNETES_SERVICE_HOST"
,
"---"
);
source
.
put
(
"KUBERNETES_SERVICE_PORT"
,
"8080"
);
PropertySource
<?>
propertySource
=
new
SystemEnvironmentPropertySource
(
StandardEnvironment
.
SYSTEM_ENVIRONMENT_PROPERTY_SOURCE_NAME
,
source
);
environment
.
getPropertySources
().
addFirst
(
propertySource
);
CloudPlatform
platform
=
CloudPlatform
.
getActive
(
environment
);
assertThat
(
platform
).
isEqualTo
(
CloudPlatform
.
KUBERNETES
);
assertThat
(
platform
.
isActive
(
environment
)).
isTrue
();
}
@Test
void
getActiveWhenHasServiceHostAndNoServicePortShouldNotReturnKubernetes
()
{
MockEnvironment
environment
=
new
MockEnvironment
();
...
...
@@ -105,7 +120,10 @@ class CloudPlatformTests {
Collections
.
singletonMap
(
"EXAMPLE_SERVICE_HOST"
,
"---"
));
environment
.
getPropertySources
().
addFirst
(
propertySource
);
CloudPlatform
platform
=
CloudPlatform
.
getActive
(
environment
);
assertThat
(
platform
).
isNull
();
File
path
=
new
File
(
"/var/run/secrets/kubernetes.io"
);
if
(!
path
.
exists
()
&&
!
path
.
isDirectory
())
{
assertThat
(
platform
).
isNull
();
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment