Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
b0bf2dd7
Commit
b0bf2dd7
authored
Jul 14, 2019
by
dreis2211
Committed by
Phillip Webb
Jul 14, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Migrate to ApplicationContextRunner
Migrate a new tests to use the `ApplicationContextRunner`. See gh-17491
parent
0cb6a7f4
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
25 additions
and
50 deletions
+25
-50
ConditionalOnMissingBeanWithFilteredClasspathTests.java
...n/ConditionalOnMissingBeanWithFilteredClasspathTests.java
+4
-11
HttpMessageConvertersAutoConfigurationWithoutJacksonTests.java
...essageConvertersAutoConfigurationWithoutJacksonTests.java
+5
-13
ValidationAutoConfigurationWithHibernateValidatorMissingElImplTests.java
...onfigurationWithHibernateValidatorMissingElImplTests.java
+8
-13
ValidationAutoConfigurationWithoutValidatorTests.java
...ion/ValidationAutoConfigurationWithoutValidatorTests.java
+8
-13
No files found.
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanWithFilteredClasspathTests.java
View file @
b0bf2dd7
...
...
@@ -16,14 +16,13 @@
package
org
.
springframework
.
boot
.
autoconfigure
.
condition
;
import
org.junit.After
;
import
org.junit.Test
;
import
org.junit.runner.RunWith
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions
;
import
org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathRunner
;
import
org.springframework.cache.caffeine.CaffeineCacheManager
;
import
org.springframework.context.annotation.AnnotationConfigApplicationContext
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
...
...
@@ -40,18 +39,12 @@ import static org.assertj.core.api.Assertions.assertThat;
@ClassPathExclusions
(
"spring-context-support-*.jar"
)
public
class
ConditionalOnMissingBeanWithFilteredClasspathTests
{
private
final
AnnotationConfigApplicationContext
context
=
new
AnnotationConfigApplicationContext
();
@After
public
void
closeContext
()
{
this
.
context
.
close
();
}
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
.
withUserConfiguration
(
OnBeanTypeConfiguration
.
class
);
@Test
public
void
testNameOnMissingBeanTypeWithMissingImport
()
{
this
.
context
.
register
(
OnBeanTypeConfiguration
.
class
);
this
.
context
.
refresh
();
assertThat
(
this
.
context
.
containsBean
(
"foo"
)).
isTrue
();
this
.
contextRunner
.
run
((
context
)
->
assertThat
(
context
).
hasBean
(
"foo"
));
}
@Configuration
(
proxyBeanMethods
=
false
)
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/http/HttpMessageConvertersAutoConfigurationWithoutJacksonTests.java
View file @
b0bf2dd7
...
...
@@ -16,13 +16,13 @@
package
org
.
springframework
.
boot
.
autoconfigure
.
http
;
import
org.junit.After
;
import
org.junit.Test
;
import
org.junit.runner.RunWith
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions
;
import
org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathRunner
;
import
org.springframework.context.annotation.AnnotationConfigApplicationContext
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
...
@@ -36,20 +36,12 @@ import static org.assertj.core.api.Assertions.assertThat;
@ClassPathExclusions
(
"jackson-*.jar"
)
public
class
HttpMessageConvertersAutoConfigurationWithoutJacksonTests
{
private
AnnotationConfigApplicationContext
context
=
new
AnnotationConfigApplicationContext
();
@After
public
void
close
()
{
if
(
this
.
context
!=
null
)
{
this
.
context
.
close
();
}
}
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
AutoConfigurations
.
of
(
HttpMessageConvertersAutoConfiguration
.
class
));
@Test
public
void
autoConfigurationWorksWithSpringHateoasButWithoutJackson
()
{
this
.
context
.
register
(
HttpMessageConvertersAutoConfiguration
.
class
);
this
.
context
.
refresh
();
assertThat
(
this
.
context
.
getBeansOfType
(
HttpMessageConverters
.
class
)).
hasSize
(
1
);
this
.
contextRunner
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
HttpMessageConverters
.
class
));
}
}
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/validation/ValidationAutoConfigurationWithHibernateValidatorMissingElImplTests.java
View file @
b0bf2dd7
...
...
@@ -18,13 +18,13 @@ package org.springframework.boot.autoconfigure.validation;
import
javax.validation.Validator
;
import
org.junit.After
;
import
org.junit.Test
;
import
org.junit.runner.RunWith
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions
;
import
org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathRunner
;
import
org.springframework.context.annotation.AnnotationConfigApplicationContext
;
import
org.springframework.validation.beanvalidation.MethodValidationPostProcessor
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
...
@@ -39,20 +39,15 @@ import static org.assertj.core.api.Assertions.assertThat;
@ClassPathExclusions
({
"tomcat-embed-el-*.jar"
,
"el-api-*.jar"
})
public
class
ValidationAutoConfigurationWithHibernateValidatorMissingElImplTests
{
private
AnnotationConfigApplicationContext
context
;
@After
public
void
close
()
{
if
(
this
.
context
!=
null
)
{
this
.
context
.
close
();
}
}
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
AutoConfigurations
.
of
(
ValidationAutoConfiguration
.
class
));
@Test
public
void
missingElDependencyIsTolerated
()
{
this
.
context
=
new
AnnotationConfigApplicationContext
(
ValidationAutoConfiguration
.
class
);
assertThat
(
this
.
context
.
getBeansOfType
(
Validator
.
class
)).
hasSize
(
1
);
assertThat
(
this
.
context
.
getBeansOfType
(
MethodValidationPostProcessor
.
class
)).
hasSize
(
1
);
this
.
contextRunner
.
run
((
context
)
->
{
assertThat
(
context
).
hasSingleBean
(
Validator
.
class
);
assertThat
(
context
).
hasSingleBean
(
MethodValidationPostProcessor
.
class
);
});
}
}
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/validation/ValidationAutoConfigurationWithoutValidatorTests.java
View file @
b0bf2dd7
...
...
@@ -18,13 +18,13 @@ package org.springframework.boot.autoconfigure.validation;
import
javax.validation.Validator
;
import
org.junit.After
;
import
org.junit.Test
;
import
org.junit.runner.RunWith
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.testsupport.runner.classpath.ClassPathExclusions
;
import
org.springframework.boot.testsupport.runner.classpath.ModifiedClassPathRunner
;
import
org.springframework.context.annotation.AnnotationConfigApplicationContext
;
import
org.springframework.validation.beanvalidation.MethodValidationPostProcessor
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
...
@@ -38,20 +38,15 @@ import static org.assertj.core.api.Assertions.assertThat;
@ClassPathExclusions
(
"hibernate-validator-*.jar"
)
public
class
ValidationAutoConfigurationWithoutValidatorTests
{
private
AnnotationConfigApplicationContext
context
;
@After
public
void
close
()
{
if
(
this
.
context
!=
null
)
{
this
.
context
.
close
();
}
}
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
AutoConfigurations
.
of
(
ValidationAutoConfiguration
.
class
));
@Test
public
void
validationIsDisabled
()
{
this
.
context
=
new
AnnotationConfigApplicationContext
(
ValidationAutoConfiguration
.
class
);
assertThat
(
this
.
context
.
getBeansOfType
(
Validator
.
class
)).
isEmpty
();
assertThat
(
this
.
context
.
getBeansOfType
(
MethodValidationPostProcessor
.
class
)).
isEmpty
();
this
.
contextRunner
.
run
((
context
)
->
{
assertThat
(
context
).
doesNotHaveBean
(
Validator
.
class
);
assertThat
(
context
).
doesNotHaveBean
(
MethodValidationPostProcessor
.
class
);
});
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment