Commit b7d08ee5 authored by Stephane Nicoll's avatar Stephane Nicoll

Merge pull request #11294 from izeye:remove-final

* pr/11294:
  Remove "final" keywords
parents bd7bd6ed 6d54072e
...@@ -31,7 +31,7 @@ public final class AuthorizationExceptionMatcher { ...@@ -31,7 +31,7 @@ public final class AuthorizationExceptionMatcher {
private AuthorizationExceptionMatcher() { private AuthorizationExceptionMatcher() {
} }
public static Matcher<?> withReason(final Reason reason) { public static Matcher<?> withReason(Reason reason) {
return new CustomMatcher<Object>( return new CustomMatcher<Object>(
"CloudFoundryAuthorizationException with " + reason + " reason") { "CloudFoundryAuthorizationException with " + reason + " reason") {
......
...@@ -252,7 +252,7 @@ class OnClassCondition extends SpringBootCondition ...@@ -252,7 +252,7 @@ class OnClassCondition extends SpringBootCondition
private volatile ConditionOutcome[] outcomes; private volatile ConditionOutcome[] outcomes;
private ThreadedOutcomesResolver(final OutcomesResolver outcomesResolver) { private ThreadedOutcomesResolver(OutcomesResolver outcomesResolver) {
this.thread = new Thread( this.thread = new Thread(
() -> this.outcomes = outcomesResolver.resolveOutcomes()); () -> this.outcomes = outcomesResolver.resolveOutcomes());
this.thread.start(); this.thread.start();
......
...@@ -110,7 +110,7 @@ public class MessageSourceProperties { ...@@ -110,7 +110,7 @@ public class MessageSourceProperties {
return this.useCodeAsDefaultMessage; return this.useCodeAsDefaultMessage;
} }
public void setUseCodeAsDefaultMessage(final boolean useCodeAsDefaultMessage) { public void setUseCodeAsDefaultMessage(boolean useCodeAsDefaultMessage) {
this.useCodeAsDefaultMessage = useCodeAsDefaultMessage; this.useCodeAsDefaultMessage = useCodeAsDefaultMessage;
} }
......
...@@ -42,7 +42,7 @@ public class SendGridProperties { ...@@ -42,7 +42,7 @@ public class SendGridProperties {
return this.apiKey; return this.apiKey;
} }
public void setApiKey(final String apiKey) { public void setApiKey(String apiKey) {
this.apiKey = apiKey; this.apiKey = apiKey;
} }
......
...@@ -179,7 +179,7 @@ public class WebFluxAutoConfiguration { ...@@ -179,7 +179,7 @@ public class WebFluxAutoConfiguration {
} }
@Override @Override
public void addFormatters(final FormatterRegistry registry) { public void addFormatters(FormatterRegistry registry) {
for (Converter<?, ?> converter : getBeansOfType(Converter.class)) { for (Converter<?, ?> converter : getBeansOfType(Converter.class)) {
registry.addConverter(converter); registry.addConverter(converter);
} }
......
...@@ -411,7 +411,7 @@ public class DefaultServletWebServerFactoryCustomizer ...@@ -411,7 +411,7 @@ public class DefaultServletWebServerFactoryCustomizer
private static class UndertowCustomizer { private static class UndertowCustomizer {
protected static void customizeUndertow(final ServerProperties serverProperties, protected static void customizeUndertow(ServerProperties serverProperties,
Environment environment, UndertowServletWebServerFactory factory) { Environment environment, UndertowServletWebServerFactory factory) {
ServerProperties.Undertow undertowProperties = serverProperties.getUndertow(); ServerProperties.Undertow undertowProperties = serverProperties.getUndertow();
...@@ -478,7 +478,7 @@ public class DefaultServletWebServerFactoryCustomizer ...@@ -478,7 +478,7 @@ public class DefaultServletWebServerFactoryCustomizer
private static class JettyCustomizer { private static class JettyCustomizer {
public static void customizeJetty(final ServerProperties serverProperties, public static void customizeJetty(ServerProperties serverProperties,
Environment environment, JettyServletWebServerFactory factory) { Environment environment, JettyServletWebServerFactory factory) {
ServerProperties.Jetty jettyProperties = serverProperties.getJetty(); ServerProperties.Jetty jettyProperties = serverProperties.getJetty();
factory.setUseForwardHeaders( factory.setUseForwardHeaders(
......
...@@ -66,7 +66,7 @@ final class WelcomePageHandlerMapping extends AbstractUrlHandlerMapping { ...@@ -66,7 +66,7 @@ final class WelcomePageHandlerMapping extends AbstractUrlHandlerMapping {
applicationContext) != null; applicationContext) != null;
} }
private void setRootViewName(final String viewName) { private void setRootViewName(String viewName) {
ParameterizableViewController controller = new ParameterizableViewController(); ParameterizableViewController controller = new ParameterizableViewController();
controller.setViewName(viewName); controller.setViewName(viewName);
setRootHandler(controller); setRootHandler(controller);
......
...@@ -172,7 +172,7 @@ public class Neo4jPropertiesTests { ...@@ -172,7 +172,7 @@ public class Neo4jPropertiesTests {
} }
} }
public Neo4jProperties load(final boolean embeddedAvailable, String... environment) { public Neo4jProperties load(boolean embeddedAvailable, String... environment) {
AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext(); AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
ctx.setClassLoader(new URLClassLoader(new URL[0], getClass().getClassLoader()) { ctx.setClassLoader(new URLClassLoader(new URL[0], getClass().getClassLoader()) {
......
...@@ -335,7 +335,7 @@ public class ArtemisAutoConfigurationTests { ...@@ -335,7 +335,7 @@ public class ArtemisAutoConfigurationTests {
checkDestination(name, true, shouldExist); checkDestination(name, true, shouldExist);
} }
public void checkDestination(final String name, final boolean pubSub, public void checkDestination(String name, final boolean pubSub,
final boolean shouldExist) { final boolean shouldExist) {
this.jmsTemplate.execute((SessionCallback<Void>) (session) -> { this.jmsTemplate.execute((SessionCallback<Void>) (session) -> {
try { try {
......
...@@ -139,7 +139,7 @@ public class WebSocketMessagingAutoConfigurationTests { ...@@ -139,7 +139,7 @@ public class WebSocketMessagingAutoConfigurationTests {
.getField(compositeDefaultConverter, "converters"); .getField(compositeDefaultConverter, "converters");
} }
private Object performStompSubscription(final String topic) throws Throwable { private Object performStompSubscription(String topic) throws Throwable {
TestPropertyValues TestPropertyValues
.of("server.port:0", "spring.jackson.serialization.indent-output:true") .of("server.port:0", "spring.jackson.serialization.indent-output:true")
.applyTo(this.context); .applyTo(this.context);
......
...@@ -59,7 +59,7 @@ public class HelpCommand extends AbstractCommand { ...@@ -59,7 +59,7 @@ public class HelpCommand extends AbstractCommand {
@Override @Override
public Collection<OptionHelp> getOptionsHelp() { public Collection<OptionHelp> getOptionsHelp() {
List<OptionHelp> help = new ArrayList<>(); List<OptionHelp> help = new ArrayList<>();
for (final Command command : this.commandRunner) { for (Command command : this.commandRunner) {
if (isHelpShown(command)) { if (isHelpShown(command)) {
help.add(new OptionHelp() { help.add(new OptionHelp() {
......
...@@ -65,7 +65,7 @@ public class SpringApplicationRunner { ...@@ -65,7 +65,7 @@ public class SpringApplicationRunner {
* @param sources the files to compile/watch * @param sources the files to compile/watch
* @param args input arguments * @param args input arguments
*/ */
SpringApplicationRunner(final SpringApplicationRunnerConfiguration configuration, SpringApplicationRunner(SpringApplicationRunnerConfiguration configuration,
String[] sources, String... args) { String[] sources, String... args) {
this.configuration = configuration; this.configuration = configuration;
this.sources = sources.clone(); this.sources = sources.clone();
......
...@@ -88,7 +88,7 @@ public class DependencyCustomizer { ...@@ -88,7 +88,7 @@ public class DependencyCustomizer {
* @param classNames the class names to test * @param classNames the class names to test
* @return a nested {@link DependencyCustomizer} * @return a nested {@link DependencyCustomizer}
*/ */
public DependencyCustomizer ifAnyMissingClasses(final String... classNames) { public DependencyCustomizer ifAnyMissingClasses(String... classNames) {
return new DependencyCustomizer(this) { return new DependencyCustomizer(this) {
@Override @Override
protected boolean canAdd() { protected boolean canAdd() {
...@@ -111,7 +111,7 @@ public class DependencyCustomizer { ...@@ -111,7 +111,7 @@ public class DependencyCustomizer {
* @param classNames the class names to test * @param classNames the class names to test
* @return a nested {@link DependencyCustomizer} * @return a nested {@link DependencyCustomizer}
*/ */
public DependencyCustomizer ifAllMissingClasses(final String... classNames) { public DependencyCustomizer ifAllMissingClasses(String... classNames) {
return new DependencyCustomizer(this) { return new DependencyCustomizer(this) {
@Override @Override
protected boolean canAdd() { protected boolean canAdd() {
...@@ -135,7 +135,7 @@ public class DependencyCustomizer { ...@@ -135,7 +135,7 @@ public class DependencyCustomizer {
* @param paths the paths to test * @param paths the paths to test
* @return a nested {@link DependencyCustomizer} * @return a nested {@link DependencyCustomizer}
*/ */
public DependencyCustomizer ifAllResourcesPresent(final String... paths) { public DependencyCustomizer ifAllResourcesPresent(String... paths) {
return new DependencyCustomizer(this) { return new DependencyCustomizer(this) {
@Override @Override
protected boolean canAdd() { protected boolean canAdd() {
...@@ -161,7 +161,7 @@ public class DependencyCustomizer { ...@@ -161,7 +161,7 @@ public class DependencyCustomizer {
* @param paths the paths to test * @param paths the paths to test
* @return a nested {@link DependencyCustomizer} * @return a nested {@link DependencyCustomizer}
*/ */
public DependencyCustomizer ifAnyResourcesPresent(final String... paths) { public DependencyCustomizer ifAnyResourcesPresent(String... paths) {
return new DependencyCustomizer(this) { return new DependencyCustomizer(this) {
@Override @Override
protected boolean canAdd() { protected boolean canAdd() {
......
...@@ -179,7 +179,7 @@ public class ExtendedGroovyClassLoader extends GroovyClassLoader { ...@@ -179,7 +179,7 @@ public class ExtendedGroovyClassLoader extends GroovyClassLoader {
parent.getParent()); parent.getParent());
} }
private URL[] getGroovyJars(final ClassLoader parent) { private URL[] getGroovyJars(ClassLoader parent) {
Set<URL> urls = new HashSet<>(); Set<URL> urls = new HashSet<>();
findGroovyJarsDirectly(parent, urls); findGroovyJarsDirectly(parent, urls);
if (urls.isEmpty()) { if (urls.isEmpty()) {
......
...@@ -85,7 +85,7 @@ public class GroovyCompiler { ...@@ -85,7 +85,7 @@ public class GroovyCompiler {
* Create a new {@link GroovyCompiler} instance. * Create a new {@link GroovyCompiler} instance.
* @param configuration the compiler configuration * @param configuration the compiler configuration
*/ */
public GroovyCompiler(final GroovyCompilerConfiguration configuration) { public GroovyCompiler(GroovyCompilerConfiguration configuration) {
this.configuration = configuration; this.configuration = configuration;
this.loader = createLoader(configuration); this.loader = createLoader(configuration);
......
...@@ -100,7 +100,7 @@ public class CliTester implements TestRule { ...@@ -100,7 +100,7 @@ public class CliTester implements TestRule {
return getOutput(); return getOutput();
} }
private <T extends OptionParsingCommand> Future<T> submitCommand(final T command, private <T extends OptionParsingCommand> Future<T> submitCommand(T command,
String... args) { String... args) {
clearUrlHandler(); clearUrlHandler();
final String[] sources = getSources(args); final String[] sources = getSources(args);
...@@ -165,7 +165,7 @@ public class CliTester implements TestRule { ...@@ -165,7 +165,7 @@ public class CliTester implements TestRule {
} }
@Override @Override
public Statement apply(final Statement base, final Description description) { public Statement apply(Statement base, Description description) {
final Statement statement = CliTester.this.outputCapture final Statement statement = CliTester.this.outputCapture
.apply(new RunLauncherStatement(base), description); .apply(new RunLauncherStatement(base), description);
return new Statement() { return new Statement() {
......
...@@ -240,7 +240,7 @@ public class Restarter { ...@@ -240,7 +240,7 @@ public class Restarter {
* Restart the running application. * Restart the running application.
* @param failureHandler a failure handler to deal with application that doesn't start * @param failureHandler a failure handler to deal with application that doesn't start
*/ */
public void restart(final FailureHandler failureHandler) { public void restart(FailureHandler failureHandler) {
if (!this.enabled) { if (!this.enabled) {
this.logger.debug("Application restart is disabled"); this.logger.debug("Application restart is disabled");
return; return;
...@@ -382,7 +382,7 @@ public class Restarter { ...@@ -382,7 +382,7 @@ public class Restarter {
memory.add(new long[102400]); memory.add(new long[102400]);
} }
} }
catch (final OutOfMemoryError ex) { catch (OutOfMemoryError ex) {
// Expected // Expected
} }
} }
...@@ -439,7 +439,7 @@ public class Restarter { ...@@ -439,7 +439,7 @@ public class Restarter {
} }
} }
public Object getOrAddAttribute(final String name, public Object getOrAddAttribute(String name,
final ObjectFactory<?> objectFactory) { final ObjectFactory<?> objectFactory) {
synchronized (this.attributes) { synchronized (this.attributes) {
if (!this.attributes.containsKey(name)) { if (!this.attributes.containsKey(name)) {
...@@ -630,7 +630,7 @@ public class Restarter { ...@@ -630,7 +630,7 @@ public class Restarter {
private class LeakSafeThreadFactory implements ThreadFactory { private class LeakSafeThreadFactory implements ThreadFactory {
@Override @Override
public Thread newThread(final Runnable runnable) { public Thread newThread(Runnable runnable) {
return getLeakSafeThread().callAndWait(() -> { return getLeakSafeThread().callAndWait(() -> {
Thread thread = new Thread(runnable); Thread thread = new Thread(runnable);
thread.setContextClassLoader(Restarter.this.applicationClassLoader); thread.setContextClassLoader(Restarter.this.applicationClassLoader);
......
...@@ -118,7 +118,7 @@ public class RestartClassLoader extends URLClassLoader implements SmartClassLoad ...@@ -118,7 +118,7 @@ public class RestartClassLoader extends URLClassLoader implements SmartClassLoad
} }
@Override @Override
public URL findResource(final String name) { public URL findResource(String name) {
final ClassLoaderFile file = this.updatedFiles.getFile(name); final ClassLoaderFile file = this.updatedFiles.getFile(name);
if (file == null) { if (file == null) {
return super.findResource(name); return super.findResource(name);
...@@ -154,7 +154,7 @@ public class RestartClassLoader extends URLClassLoader implements SmartClassLoad ...@@ -154,7 +154,7 @@ public class RestartClassLoader extends URLClassLoader implements SmartClassLoad
} }
@Override @Override
protected Class<?> findClass(final String name) throws ClassNotFoundException { protected Class<?> findClass(String name) throws ClassNotFoundException {
String path = name.replace('.', '/').concat(".class"); String path = name.replace('.', '/').concat(".class");
final ClassLoaderFile file = this.updatedFiles.getFile(path); final ClassLoaderFile file = this.updatedFiles.getFile(path);
if (file == null) { if (file == null) {
......
...@@ -147,7 +147,7 @@ public class HttpTunnelConnection implements TunnelConnection { ...@@ -147,7 +147,7 @@ public class HttpTunnelConnection implements TunnelConnection {
return size; return size;
} }
private void openNewConnection(final HttpTunnelPayload payload) { private void openNewConnection(HttpTunnelPayload payload) {
HttpTunnelConnection.this.executor.execute(new Runnable() { HttpTunnelConnection.this.executor.execute(new Runnable() {
@Override @Override
......
...@@ -43,7 +43,7 @@ public class MockRestarter implements TestRule { ...@@ -43,7 +43,7 @@ public class MockRestarter implements TestRule {
private Restarter mock = mock(Restarter.class); private Restarter mock = mock(Restarter.class);
@Override @Override
public Statement apply(final Statement base, Description description) { public Statement apply(Statement base, Description description) {
return new Statement() { return new Statement() {
@Override @Override
......
...@@ -44,7 +44,7 @@ class DataMongoTypeExcludeFilter extends AnnotationCustomizableTypeExcludeFilter ...@@ -44,7 +44,7 @@ class DataMongoTypeExcludeFilter extends AnnotationCustomizableTypeExcludeFilter
} }
@Override @Override
protected Filter[] getFilters(final FilterType type) { protected Filter[] getFilters(FilterType type) {
switch (type) { switch (type) {
case INCLUDE: case INCLUDE:
return this.annotation.includeFilters(); return this.annotation.includeFilters();
......
...@@ -44,7 +44,7 @@ class JooqTypeExcludeFilter extends AnnotationCustomizableTypeExcludeFilter { ...@@ -44,7 +44,7 @@ class JooqTypeExcludeFilter extends AnnotationCustomizableTypeExcludeFilter {
} }
@Override @Override
protected Filter[] getFilters(final FilterType type) { protected Filter[] getFilters(FilterType type) {
switch (type) { switch (type) {
case INCLUDE: case INCLUDE:
return this.annotation.includeFilters(); return this.annotation.includeFilters();
......
...@@ -34,7 +34,7 @@ public class ConfigFileApplicationContextInitializer ...@@ -34,7 +34,7 @@ public class ConfigFileApplicationContextInitializer
implements ApplicationContextInitializer<ConfigurableApplicationContext> { implements ApplicationContextInitializer<ConfigurableApplicationContext> {
@Override @Override
public void initialize(final ConfigurableApplicationContext applicationContext) { public void initialize(ConfigurableApplicationContext applicationContext) {
new ConfigFileApplicationListener() { new ConfigFileApplicationListener() {
public void apply() { public void apply() {
addPropertySources(applicationContext.getEnvironment(), addPropertySources(applicationContext.getEnvironment(),
......
...@@ -365,13 +365,13 @@ public abstract class AbstractJsonMarshalTester<T> { ...@@ -365,13 +365,13 @@ public abstract class AbstractJsonMarshalTester<T> {
this.testerClass = testerClass; this.testerClass = testerClass;
} }
public void initFields(final Object testInstance, final M marshaller) { public void initFields(Object testInstance, M marshaller) {
Assert.notNull(testInstance, "TestInstance must not be null"); Assert.notNull(testInstance, "TestInstance must not be null");
Assert.notNull(marshaller, "Marshaller must not be null"); Assert.notNull(marshaller, "Marshaller must not be null");
initFields(testInstance, () -> marshaller); initFields(testInstance, () -> marshaller);
} }
public void initFields(final Object testInstance, public void initFields(Object testInstance,
final ObjectFactory<M> marshaller) { final ObjectFactory<M> marshaller) {
Assert.notNull(testInstance, "TestInstance must not be null"); Assert.notNull(testInstance, "TestInstance must not be null");
Assert.notNull(marshaller, "Marshaller must not be null"); Assert.notNull(marshaller, "Marshaller must not be null");
......
...@@ -52,7 +52,7 @@ public class OutputCapture implements TestRule { ...@@ -52,7 +52,7 @@ public class OutputCapture implements TestRule {
private List<Matcher<? super String>> matchers = new ArrayList<>(); private List<Matcher<? super String>> matchers = new ArrayList<>();
@Override @Override
public Statement apply(final Statement base, Description description) { public Statement apply(Statement base, Description description) {
return new Statement() { return new Statement() {
@Override @Override
public void evaluate() throws Throwable { public void evaluate() throws Throwable {
......
...@@ -1306,7 +1306,7 @@ public class JsonContentAssertTests { ...@@ -1306,7 +1306,7 @@ public class JsonContentAssertTests {
} }
private AssertProvider<JsonContentAssert> forJson(final String json) { private AssertProvider<JsonContentAssert> forJson(String json) {
return () -> new JsonContentAssert(JsonContentAssertTests.class, json); return () -> new JsonContentAssert(JsonContentAssertTests.class, json);
} }
......
...@@ -72,7 +72,7 @@ public class ObjectContentAssertTests { ...@@ -72,7 +72,7 @@ public class ObjectContentAssertTests {
assertThat(forObject(SOURCE)).asMap(); assertThat(forObject(SOURCE)).asMap();
} }
private AssertProvider<ObjectContentAssert<Object>> forObject(final Object source) { private AssertProvider<ObjectContentAssert<Object>> forObject(Object source) {
return () -> new ObjectContentAssert<>(source); return () -> new ObjectContentAssert<>(source);
} }
......
...@@ -108,7 +108,7 @@ public class JarWriter implements LoaderClassesWriter, AutoCloseable { ...@@ -108,7 +108,7 @@ public class JarWriter implements LoaderClassesWriter, AutoCloseable {
* @param manifest the manifest to write * @param manifest the manifest to write
* @throws IOException of the manifest cannot be written * @throws IOException of the manifest cannot be written
*/ */
public void writeManifest(final Manifest manifest) throws IOException { public void writeManifest(Manifest manifest) throws IOException {
JarArchiveEntry entry = new JarArchiveEntry("META-INF/MANIFEST.MF"); JarArchiveEntry entry = new JarArchiveEntry("META-INF/MANIFEST.MF");
writeEntry(entry, manifest::write); writeEntry(entry, manifest::write);
} }
......
...@@ -37,7 +37,7 @@ public final class SignalUtils { ...@@ -37,7 +37,7 @@ public final class SignalUtils {
* Handle {@literal INT} signals by calling the specified {@link Runnable}. * Handle {@literal INT} signals by calling the specified {@link Runnable}.
* @param runnable the runnable to call on SIGINT. * @param runnable the runnable to call on SIGINT.
*/ */
public static void attachSignalHandler(final Runnable runnable) { public static void attachSignalHandler(Runnable runnable) {
Signal.handle(SIG_INT, (signal) -> runnable.run()); Signal.handle(SIG_INT, (signal) -> runnable.run());
} }
......
...@@ -126,7 +126,7 @@ public class LaunchedURLClassLoader extends URLClassLoader { ...@@ -126,7 +126,7 @@ public class LaunchedURLClassLoader extends URLClassLoader {
} }
} }
private void definePackage(final String className, final String packageName) { private void definePackage(String className, String packageName) {
try { try {
AccessController.doPrivileged((PrivilegedExceptionAction<Object>) () -> { AccessController.doPrivileged((PrivilegedExceptionAction<Object>) () -> {
String packageEntryName = packageName.replace('.', '/') + "/"; String packageEntryName = packageName.replace('.', '/') + "/";
......
...@@ -228,7 +228,7 @@ public class JarFile extends java.util.jar.JarFile { ...@@ -228,7 +228,7 @@ public class JarFile extends java.util.jar.JarFile {
* @return a {@link JarFile} for the entry * @return a {@link JarFile} for the entry
* @throws IOException if the nested jar file cannot be read * @throws IOException if the nested jar file cannot be read
*/ */
public synchronized JarFile getNestedJarFile(final ZipEntry entry) public synchronized JarFile getNestedJarFile(ZipEntry entry)
throws IOException { throws IOException {
return getNestedJarFile((JarEntry) entry); return getNestedJarFile((JarEntry) entry);
} }
......
...@@ -348,7 +348,7 @@ public class PropertiesLauncherTests { ...@@ -348,7 +348,7 @@ public class PropertiesLauncherTests {
assertThat(timeout).as("Timed out waiting for (" + value + ")").isTrue(); assertThat(timeout).as("Timed out waiting for (" + value + ")").isTrue();
} }
private Condition<Archive> endingWith(final String value) { private Condition<Archive> endingWith(String value) {
return new Condition<Archive>() { return new Condition<Archive>() {
@Override @Override
......
...@@ -39,7 +39,7 @@ public final class Matched<T> extends Condition<T> { ...@@ -39,7 +39,7 @@ public final class Matched<T> extends Condition<T> {
} }
@Override @Override
public boolean matches(final T value) { public boolean matches(T value) {
if (this.matcher.matches(value)) { if (this.matcher.matches(value)) {
return true; return true;
} }
......
...@@ -48,7 +48,7 @@ public class OutputCapture implements TestRule { ...@@ -48,7 +48,7 @@ public class OutputCapture implements TestRule {
private List<Matcher<? super String>> matchers = new ArrayList<>(); private List<Matcher<? super String>> matchers = new ArrayList<>();
@Override @Override
public Statement apply(final Statement base, Description description) { public Statement apply(Statement base, Description description) {
return new Statement() { return new Statement() {
@Override @Override
public void evaluate() throws Throwable { public void evaluate() throws Throwable {
......
...@@ -48,7 +48,7 @@ public class RedisTestServer implements TestRule { ...@@ -48,7 +48,7 @@ public class RedisTestServer implements TestRule {
private RedisConnectionFactory connectionFactory; private RedisConnectionFactory connectionFactory;
@Override @Override
public Statement apply(final Statement base, Description description) { public Statement apply(Statement base, Description description) {
try { try {
this.connectionFactory = createConnectionFactory(); this.connectionFactory = createConnectionFactory();
return new RedisStatement(base, this.connectionFactory); return new RedisStatement(base, this.connectionFactory);
......
...@@ -317,7 +317,7 @@ public class ModifiedClassPathRunner extends BlockJUnit4ClassRunner { ...@@ -317,7 +317,7 @@ public class ModifiedClassPathRunner extends BlockJUnit4ClassRunner {
} }
@Override @Override
public Object invokeExplosively(final Object target, final Object... params) public Object invokeExplosively(Object target, Object... params)
throws Throwable { throws Throwable {
return doWithModifiedClassPathThreadContextClassLoader( return doWithModifiedClassPathThreadContextClassLoader(
() -> ModifiedClassPathFrameworkMethod.super.invokeExplosively( () -> ModifiedClassPathFrameworkMethod.super.invokeExplosively(
......
...@@ -99,7 +99,7 @@ class StartupInfoLogger { ...@@ -99,7 +99,7 @@ class StartupInfoLogger {
: "application"); : "application");
} }
private String getVersion(final Class<?> source) { private String getVersion(Class<?> source) {
return getValue(" v", () -> source.getPackage().getImplementationVersion(), ""); return getValue(" v", () -> source.getPackage().getImplementationVersion(), "");
} }
......
...@@ -101,8 +101,8 @@ public class ExitCodeGeneratorsTests { ...@@ -101,8 +101,8 @@ public class ExitCodeGeneratorsTests {
return generator; return generator;
} }
private ExitCodeExceptionMapper mockMapper(final Class<?> exceptionType, private ExitCodeExceptionMapper mockMapper(Class<?> exceptionType,
final int exitCode) { int exitCode) {
return (exception) -> { return (exception) -> {
if (exceptionType.isInstance(exception)) { if (exceptionType.isInstance(exception)) {
return exitCode; return exitCode;
......
...@@ -100,7 +100,7 @@ public class ConfigFileApplicationListenerTests { ...@@ -100,7 +100,7 @@ public class ConfigFileApplicationListenerTests {
public void loadCustomResource() throws Exception { public void loadCustomResource() throws Exception {
this.application.setResourceLoader(new ResourceLoader() { this.application.setResourceLoader(new ResourceLoader() {
@Override @Override
public Resource getResource(final String location) { public Resource getResource(String location) {
if (location.equals("classpath:/custom.properties")) { if (location.equals("classpath:/custom.properties")) {
return new ByteArrayResource("the.property: fromcustom".getBytes(), return new ByteArrayResource("the.property: fromcustom".getBytes(),
location) { location) {
...@@ -885,7 +885,7 @@ public class ConfigFileApplicationListenerTests { ...@@ -885,7 +885,7 @@ public class ConfigFileApplicationListenerTests {
}; };
} }
private Condition<ConfigurableEnvironment> matchingProfile(final String profile) { private Condition<ConfigurableEnvironment> matchingProfile(String profile) {
return new Condition<ConfigurableEnvironment>("accepts profile " + profile) { return new Condition<ConfigurableEnvironment>("accepts profile " + profile) {
@Override @Override
......
...@@ -202,7 +202,7 @@ public class UndertowServletWebServerFactoryTests ...@@ -202,7 +202,7 @@ public class UndertowServletWebServerFactoryTests
} }
@Override @Override
protected void addConnector(final int port, AbstractServletWebServerFactory factory) { protected void addConnector(int port, AbstractServletWebServerFactory factory) {
((UndertowServletWebServerFactory) factory).addBuilderCustomizers( ((UndertowServletWebServerFactory) factory).addBuilderCustomizers(
(builder) -> builder.addHttpListener(port, "0.0.0.0")); (builder) -> builder.addHttpListener(port, "0.0.0.0"));
} }
......
...@@ -35,7 +35,7 @@ public class ChatService { ...@@ -35,7 +35,7 @@ public class ChatService {
private final Logger logger = LoggerFactory.getLogger(ChatService.class); private final Logger logger = LoggerFactory.getLogger(ChatService.class);
@Ready @Ready
public void onReady(final AtmosphereResource resource) { public void onReady(AtmosphereResource resource) {
this.logger.info("Connected", resource.uuid()); this.logger.info("Connected", resource.uuid());
} }
......
...@@ -61,7 +61,7 @@ public class SampleCassandraApplicationTests { ...@@ -61,7 +61,7 @@ public class SampleCassandraApplicationTests {
static class SkipOnWindows implements TestRule { static class SkipOnWindows implements TestRule {
@Override @Override
public Statement apply(final Statement base, Description description) { public Statement apply(Statement base, Description description) {
return new Statement() { return new Statement() {
@Override @Override
......
...@@ -73,7 +73,7 @@ public class SampleElasticsearchApplicationTests { ...@@ -73,7 +73,7 @@ public class SampleElasticsearchApplicationTests {
static class SkipOnWindows implements TestRule { static class SkipOnWindows implements TestRule {
@Override @Override
public Statement apply(final Statement base, Description description) { public Statement apply(Statement base, Description description) {
return new Statement() { return new Statement() {
@Override @Override
......
...@@ -29,7 +29,7 @@ public class SampleFlywayApplication { ...@@ -29,7 +29,7 @@ public class SampleFlywayApplication {
} }
@Bean @Bean
public CommandLineRunner runner(final PersonRepository repository) { public CommandLineRunner runner(PersonRepository repository) {
return new CommandLineRunner() { return new CommandLineRunner() {
@Override @Override
......
...@@ -44,7 +44,7 @@ public class SampleAtomikosApplicationTests { ...@@ -44,7 +44,7 @@ public class SampleAtomikosApplicationTests {
assertThat(output).has(substring(1, "Simulated error")); assertThat(output).has(substring(1, "Simulated error"));
} }
private Condition<String> substring(final int times, final String substring) { private Condition<String> substring(int times, String substring) {
return new Condition<String>( return new Condition<String>(
"containing '" + substring + "' " + times + " times") { "containing '" + substring + "' " + times + " times") {
......
...@@ -60,7 +60,7 @@ public class SampleBitronixApplicationTests { ...@@ -60,7 +60,7 @@ public class SampleBitronixApplicationTests {
.isNotInstanceOf(PoolingConnectionFactory.class); .isNotInstanceOf(PoolingConnectionFactory.class);
} }
private Condition<String> substring(final int times, final String substring) { private Condition<String> substring(int times, String substring) {
return new Condition<String>( return new Condition<String>(
"containing '" + substring + "' " + times + " times") { "containing '" + substring + "' " + times + " times") {
......
...@@ -44,7 +44,7 @@ public class SampleNarayanaApplicationTests { ...@@ -44,7 +44,7 @@ public class SampleNarayanaApplicationTests {
assertThat(output).has(substring(1, "Simulated error")); assertThat(output).has(substring(1, "Simulated error"));
} }
private Condition<String> substring(final int times, final String substring) { private Condition<String> substring(int times, String substring) {
return new Condition<String>( return new Condition<String>(
"containing '" + substring + "' " + times + " times") { "containing '" + substring + "' " + times + " times") {
......
...@@ -61,7 +61,7 @@ public class SampleIntegrationParentApplicationTests { ...@@ -61,7 +61,7 @@ public class SampleIntegrationParentApplicationTests {
awaitOutputContaining("Hello World"); awaitOutputContaining("Hello World");
} }
private void awaitOutputContaining(final String requiredContents) throws Exception { private void awaitOutputContaining(String requiredContents) throws Exception {
long endTime = System.currentTimeMillis() + 30000; long endTime = System.currentTimeMillis() + 30000;
String output = null; String output = null;
while (System.currentTimeMillis() < endTime) { while (System.currentTimeMillis() < endTime) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment