Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
ba52aa36
Commit
ba52aa36
authored
Feb 06, 2018
by
Jon Schneider
Committed by
Andy Wilkinson
Feb 06, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Align with Micrometer's standardized cache metrics
See gh-11918
parent
3b6fe5b9
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
15 additions
and
10 deletions
+15
-10
EhCache2CacheMeterBinderProvider.java
...tuate/metrics/cache/EhCache2CacheMeterBinderProvider.java
+1
-1
HazelcastCacheMeterBinderProvider.java
...uate/metrics/cache/HazelcastCacheMeterBinderProvider.java
+1
-1
JCacheCacheMeterBinderProvider.java
...actuate/metrics/cache/JCacheCacheMeterBinderProvider.java
+1
-1
CacheMetricsRegistrarTests.java
...oot/actuate/metrics/cache/CacheMetricsRegistrarTests.java
+2
-2
HazelcastCacheMeterBinderProviderTests.java
...metrics/cache/HazelcastCacheMeterBinderProviderTests.java
+10
-5
No files found.
spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/cache/EhCache2CacheMeterBinderProvider.java
View file @
ba52aa36
...
...
@@ -34,7 +34,7 @@ public class EhCache2CacheMeterBinderProvider
@Override
public
MeterBinder
getMeterBinder
(
EhCacheCache
cache
,
String
name
,
Iterable
<
Tag
>
tags
)
{
return
new
EhCache2Metrics
(
cache
.
getNativeCache
(),
name
,
tags
);
return
new
EhCache2Metrics
(
cache
.
getNativeCache
(),
tags
);
}
}
spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/cache/HazelcastCacheMeterBinderProvider.java
View file @
ba52aa36
...
...
@@ -36,7 +36,7 @@ public class HazelcastCacheMeterBinderProvider
public
MeterBinder
getMeterBinder
(
HazelcastCache
cache
,
String
name
,
Iterable
<
Tag
>
tags
)
{
return
new
HazelcastCacheMetrics
((
IMap
<
Object
,
Object
>)
cache
.
getNativeCache
(),
name
,
tags
);
tags
);
}
}
spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/metrics/cache/JCacheCacheMeterBinderProvider.java
View file @
ba52aa36
...
...
@@ -34,7 +34,7 @@ public class JCacheCacheMeterBinderProvider
@Override
public
MeterBinder
getMeterBinder
(
JCacheCache
cache
,
String
name
,
Iterable
<
Tag
>
tags
)
{
return
new
JCacheMetrics
(
cache
.
getNativeCache
(),
name
,
tags
);
return
new
JCacheMetrics
(
cache
.
getNativeCache
(),
tags
);
}
}
spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/cache/CacheMetricsRegistrarTests.java
View file @
ba52aa36
...
...
@@ -42,7 +42,7 @@ public class CacheMetricsRegistrarTests {
"root"
,
Collections
.
singleton
(
new
CaffeineCacheMeterBinderProvider
()));
assertThat
(
registrar
.
bindCacheToRegistry
(
new
CaffeineCache
(
"test"
,
Caffeine
.
newBuilder
().
build
()))).
isTrue
();
assertThat
(
this
.
meterRegistry
.
get
(
"
root.reques
ts"
).
tags
(
"name"
,
"test"
).
meter
())
assertThat
(
this
.
meterRegistry
.
get
(
"
cache.ge
ts"
).
tags
(
"name"
,
"test"
).
meter
())
.
isNotNull
();
}
...
...
@@ -52,7 +52,7 @@ public class CacheMetricsRegistrarTests {
"root"
,
Collections
.
emptyList
());
assertThat
(
registrar
.
bindCacheToRegistry
(
new
CaffeineCache
(
"test"
,
Caffeine
.
newBuilder
().
build
()))).
isFalse
();
assertThat
(
this
.
meterRegistry
.
find
(
"
root.reques
ts"
).
tags
(
"name"
,
"test"
).
meter
())
assertThat
(
this
.
meterRegistry
.
find
(
"
cache.ge
ts"
).
tags
(
"name"
,
"test"
).
meter
())
.
isNull
();
}
...
...
spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/metrics/cache/HazelcastCacheMeterBinderProviderTests.java
View file @
ba52aa36
...
...
@@ -24,7 +24,7 @@ import io.micrometer.core.instrument.binder.MeterBinder;
import
io.micrometer.core.instrument.binder.cache.HazelcastCacheMetrics
;
import
org.junit.Test
;
import
org.junit.runner.RunWith
;
import
org.mockito.Mock
;
import
org.mockito.Mock
ito
;
import
org.mockito.junit.MockitoJUnitRunner
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
...
@@ -37,12 +37,17 @@ import static org.assertj.core.api.Assertions.assertThat;
@RunWith
(
MockitoJUnitRunner
.
class
)
public
class
HazelcastCacheMeterBinderProviderTests
{
@Mock
private
IMap
<
Object
,
Object
>
nativeCache
;
@SuppressWarnings
(
"unchecked"
)
@Test
public
void
hazelcastCacheProvider
()
{
HazelcastCache
cache
=
new
HazelcastCache
(
this
.
nativeCache
);
IMap
<
Object
,
Object
>
nativeCache
=
Mockito
.
mock
(
IMap
.
class
);
// It is not possible to create a real Hazelcast cache with a null name,
// so Micrometer's Hazelcast binder uses the name from the cache for its tag value.
Mockito
.
when
(
nativeCache
.
getName
()).
thenReturn
(
"test"
);
HazelcastCache
cache
=
new
HazelcastCache
(
nativeCache
);
MeterBinder
meterBinder
=
new
HazelcastCacheMeterBinderProvider
()
.
getMeterBinder
(
cache
,
"test"
,
Collections
.
emptyList
());
assertThat
(
meterBinder
).
isInstanceOf
(
HazelcastCacheMetrics
.
class
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment