Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
bd64e052
Commit
bd64e052
authored
Feb 11, 2021
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Instrument AMQP AbstractCF when defined as a ConnectionFactory
Fixes gh-25138
parent
82dc2dff
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
26 additions
and
3 deletions
+26
-3
RabbitMetricsAutoConfiguration.java
...onfigure/metrics/amqp/RabbitMetricsAutoConfiguration.java
+2
-2
RabbitMetricsAutoConfigurationTests.java
...ure/metrics/amqp/RabbitMetricsAutoConfigurationTests.java
+24
-1
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/amqp/RabbitMetricsAutoConfiguration.java
View file @
bd64e052
/*
* Copyright 2012-20
19
the original author or authors.
* Copyright 2012-20
21
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -42,7 +42,7 @@ import org.springframework.context.annotation.Configuration;
@AutoConfigureAfter
({
MetricsAutoConfiguration
.
class
,
RabbitAutoConfiguration
.
class
,
SimpleMetricsExportAutoConfiguration
.
class
})
@ConditionalOnClass
({
ConnectionFactory
.
class
,
AbstractConnectionFactory
.
class
})
@ConditionalOnBean
({
Abstract
ConnectionFactory
.
class
,
MeterRegistry
.
class
})
@ConditionalOnBean
({
org
.
springframework
.
amqp
.
rabbit
.
connection
.
ConnectionFactory
.
class
,
MeterRegistry
.
class
})
public
class
RabbitMetricsAutoConfiguration
{
@Bean
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/amqp/RabbitMetricsAutoConfigurationTests.java
View file @
bd64e052
/*
* Copyright 2012-20
19
the original author or authors.
* Copyright 2012-20
21
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -19,10 +19,14 @@ package org.springframework.boot.actuate.autoconfigure.metrics.amqp;
import
io.micrometer.core.instrument.MeterRegistry
;
import
org.junit.jupiter.api.Test
;
import
org.springframework.amqp.rabbit.connection.CachingConnectionFactory
;
import
org.springframework.amqp.rabbit.connection.ConnectionFactory
;
import
org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.amqp.RabbitAutoConfiguration
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
...
@@ -45,6 +49,15 @@ class RabbitMetricsAutoConfigurationTests {
});
}
@Test
void
abstractConnectionFactoryDefinedAsAConnectionFactoryIsInstrumented
()
{
this
.
contextRunner
.
withUserConfiguration
(
ConnectionFactoryConfiguration
.
class
).
run
((
context
)
->
{
assertThat
(
context
).
hasBean
(
"customConnectionFactory"
);
MeterRegistry
registry
=
context
.
getBean
(
MeterRegistry
.
class
);
registry
.
get
(
"rabbitmq.connections"
).
meter
();
});
}
@Test
void
rabbitmqNativeConnectionFactoryInstrumentationCanBeDisabled
()
{
this
.
contextRunner
.
withPropertyValues
(
"management.metrics.enable.rabbitmq=false"
).
run
((
context
)
->
{
...
...
@@ -53,4 +66,14 @@ class RabbitMetricsAutoConfigurationTests {
});
}
@Configuration
static
class
ConnectionFactoryConfiguration
{
@Bean
ConnectionFactory
customConnectionFactory
()
{
return
new
CachingConnectionFactory
();
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment