Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
bde2f850
Commit
bde2f850
authored
Mar 07, 2019
by
Mohamed Rifni
Committed by
Stephane Nicoll
Mar 12, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Trim trailing whitespace from spring.server.servlet.context-path
See gh-16165
parent
347daf69
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
34 additions
and
2 deletions
+34
-2
ServerProperties.java
...ingframework/boot/autoconfigure/web/ServerProperties.java
+8
-2
ServerPropertiesTests.java
...amework/boot/autoconfigure/web/ServerPropertiesTests.java
+26
-0
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java
View file @
bde2f850
...
@@ -231,8 +231,14 @@ public class ServerProperties {
...
@@ -231,8 +231,14 @@ public class ServerProperties {
}
}
private
String
cleanContextPath
(
String
contextPath
)
{
private
String
cleanContextPath
(
String
contextPath
)
{
if
(
StringUtils
.
hasText
(
contextPath
)
&&
contextPath
.
endsWith
(
"/"
))
{
if
(
StringUtils
.
hasLength
(
contextPath
))
{
return
contextPath
.
substring
(
0
,
contextPath
.
length
()
-
1
);
// remove leading and trailing whitespaces if any exists
String
ctxPath
=
StringUtils
.
trimWhitespace
(
contextPath
);
if
(
ctxPath
.
endsWith
(
"/"
))
{
ctxPath
=
ctxPath
.
substring
(
0
,
ctxPath
.
length
()
-
1
);
}
return
ctxPath
;
}
}
return
contextPath
;
return
contextPath
;
}
}
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java
View file @
bde2f850
...
@@ -149,6 +149,32 @@ public class ServerPropertiesTests {
...
@@ -149,6 +149,32 @@ public class ServerPropertiesTests {
assertThat
(
this
.
properties
.
getServlet
().
getContextPath
()).
isEqualTo
(
""
);
assertThat
(
this
.
properties
.
getServlet
().
getContextPath
()).
isEqualTo
(
""
);
}
}
@Test
public
void
makeSureTrailingAndLeadingWhitespacesRemoved_case1
()
{
bind
(
"server.servlet.context-path"
,
" /assets"
);
assertThat
(
this
.
properties
.
getServlet
().
getContextPath
()).
isEqualTo
(
"/assets"
);
}
@Test
public
void
makeSureTrailingAndLeadingWhitespacesRemoved_case2
()
{
bind
(
"server.servlet.context-path"
,
" /assets "
);
assertThat
(
this
.
properties
.
getServlet
().
getContextPath
()).
isEqualTo
(
"/assets"
);
}
@Test
public
void
makeSureTrailingAndLeadingWhitespacesRemoved_case3
()
{
bind
(
"server.servlet.context-path"
,
"/assets/copy/ "
);
assertThat
(
this
.
properties
.
getServlet
().
getContextPath
())
.
isEqualTo
(
"/assets/copy"
);
}
@Test
public
void
makeSureTrailingAndLeadingWhitespacesRemoved_case4
()
{
bind
(
"server.servlet.context-path"
,
" /assets /copy/ "
);
assertThat
(
this
.
properties
.
getServlet
().
getContextPath
())
.
isEqualTo
(
"/assets /copy"
);
}
@Test
@Test
public
void
testCustomizeUriEncoding
()
{
public
void
testCustomizeUriEncoding
()
{
bind
(
"server.tomcat.uri-encoding"
,
"US-ASCII"
);
bind
(
"server.tomcat.uri-encoding"
,
"US-ASCII"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment