Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
c219f5e5
Commit
c219f5e5
authored
Nov 12, 2015
by
Eddú Meléndez
Committed by
Andy Wilkinson
Jan 15, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't create ApplicationContextHeaderFilter when header is disabled
See gh-4320 Closes gh-4454
parent
b02cdc72
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
0 deletions
+6
-0
EndpointWebMvcAutoConfiguration.java
...ctuate/autoconfigure/EndpointWebMvcAutoConfiguration.java
+3
-0
EndpointWebMvcAutoConfigurationTests.java
...e/autoconfigure/EndpointWebMvcAutoConfigurationTests.java
+3
-0
No files found.
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcAutoConfiguration.java
View file @
c219f5e5
...
@@ -42,6 +42,7 @@ import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
...
@@ -42,6 +42,7 @@ import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
import
org.springframework.boot.autoconfigure.PropertyPlaceholderAutoConfiguration
;
import
org.springframework.boot.autoconfigure.PropertyPlaceholderAutoConfiguration
;
import
org.springframework.boot.autoconfigure.condition.ConditionOutcome
;
import
org.springframework.boot.autoconfigure.condition.ConditionOutcome
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnClass
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnClass
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnProperty
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication
;
import
org.springframework.boot.autoconfigure.condition.SpringBootCondition
;
import
org.springframework.boot.autoconfigure.condition.SpringBootCondition
;
import
org.springframework.boot.autoconfigure.data.rest.RepositoryRestMvcAutoConfiguration
;
import
org.springframework.boot.autoconfigure.data.rest.RepositoryRestMvcAutoConfiguration
;
...
@@ -87,6 +88,7 @@ import org.springframework.web.servlet.DispatcherServlet;
...
@@ -87,6 +88,7 @@ import org.springframework.web.servlet.DispatcherServlet;
* @author Christian Dupuis
* @author Christian Dupuis
* @author Andy Wilkinson
* @author Andy Wilkinson
* @author Johannes Edmeier
* @author Johannes Edmeier
* @author Eddú Meléndez
*/
*/
@Configuration
@Configuration
@ConditionalOnClass
({
Servlet
.
class
,
DispatcherServlet
.
class
})
@ConditionalOnClass
({
Servlet
.
class
,
DispatcherServlet
.
class
})
...
@@ -198,6 +200,7 @@ public class EndpointWebMvcAutoConfiguration
...
@@ -198,6 +200,7 @@ public class EndpointWebMvcAutoConfiguration
// Put Servlets and Filters in their own nested class so they don't force early
// Put Servlets and Filters in their own nested class so they don't force early
// instantiation of ManagementServerProperties.
// instantiation of ManagementServerProperties.
@Configuration
@Configuration
@ConditionalOnProperty
(
prefix
=
"management"
,
name
=
"addApplicationContextHeader"
,
matchIfMissing
=
true
,
havingValue
=
"true"
)
protected
static
class
ApplicationContextFilterConfiguration
{
protected
static
class
ApplicationContextFilterConfiguration
{
@Bean
@Bean
...
...
spring-boot-actuator/src/test/java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcAutoConfigurationTests.java
View file @
c219f5e5
...
@@ -98,6 +98,7 @@ import static org.mockito.Mockito.mock;
...
@@ -98,6 +98,7 @@ import static org.mockito.Mockito.mock;
* @author Phillip Webb
* @author Phillip Webb
* @author Greg Turnquist
* @author Greg Turnquist
* @author Andy Wilkinson
* @author Andy Wilkinson
* @author Eddú Meléndez
*/
*/
public
class
EndpointWebMvcAutoConfigurationTests
{
public
class
EndpointWebMvcAutoConfigurationTests
{
...
@@ -136,6 +137,7 @@ public class EndpointWebMvcAutoConfigurationTests {
...
@@ -136,6 +137,7 @@ public class EndpointWebMvcAutoConfigurationTests {
assertContent
(
"/controller"
,
ports
.
get
().
management
,
null
);
assertContent
(
"/controller"
,
ports
.
get
().
management
,
null
);
assertContent
(
"/endpoint"
,
ports
.
get
().
management
,
null
);
assertContent
(
"/endpoint"
,
ports
.
get
().
management
,
null
);
assertTrue
(
hasHeader
(
"/endpoint"
,
ports
.
get
().
server
,
"X-Application-Context"
));
assertTrue
(
hasHeader
(
"/endpoint"
,
ports
.
get
().
server
,
"X-Application-Context"
));
assertTrue
(
this
.
applicationContext
.
containsBean
(
"applicationContextIdFilter"
));
this
.
applicationContext
.
close
();
this
.
applicationContext
.
close
();
assertAllClosed
();
assertAllClosed
();
}
}
...
@@ -149,6 +151,7 @@ public class EndpointWebMvcAutoConfigurationTests {
...
@@ -149,6 +151,7 @@ public class EndpointWebMvcAutoConfigurationTests {
EndpointWebMvcAutoConfiguration
.
class
);
EndpointWebMvcAutoConfiguration
.
class
);
this
.
applicationContext
.
refresh
();
this
.
applicationContext
.
refresh
();
assertFalse
(
hasHeader
(
"/endpoint"
,
ports
.
get
().
server
,
"X-Application-Context"
));
assertFalse
(
hasHeader
(
"/endpoint"
,
ports
.
get
().
server
,
"X-Application-Context"
));
assertFalse
(
this
.
applicationContext
.
containsBean
(
"applicationContextIdFilter"
));
this
.
applicationContext
.
close
();
this
.
applicationContext
.
close
();
assertAllClosed
();
assertAllClosed
();
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment