Commit c4e1b4f5 authored by Stephane Nicoll's avatar Stephane Nicoll

Polish "Add configuration option for channelRpcTimeout"

See gh-23564
parent baa9d129
...@@ -119,11 +119,11 @@ public class RabbitProperties { ...@@ -119,11 +119,11 @@ public class RabbitProperties {
* Connection timeout. Set it to zero to wait forever. * Connection timeout. Set it to zero to wait forever.
*/ */
private Duration connectionTimeout; private Duration connectionTimeout;
/** /**
* Channel RPC timeout. * Continuation timeout for RPC calls in channels. Set it to zero to wait forever.
*/ */
private Duration channelRpcTimeout; private Duration channelRpcTimeout = Duration.ofMinutes(10);
/** /**
* Cache configuration. * Cache configuration.
...@@ -328,10 +328,6 @@ public class RabbitProperties { ...@@ -328,10 +328,6 @@ public class RabbitProperties {
public Duration getConnectionTimeout() { public Duration getConnectionTimeout() {
return this.connectionTimeout; return this.connectionTimeout;
} }
public Duration getChannelRpcTimeout() {
return this.channelRpcTimeout;
}
public void setPublisherConfirmType(ConfirmType publisherConfirmType) { public void setPublisherConfirmType(ConfirmType publisherConfirmType) {
this.publisherConfirmType = publisherConfirmType; this.publisherConfirmType = publisherConfirmType;
...@@ -344,7 +340,11 @@ public class RabbitProperties { ...@@ -344,7 +340,11 @@ public class RabbitProperties {
public void setConnectionTimeout(Duration connectionTimeout) { public void setConnectionTimeout(Duration connectionTimeout) {
this.connectionTimeout = connectionTimeout; this.connectionTimeout = connectionTimeout;
} }
public Duration getChannelRpcTimeout() {
return this.channelRpcTimeout;
}
public void setChannelRpcTimeout(Duration channelRpcTimeout) { public void setChannelRpcTimeout(Duration channelRpcTimeout) {
this.channelRpcTimeout = channelRpcTimeout; this.channelRpcTimeout = channelRpcTimeout;
} }
......
...@@ -108,6 +108,8 @@ class RabbitAutoConfigurationTests { ...@@ -108,6 +108,8 @@ class RabbitAutoConfigurationTests {
.isEqualTo(com.rabbitmq.client.ConnectionFactory.DEFAULT_CHANNEL_MAX); .isEqualTo(com.rabbitmq.client.ConnectionFactory.DEFAULT_CHANNEL_MAX);
assertThat(connectionFactory.isPublisherConfirms()).isFalse(); assertThat(connectionFactory.isPublisherConfirms()).isFalse();
assertThat(connectionFactory.isPublisherReturns()).isFalse(); assertThat(connectionFactory.isPublisherReturns()).isFalse();
assertThat(connectionFactory.getRabbitConnectionFactory().getChannelRpcTimeout())
.isEqualTo(com.rabbitmq.client.ConnectionFactory.DEFAULT_CHANNEL_RPC_TIMEOUT);
assertThat(context.containsBean("rabbitListenerContainerFactory")) assertThat(context.containsBean("rabbitListenerContainerFactory"))
.as("Listener container factory should be created by default").isTrue(); .as("Listener container factory should be created by default").isTrue();
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment