Commit c748f368 authored by Lars Grefer's avatar Lars Grefer Committed by Andy Wilkinson

Fix recommended task dependency configuration

`compileJava.dependsOn(processResources)` is not enough to ensure the
correct behavior. Using `dependsOn` only affects the execution order
(`processResources` before `compileJava`) but not the up-to-date check
of `compileJava`. After modifying
`META-INF/additional-spring-configuration-metadata.json`, the
`processResouces` task will considered out-of-date and will be
re-executed, but after that `compileJava` will still be considered
up-to-date which causes the changes not to be merged into
`META-INF/spring-configuration-metadata.json`

With this change the up-do-date check of `compileJava` is affected,
too. Therefore, it will correctly re-execute the
configuration-processor when
`META-INF/additional-spring-configuration-metadata.json` was changed.

See gh-20323
parent 4b82d7d9
...@@ -730,7 +730,7 @@ If you are using an `additional-spring-configuration-metadata.json` file, the `c ...@@ -730,7 +730,7 @@ If you are using an `additional-spring-configuration-metadata.json` file, the `c
[source,groovy,indent=0,subs="verbatim,quotes,attributes"] [source,groovy,indent=0,subs="verbatim,quotes,attributes"]
---- ----
compileJava.dependsOn(processResources) compileJava.inputs.files(processResources)
---- ----
This dependency ensures that the additional metadata is available when the annotation processor runs during compilation. This dependency ensures that the additional metadata is available when the annotation processor runs during compilation.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment