Commit c74badd4 authored by Brian Clozel's avatar Brian Clozel

Auto-configure Elasticsearch REST client in Spring Data

This commit auto-configures the Elasticsearch REST client support
as a template for Spring Data Elasticsearch. As of this commit,
using the transport client is still possible but developers
should migrate.

This commit also removes the deprecated annotation on the
Elasticsearch auto-configuration for the transport client, since
this deprecation notice is already present on the configuration
property.

Closes gh-17024
Closes gh-16542
parent ae5b5be5
...@@ -37,14 +37,12 @@ import org.springframework.data.elasticsearch.client.TransportClientFactoryBean; ...@@ -37,14 +37,12 @@ import org.springframework.data.elasticsearch.client.TransportClientFactoryBean;
* @author Mohsin Husen * @author Mohsin Husen
* @author Andy Wilkinson * @author Andy Wilkinson
* @since 1.1.0 * @since 1.1.0
* @deprecated since 2.2.0 in favor of other auto-configured Elasticsearch clients
*/ */
@Configuration(proxyBeanMethods = false) @Configuration(proxyBeanMethods = false)
@ConditionalOnClass({ Client.class, TransportClientFactoryBean.class }) @ConditionalOnClass({ Client.class, TransportClientFactoryBean.class })
@ConditionalOnProperty(prefix = "spring.data.elasticsearch", name = "cluster-nodes", @ConditionalOnProperty(prefix = "spring.data.elasticsearch", name = "cluster-nodes",
matchIfMissing = false) matchIfMissing = false)
@EnableConfigurationProperties(ElasticsearchProperties.class) @EnableConfigurationProperties(ElasticsearchProperties.class)
@Deprecated
public class ElasticsearchAutoConfiguration { public class ElasticsearchAutoConfiguration {
private final ElasticsearchProperties properties; private final ElasticsearchProperties properties;
......
...@@ -16,19 +16,13 @@ ...@@ -16,19 +16,13 @@
package org.springframework.boot.autoconfigure.data.elasticsearch; package org.springframework.boot.autoconfigure.data.elasticsearch;
import org.elasticsearch.client.Client;
import org.springframework.boot.autoconfigure.AutoConfigureAfter; import org.springframework.boot.autoconfigure.AutoConfigureAfter;
import org.springframework.boot.autoconfigure.EnableAutoConfiguration; import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass; import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean; import org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Import;
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate; import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
import org.springframework.data.elasticsearch.core.convert.ElasticsearchConverter;
import org.springframework.data.elasticsearch.core.convert.MappingElasticsearchConverter;
import org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchMappingContext;
import org.springframework.data.elasticsearch.repository.config.EnableElasticsearchRepositories; import org.springframework.data.elasticsearch.repository.config.EnableElasticsearchRepositories;
/** /**
...@@ -38,41 +32,19 @@ import org.springframework.data.elasticsearch.repository.config.EnableElasticsea ...@@ -38,41 +32,19 @@ import org.springframework.data.elasticsearch.repository.config.EnableElasticsea
* Registers an {@link ElasticsearchTemplate} if no other bean of the same type is * Registers an {@link ElasticsearchTemplate} if no other bean of the same type is
* configured. * configured.
* *
* @author Brian Clozel
* @author Artur Konczak * @author Artur Konczak
* @author Mohsin Husen * @author Mohsin Husen
* @see EnableElasticsearchRepositories * @see EnableElasticsearchRepositories
* @since 1.1.0 * @since 1.1.0
*/ */
@Configuration(proxyBeanMethods = false) @Configuration(proxyBeanMethods = false)
@ConditionalOnClass({ Client.class, ElasticsearchTemplate.class }) @ConditionalOnClass({ ElasticsearchTemplate.class })
@AutoConfigureAfter(ElasticsearchAutoConfiguration.class) @AutoConfigureAfter({ ElasticsearchAutoConfiguration.class,
@SuppressWarnings("deprecation") RestClientAutoConfiguration.class })
@Import({ ElasticsearchDataConfiguration.BaseConfiguration.class,
ElasticsearchDataConfiguration.TransportClientConfiguration.class,
ElasticsearchDataConfiguration.RestHighLevelClientConfiguration.class })
public class ElasticsearchDataAutoConfiguration { public class ElasticsearchDataAutoConfiguration {
@Bean
@ConditionalOnMissingBean
@ConditionalOnBean(Client.class)
public ElasticsearchTemplate elasticsearchTemplate(Client client,
ElasticsearchConverter converter) {
try {
return new ElasticsearchTemplate(client, converter);
}
catch (Exception ex) {
throw new IllegalStateException(ex);
}
}
@Bean
@ConditionalOnMissingBean
public ElasticsearchConverter elasticsearchConverter(
SimpleElasticsearchMappingContext mappingContext) {
return new MappingElasticsearchConverter(mappingContext);
}
@Bean
@ConditionalOnMissingBean
public SimpleElasticsearchMappingContext mappingContext() {
return new SimpleElasticsearchMappingContext();
}
} }
/*
* Copyright 2012-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.boot.autoconfigure.data.elasticsearch;
import org.elasticsearch.client.Client;
import org.elasticsearch.client.RestHighLevelClient;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.data.elasticsearch.core.ElasticsearchOperations;
import org.springframework.data.elasticsearch.core.ElasticsearchRestTemplate;
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
import org.springframework.data.elasticsearch.core.convert.ElasticsearchConverter;
import org.springframework.data.elasticsearch.core.convert.MappingElasticsearchConverter;
import org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchMappingContext;
/**
* Configuration classes for Spring Data for Elasticsearch
* <p>
* Those should be {@code @Import} in a regular auto-configuration class to guarantee
* their order of execution.
*
* @author Brian Clozel
*/
abstract class ElasticsearchDataConfiguration {
@Configuration(proxyBeanMethods = false)
static class BaseConfiguration {
@Bean
@ConditionalOnMissingBean
public ElasticsearchConverter elasticsearchConverter(
SimpleElasticsearchMappingContext mappingContext) {
return new MappingElasticsearchConverter(mappingContext);
}
@Bean
@ConditionalOnMissingBean
public SimpleElasticsearchMappingContext mappingContext() {
return new SimpleElasticsearchMappingContext();
}
}
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(RestHighLevelClient.class)
static class RestHighLevelClientConfiguration {
@Bean
@ConditionalOnMissingBean(value = ElasticsearchOperations.class,
name = "elasticsearchTemplate")
@ConditionalOnBean(RestHighLevelClient.class)
public ElasticsearchRestTemplate elasticsearchTemplate(RestHighLevelClient client,
ElasticsearchConverter converter) {
return new ElasticsearchRestTemplate(client, converter);
}
}
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(Client.class)
static class TransportClientConfiguration {
@Bean
@ConditionalOnMissingBean(value = ElasticsearchOperations.class,
name = "elasticsearchTemplate")
@ConditionalOnBean(Client.class)
public ElasticsearchTemplate elasticsearchTemplate(Client client,
ElasticsearchConverter converter) {
try {
return new ElasticsearchTemplate(client, converter);
}
catch (Exception ex) {
throw new IllegalStateException(ex);
}
}
}
}
...@@ -16,97 +16,102 @@ ...@@ -16,97 +16,102 @@
package org.springframework.boot.autoconfigure.data.elasticsearch; package org.springframework.boot.autoconfigure.data.elasticsearch;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.testcontainers.junit.jupiter.Container; import org.testcontainers.junit.jupiter.Container;
import org.testcontainers.junit.jupiter.Testcontainers; import org.testcontainers.junit.jupiter.Testcontainers;
import org.springframework.boot.autoconfigure.context.PropertyPlaceholderAutoConfiguration; import org.springframework.boot.autoconfigure.AutoConfigurations;
import org.springframework.boot.test.util.TestPropertyValues; import org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration;
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
import org.springframework.boot.testsupport.testcontainers.ElasticsearchContainer; import org.springframework.boot.testsupport.testcontainers.ElasticsearchContainer;
import org.springframework.context.annotation.AnnotationConfigApplicationContext; import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.data.elasticsearch.core.ElasticsearchRestTemplate;
import org.springframework.data.elasticsearch.core.ElasticsearchTemplate; import org.springframework.data.elasticsearch.core.ElasticsearchTemplate;
import org.springframework.data.elasticsearch.core.convert.ElasticsearchConverter; import org.springframework.data.elasticsearch.core.convert.ElasticsearchConverter;
import org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchMappingContext; import org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchMappingContext;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
/** /**
* Tests for {@link ElasticsearchDataAutoConfiguration}. * Tests for {@link ElasticsearchDataAutoConfiguration}.
* *
* @author Phillip Webb * @author Phillip Webb
* @author Artur Konczak * @author Artur Konczak
* @author Brian Clozel
*/ */
@SuppressWarnings("deprecation")
@Testcontainers @Testcontainers
public class ElasticsearchDataAutoConfigurationTests { public class ElasticsearchDataAutoConfigurationTests {
@Container @Container
public static ElasticsearchContainer elasticsearch = new ElasticsearchContainer(); public static ElasticsearchContainer elasticsearch = new ElasticsearchContainer();
private AnnotationConfigApplicationContext context; private ApplicationContextRunner contextRunner = new ApplicationContextRunner()
.withConfiguration(AutoConfigurations.of(ElasticsearchAutoConfiguration.class,
RestClientAutoConfiguration.class,
ElasticsearchDataAutoConfiguration.class));
@AfterEach @Test
public void close() { public void defaultTransportBeansAreRegistered() {
if (this.context != null) { this.contextRunner
this.context.close(); .withPropertyValues(
} "spring.data.elasticsearch.cluster-nodes:localhost:"
+ elasticsearch.getMappedTransportPort(),
"spring.data.elasticsearch.cluster-name:docker-cluster")
.run((context) -> assertThat(context)
.hasSingleBean(ElasticsearchTemplate.class)
.hasSingleBean(SimpleElasticsearchMappingContext.class)
.hasSingleBean(ElasticsearchConverter.class));
} }
@Test @Test
public void templateBackOffWithNoClient() { public void defaultTransportBeansNotRegisteredIfNoTransportClient() {
this.context = new AnnotationConfigApplicationContext( this.contextRunner.run((context) -> assertThat(context)
ElasticsearchDataAutoConfiguration.class); .doesNotHaveBean(ElasticsearchTemplate.class));
assertThat(this.context.getBeansOfType(ElasticsearchTemplate.class)).isEmpty();
} }
@Test @Test
public void templateExists() { public void defaultRestBeansRegistered() {
this.context = new AnnotationConfigApplicationContext(); this.contextRunner.run((context) -> assertThat(context)
TestPropertyValues .hasSingleBean(ElasticsearchRestTemplate.class)
.of("spring.data.elasticsearch.cluster-nodes:localhost:" .hasSingleBean(ElasticsearchConverter.class));
+ elasticsearch.getMappedTransportPort(),
"spring.data.elasticsearch.cluster-name:docker-cluster")
.applyTo(this.context);
this.context.register(PropertyPlaceholderAutoConfiguration.class,
ElasticsearchAutoConfiguration.class,
ElasticsearchDataAutoConfiguration.class);
this.context.refresh();
assertHasSingleBean(ElasticsearchTemplate.class);
} }
@Test @Test
public void mappingContextExists() { public void customTransportTemplateShouldBeUsed() {
this.context = new AnnotationConfigApplicationContext(); this.contextRunner.withUserConfiguration(CustomTransportTemplate.class)
TestPropertyValues .run((context) -> assertThat(context)
.of("spring.data.elasticsearch.cluster-nodes:localhost:" .getBeanNames(ElasticsearchTemplate.class).hasSize(1)
+ elasticsearch.getMappedTransportPort(), .contains("elasticsearchTemplate"));
"spring.data.elasticsearch.cluster-name:docker-cluster")
.applyTo(this.context);
this.context.register(PropertyPlaceholderAutoConfiguration.class,
ElasticsearchAutoConfiguration.class,
ElasticsearchDataAutoConfiguration.class);
this.context.refresh();
assertHasSingleBean(SimpleElasticsearchMappingContext.class);
} }
@Test @Test
public void converterExists() { public void customRestTemplateShouldBeUsed() {
this.context = new AnnotationConfigApplicationContext(); this.contextRunner.withUserConfiguration(CustomRestTemplate.class)
TestPropertyValues .run((context) -> assertThat(context)
.of("spring.data.elasticsearch.cluster-nodes:localhost:" .getBeanNames(ElasticsearchRestTemplate.class).hasSize(1)
+ elasticsearch.getMappedTransportPort(), .contains("elasticsearchTemplate"));
"spring.data.elasticsearch.cluster-name:docker-cluster") }
.applyTo(this.context);
this.context.register(PropertyPlaceholderAutoConfiguration.class, @Configuration
ElasticsearchAutoConfiguration.class, static class CustomTransportTemplate {
ElasticsearchDataAutoConfiguration.class);
this.context.refresh(); @Bean
assertHasSingleBean(ElasticsearchConverter.class); ElasticsearchTemplate elasticsearchTemplate() {
return mock(ElasticsearchTemplate.class);
}
} }
private void assertHasSingleBean(Class<?> type) { @Configuration
assertThat(this.context.getBeanNamesForType(type)).hasSize(1); static class CustomRestTemplate {
@Bean
ElasticsearchRestTemplate elasticsearchTemplate() {
return mock(ElasticsearchRestTemplate.class);
}
} }
} }
...@@ -16,22 +16,21 @@ ...@@ -16,22 +16,21 @@
package org.springframework.boot.autoconfigure.data.elasticsearch; package org.springframework.boot.autoconfigure.data.elasticsearch;
import org.elasticsearch.client.Client;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.testcontainers.junit.jupiter.Container; import org.testcontainers.junit.jupiter.Container;
import org.testcontainers.junit.jupiter.Testcontainers; import org.testcontainers.junit.jupiter.Testcontainers;
import org.springframework.boot.autoconfigure.AutoConfigurations;
import org.springframework.boot.autoconfigure.TestAutoConfigurationPackage; import org.springframework.boot.autoconfigure.TestAutoConfigurationPackage;
import org.springframework.boot.autoconfigure.context.PropertyPlaceholderAutoConfiguration;
import org.springframework.boot.autoconfigure.data.alt.elasticsearch.CityElasticsearchDbRepository; import org.springframework.boot.autoconfigure.data.alt.elasticsearch.CityElasticsearchDbRepository;
import org.springframework.boot.autoconfigure.data.elasticsearch.city.City; import org.springframework.boot.autoconfigure.data.elasticsearch.city.City;
import org.springframework.boot.autoconfigure.data.elasticsearch.city.CityRepository; import org.springframework.boot.autoconfigure.data.elasticsearch.city.CityRepository;
import org.springframework.boot.autoconfigure.data.empty.EmptyDataPackage; import org.springframework.boot.autoconfigure.data.empty.EmptyDataPackage;
import org.springframework.boot.test.util.TestPropertyValues; import org.springframework.boot.autoconfigure.elasticsearch.rest.RestClientAutoConfiguration;
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
import org.springframework.boot.testsupport.testcontainers.ElasticsearchContainer; import org.springframework.boot.testsupport.testcontainers.ElasticsearchContainer;
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import org.springframework.data.elasticsearch.core.ElasticsearchRestTemplate;
import org.springframework.data.elasticsearch.repository.config.EnableElasticsearchRepositories; import org.springframework.data.elasticsearch.repository.config.EnableElasticsearchRepositories;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
...@@ -41,6 +40,7 @@ import static org.assertj.core.api.Assertions.assertThat; ...@@ -41,6 +40,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* *
* @author Phillip Webb * @author Phillip Webb
* @author Andy Wilkinson * @author Andy Wilkinson
* @author Brian Clozel
*/ */
@Testcontainers @Testcontainers
public class ElasticsearchRepositoriesAutoConfigurationTests { public class ElasticsearchRepositoriesAutoConfigurationTests {
...@@ -48,59 +48,44 @@ public class ElasticsearchRepositoriesAutoConfigurationTests { ...@@ -48,59 +48,44 @@ public class ElasticsearchRepositoriesAutoConfigurationTests {
@Container @Container
public static ElasticsearchContainer elasticsearch = new ElasticsearchContainer(); public static ElasticsearchContainer elasticsearch = new ElasticsearchContainer();
private AnnotationConfigApplicationContext context; private ApplicationContextRunner contextRunner = new ApplicationContextRunner()
.withConfiguration(AutoConfigurations.of(ElasticsearchAutoConfiguration.class,
@AfterEach RestClientAutoConfiguration.class,
public void close() { ElasticsearchRepositoriesAutoConfiguration.class,
this.context.close(); ElasticsearchDataAutoConfiguration.class))
} .withPropertyValues("spring.elasticsearch.rest.uris=localhost:"
+ elasticsearch.getMappedHttpPort());
@Test @Test
public void testDefaultRepositoryConfiguration() { public void testDefaultRepositoryConfiguration() {
load(TestConfiguration.class); this.contextRunner.withUserConfiguration(TestConfiguration.class)
assertThat(this.context.getBean(CityRepository.class)).isNotNull(); .run((context) -> assertThat(context).hasSingleBean(CityRepository.class)
assertThat(this.context.getBean(Client.class)).isNotNull(); .hasSingleBean(ElasticsearchRestTemplate.class));
} }
@Test @Test
public void testNoRepositoryConfiguration() { public void testNoRepositoryConfiguration() {
load(EmptyConfiguration.class); this.contextRunner.withUserConfiguration(EmptyConfiguration.class)
assertThat(this.context.getBean(Client.class)).isNotNull(); .run((context) -> assertThat(context)
.hasSingleBean(ElasticsearchRestTemplate.class));
} }
@Test @Test
public void doesNotTriggerDefaultRepositoryDetectionIfCustomized() { public void doesNotTriggerDefaultRepositoryDetectionIfCustomized() {
load(CustomizedConfiguration.class); this.contextRunner.withUserConfiguration(CustomizedConfiguration.class)
assertThat(this.context.getBean(CityElasticsearchDbRepository.class)).isNotNull(); .run((context) -> assertThat(context)
} .hasSingleBean(CityElasticsearchDbRepository.class));
private void load(Class<?> config) {
this.context = new AnnotationConfigApplicationContext();
addElasticsearchProperties(this.context);
this.context.register(config, ElasticsearchAutoConfiguration.class,
ElasticsearchRepositoriesAutoConfiguration.class,
ElasticsearchDataAutoConfiguration.class,
PropertyPlaceholderAutoConfiguration.class);
this.context.refresh();
}
private void addElasticsearchProperties(AnnotationConfigApplicationContext context) {
TestPropertyValues.of(
"spring.data.elasticsearch.cluster-nodes:localhost:"
+ elasticsearch.getMappedTransportPort(),
"spring.data.elasticsearch.cluster-name:docker-cluster").applyTo(context);
} }
@Configuration(proxyBeanMethods = false) @Configuration(proxyBeanMethods = false)
@TestAutoConfigurationPackage(City.class) @TestAutoConfigurationPackage(City.class)
protected static class TestConfiguration { static class TestConfiguration {
} }
@Configuration(proxyBeanMethods = false) @Configuration(proxyBeanMethods = false)
@TestAutoConfigurationPackage(EmptyDataPackage.class) @TestAutoConfigurationPackage(EmptyDataPackage.class)
protected static class EmptyConfiguration { static class EmptyConfiguration {
} }
...@@ -108,7 +93,7 @@ public class ElasticsearchRepositoriesAutoConfigurationTests { ...@@ -108,7 +93,7 @@ public class ElasticsearchRepositoriesAutoConfigurationTests {
@TestAutoConfigurationPackage(ElasticsearchRepositoriesAutoConfigurationTests.class) @TestAutoConfigurationPackage(ElasticsearchRepositoriesAutoConfigurationTests.class)
@EnableElasticsearchRepositories( @EnableElasticsearchRepositories(
basePackageClasses = CityElasticsearchDbRepository.class) basePackageClasses = CityElasticsearchDbRepository.class)
protected static class CustomizedConfiguration { static class CustomizedConfiguration {
} }
......
...@@ -4932,15 +4932,16 @@ To take full control over the registration, define a `JestClient` bean. ...@@ -4932,15 +4932,16 @@ To take full control over the registration, define a `JestClient` bean.
[[boot-features-connecting-to-elasticsearch-spring-data]] [[boot-features-connecting-to-elasticsearch-spring-data]]
==== Connecting to Elasticsearch by Using Spring Data ==== Connecting to Elasticsearch by Using Spring Data
To connect to Elasticsearch, you must provide the address of one or more cluster nodes.
The address can be specified by setting the `spring.data.elasticsearch.cluster-nodes` To connect to Elasticsearch, you must provide the address of one or more Elasticsearch
instances. The address can be specified by setting the `spring.elasticsearch.rest.uris`
property to a comma-separated `host:port` list. With this configuration in place, an property to a comma-separated `host:port` list. With this configuration in place, an
`ElasticsearchTemplate` or `TransportClient` can be injected like any other Spring bean, `ElasticsearchRestTemplate` or `RestHighLevelClient` can be injected like any other Spring bean,
as shown in the following example: as shown in the following example:
[source,properties,indent=0] [source,properties,indent=0]
---- ----
spring.data.elasticsearch.cluster-nodes=localhost:9300 spring.elasticsearch.rest.uris=localhost:9200
---- ----
[source,java,indent=0] [source,java,indent=0]
...@@ -4948,9 +4949,9 @@ as shown in the following example: ...@@ -4948,9 +4949,9 @@ as shown in the following example:
@Component @Component
public class MyBean { public class MyBean {
private final ElasticsearchTemplate template; private final ElasticsearchRestTemplate template;
public MyBean(ElasticsearchTemplate template) { public MyBean(ElasticsearchRestTemplate template) {
this.template = template; this.template = template;
} }
...@@ -4959,8 +4960,8 @@ as shown in the following example: ...@@ -4959,8 +4960,8 @@ as shown in the following example:
} }
---- ----
If you add your own `ElasticsearchTemplate` or `TransportClient` `@Bean`, it replaces the If you add your own `ElasticsearchRestTemplate` or `ElasticsearchOperations` `@Bean`,
default. it replaces the default given it is named `"elasticsearchTemplate""`.
......
...@@ -26,16 +26,20 @@ import java.time.Duration; ...@@ -26,16 +26,20 @@ import java.time.Duration;
public class ElasticsearchContainer extends Container { public class ElasticsearchContainer extends Container {
public ElasticsearchContainer() { public ElasticsearchContainer() {
super("elasticsearch:6.4.3", 9200, super("elasticsearch:6.7.2", 9200,
(container) -> container.withStartupTimeout(Duration.ofSeconds(120)) (container) -> container.withStartupTimeout(Duration.ofSeconds(120))
.withStartupAttempts(5).withEnv("discovery.type", "single-node") .withStartupAttempts(5).withEnv("discovery.type", "single-node")
.addExposedPort(9300)); .addExposedPorts(9200, 9300));
} }
public int getMappedTransportPort() { public int getMappedTransportPort() {
return getContainer().getMappedPort(9300); return getContainer().getMappedPort(9300);
} }
public int getMappedHttpPort() {
return getContainer().getMappedPort(9200);
}
@Override @Override
public void start() { public void start() {
System.setProperty("es.set.netty.runtime.available.processors", "false"); System.setProperty("es.set.netty.runtime.available.processors", "false");
......
spring.data.elasticsearch.cluster-nodes=localhost:9200 spring.elasticsearch.rest.uris=localhost:9200
...@@ -16,7 +16,8 @@ ...@@ -16,7 +16,8 @@
package sample.data.elasticsearch; package sample.data.elasticsearch;
import org.elasticsearch.client.transport.NoNodeAvailableException; import java.net.ConnectException;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
...@@ -51,7 +52,7 @@ class SampleElasticsearchApplicationTests { ...@@ -51,7 +52,7 @@ class SampleElasticsearchApplicationTests {
private boolean elasticsearchRunning(Exception ex) { private boolean elasticsearchRunning(Exception ex) {
Throwable candidate = ex; Throwable candidate = ex;
while (candidate != null) { while (candidate != null) {
if (candidate instanceof NoNodeAvailableException) { if (candidate instanceof ConnectException) {
return false; return false;
} }
candidate = candidate.getCause(); candidate = candidate.getCause();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment