Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
c8105413
Commit
c8105413
authored
Jan 24, 2020
by
Dmytro Nosan
Committed by
Stephane Nicoll
Jan 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix scope of CqlSessionBuilder bean
See gh-19899
parent
2a01c026
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
0 deletions
+15
-0
CassandraAutoConfiguration.java
...t/autoconfigure/cassandra/CassandraAutoConfiguration.java
+2
-0
CassandraAutoConfigurationTests.java
...oconfigure/cassandra/CassandraAutoConfigurationTests.java
+13
-0
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/cassandra/CassandraAutoConfiguration.java
View file @
c8105413
...
@@ -44,6 +44,7 @@ import org.springframework.boot.context.properties.PropertyMapper;
...
@@ -44,6 +44,7 @@ import org.springframework.boot.context.properties.PropertyMapper;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Lazy
;
import
org.springframework.context.annotation.Lazy
;
import
org.springframework.context.annotation.Scope
;
/**
/**
* {@link EnableAutoConfiguration Auto-configuration} for Cassandra.
* {@link EnableAutoConfiguration Auto-configuration} for Cassandra.
...
@@ -69,6 +70,7 @@ public class CassandraAutoConfiguration {
...
@@ -69,6 +70,7 @@ public class CassandraAutoConfiguration {
@Bean
@Bean
@ConditionalOnMissingBean
@ConditionalOnMissingBean
@Scope
(
"prototype"
)
public
CqlSessionBuilder
cassandraSessionBuilder
(
CassandraProperties
properties
,
public
CqlSessionBuilder
cassandraSessionBuilder
(
CassandraProperties
properties
,
DriverConfigLoader
driverConfigLoader
,
ObjectProvider
<
CqlSessionBuilderCustomizer
>
builderCustomizers
)
{
DriverConfigLoader
driverConfigLoader
,
ObjectProvider
<
CqlSessionBuilderCustomizer
>
builderCustomizers
)
{
CqlSessionBuilder
builder
=
CqlSession
.
builder
().
withConfigLoader
(
driverConfigLoader
);
CqlSessionBuilder
builder
=
CqlSession
.
builder
().
withConfigLoader
(
driverConfigLoader
);
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/cassandra/CassandraAutoConfigurationTests.java
View file @
c8105413
...
@@ -16,6 +16,8 @@
...
@@ -16,6 +16,8 @@
package
org
.
springframework
.
boot
.
autoconfigure
.
cassandra
;
package
org
.
springframework
.
boot
.
autoconfigure
.
cassandra
;
import
com.datastax.oss.driver.api.core.CqlIdentifier
;
import
com.datastax.oss.driver.api.core.CqlSessionBuilder
;
import
com.datastax.oss.driver.api.core.config.DefaultDriverOption
;
import
com.datastax.oss.driver.api.core.config.DefaultDriverOption
;
import
com.datastax.oss.driver.api.core.config.DriverConfigLoader
;
import
com.datastax.oss.driver.api.core.config.DriverConfigLoader
;
import
com.datastax.oss.driver.api.core.config.DriverExecutionProfile
;
import
com.datastax.oss.driver.api.core.config.DriverExecutionProfile
;
...
@@ -42,6 +44,17 @@ class CassandraAutoConfigurationTests {
...
@@ -42,6 +44,17 @@ class CassandraAutoConfigurationTests {
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
private
final
ApplicationContextRunner
contextRunner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
AutoConfigurations
.
of
(
CassandraAutoConfiguration
.
class
));
.
withConfiguration
(
AutoConfigurations
.
of
(
CassandraAutoConfiguration
.
class
));
@Test
void
cqlSessionBuilderThreadSafe
()
{
this
.
contextRunner
.
run
((
context
)
->
{
CqlIdentifier
keyspace
=
CqlIdentifier
.
fromCql
(
"test"
);
assertThat
(
context
).
hasSingleBean
(
CqlSessionBuilder
.
class
);
assertThat
(
context
.
getBean
(
CqlSessionBuilder
.
class
).
withKeyspace
(
keyspace
))
.
hasFieldOrPropertyWithValue
(
"keyspace"
,
keyspace
);
assertThat
(
context
.
getBean
(
CqlSessionBuilder
.
class
)).
hasFieldOrPropertyWithValue
(
"keyspace"
,
null
);
});
}
@Test
@Test
void
driverConfigLoaderWithDefaultConfiguration
()
{
void
driverConfigLoaderWithDefaultConfiguration
()
{
this
.
contextRunner
.
run
((
context
)
->
{
this
.
contextRunner
.
run
((
context
)
->
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment