Commit ccdf5a93 authored by Stephane Nicoll's avatar Stephane Nicoll

Merge pull request #24604 from izeye

* pr/24604:
  Polish

Closes gh-24604
parents e3d7ab0e 5e3f618f
...@@ -2439,10 +2439,10 @@ To configure Spring Security to require a secure channel for all (or some) reque ...@@ -2439,10 +2439,10 @@ To configure Spring Security to require a secure channel for all (or some) reque
[source,java,indent=0,subs="verbatim,quotes,attributes"] [source,java,indent=0,subs="verbatim,quotes,attributes"]
---- ----
@Bean @Bean
public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception { public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
// Customize the application security // Customize the application security
http.requiresChannel().anyRequest().requiresSecure(); http.requiresChannel().anyRequest().requiresSecure();
return http.build(); return http.build();
} }
---- ----
......
...@@ -359,12 +359,12 @@ A typical Spring Security configuration might look something like the following ...@@ -359,12 +359,12 @@ A typical Spring Security configuration might look something like the following
[source,java,indent=0] [source,java,indent=0]
---- ----
@Bean @Bean
public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception { public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
http.requestMatcher(EndpointRequest.toAnyEndpoint()).authorizeRequests((requests) -> http.requestMatcher(EndpointRequest.toAnyEndpoint()).authorizeRequests((requests) ->
requests.anyRequest().hasRole("ENDPOINT_ADMIN")); requests.anyRequest().hasRole("ENDPOINT_ADMIN"));
http.httpBasic(); http.httpBasic();
return http.build(); return http.build();
} }
---- ----
...@@ -388,12 +388,12 @@ Additionally, if Spring Security is present, you would need to add custom securi ...@@ -388,12 +388,12 @@ Additionally, if Spring Security is present, you would need to add custom securi
[source,java,indent=0] [source,java,indent=0]
---- ----
@Bean @Bean
public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception { public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception {
http.requestMatcher(EndpointRequest.toAnyEndpoint()).authorizeRequests((requests) -> http.requestMatcher(EndpointRequest.toAnyEndpoint()).authorizeRequests((requests) ->
requests.anyRequest().permitAll()); requests.anyRequest().permitAll());
return http.build(); return http.build();
} }
---- ----
NOTE: In both the examples above, the configuration applies only to the actuator endpoints. NOTE: In both the examples above, the configuration applies only to the actuator endpoints.
......
...@@ -360,7 +360,7 @@ class ProfilesTests { ...@@ -360,7 +360,7 @@ class ProfilesTests {
} }
@Test @Test
void simpleRecursiveReferenceInProfileGroupThrowsException() { void simpleRecursiveReferenceInProfileGroupIgnoresDuplicates() {
MockEnvironment environment = new MockEnvironment(); MockEnvironment environment = new MockEnvironment();
environment.setProperty("spring.profiles.active", "a,b,c"); environment.setProperty("spring.profiles.active", "a,b,c");
environment.setProperty("spring.profiles.group.a", "a,e,f"); environment.setProperty("spring.profiles.group.a", "a,e,f");
......
...@@ -66,9 +66,9 @@ class CorsSampleActuatorApplicationTests { ...@@ -66,9 +66,9 @@ class CorsSampleActuatorApplicationTests {
@Test @Test
void preflightRequestToEndpointShouldReturnOk() throws Exception { void preflightRequestToEndpointShouldReturnOk() throws Exception {
RequestEntity<?> healthRequest = RequestEntity.options(new URI("/actuator/env")) RequestEntity<?> envRequest = RequestEntity.options(new URI("/actuator/env"))
.header("Origin", "http://localhost:8080").header("Access-Control-Request-Method", "GET").build(); .header("Origin", "http://localhost:8080").header("Access-Control-Request-Method", "GET").build();
ResponseEntity<?> exchange = this.testRestTemplate.exchange(healthRequest, Map.class); ResponseEntity<?> exchange = this.testRestTemplate.exchange(envRequest, Map.class);
assertThat(exchange.getStatusCode()).isEqualTo(HttpStatus.OK); assertThat(exchange.getStatusCode()).isEqualTo(HttpStatus.OK);
} }
......
...@@ -66,9 +66,9 @@ class CorsSampleActuatorApplicationTests { ...@@ -66,9 +66,9 @@ class CorsSampleActuatorApplicationTests {
@Test @Test
void preflightRequestToEndpointShouldReturnOk() throws Exception { void preflightRequestToEndpointShouldReturnOk() throws Exception {
RequestEntity<?> healthRequest = RequestEntity.options(new URI("/actuator/env")) RequestEntity<?> envRequest = RequestEntity.options(new URI("/actuator/env"))
.header("Origin", "http://localhost:8080").header("Access-Control-Request-Method", "GET").build(); .header("Origin", "http://localhost:8080").header("Access-Control-Request-Method", "GET").build();
ResponseEntity<?> exchange = this.testRestTemplate.exchange(healthRequest, Map.class); ResponseEntity<?> exchange = this.testRestTemplate.exchange(envRequest, Map.class);
assertThat(exchange.getStatusCode()).isEqualTo(HttpStatus.OK); assertThat(exchange.getStatusCode()).isEqualTo(HttpStatus.OK);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment