Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
e2119d33
Commit
e2119d33
authored
Aug 22, 2015
by
izeye
Committed by
Stephane Nicoll
Aug 23, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix typos
Closes gh-3809
parent
69fcae6b
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
16 additions
and
16 deletions
+16
-16
ConditionalOnEnabledHealthIndicator.java
...te/autoconfigure/ConditionalOnEnabledHealthIndicator.java
+2
-2
HealthIndicatorAutoConfiguration.java
...tuate/autoconfigure/HealthIndicatorAutoConfiguration.java
+9
-9
OnEnabledHealthIndicatorCondition.java
...uate/autoconfigure/OnEnabledHealthIndicatorCondition.java
+1
-1
HealthIndicatorAutoConfigurationTests.java
.../autoconfigure/HealthIndicatorAutoConfigurationTests.java
+1
-1
AbstractConfigurableEmbeddedServletContainer.java
...mbedded/AbstractConfigurableEmbeddedServletContainer.java
+1
-1
AbstractEmbeddedServletContainerFactoryTests.java
...mbedded/AbstractEmbeddedServletContainerFactoryTests.java
+2
-2
No files found.
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ConditionalOnEnabled
n
HealthIndicator.java
→
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ConditionalOnEnabledHealthIndicator.java
View file @
e2119d33
...
@@ -27,7 +27,7 @@ import org.springframework.context.annotation.Conditional;
...
@@ -27,7 +27,7 @@ import org.springframework.context.annotation.Conditional;
/**
/**
* {@link Conditional} that checks whether or not a default health indicator is enabled.
* {@link Conditional} that checks whether or not a default health indicator is enabled.
* Matches if the value of the {@code management.health.<name>.enabled} property is
* Matches if the value of the {@code management.health.<name>.enabled} property is
* {@code true}. Otherwise
, matches if the value of the
* {@code true}. Otherwise, matches if the value of the
* {@code management.health.defaults.enabled} property is {@code true} or if it is not
* {@code management.health.defaults.enabled} property is {@code true} or if it is not
* configured.
* configured.
*
*
...
@@ -38,7 +38,7 @@ import org.springframework.context.annotation.Conditional;
...
@@ -38,7 +38,7 @@ import org.springframework.context.annotation.Conditional;
@Target
({
ElementType
.
TYPE
,
ElementType
.
METHOD
})
@Target
({
ElementType
.
TYPE
,
ElementType
.
METHOD
})
@Documented
@Documented
@Conditional
(
OnEnabledHealthIndicatorCondition
.
class
)
@Conditional
(
OnEnabledHealthIndicatorCondition
.
class
)
public
@interface
ConditionalOnEnabled
n
HealthIndicator
{
public
@interface
ConditionalOnEnabledHealthIndicator
{
/**
/**
* The name of the health indicator.
* The name of the health indicator.
...
...
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/HealthIndicatorAutoConfiguration.java
View file @
e2119d33
...
@@ -153,7 +153,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -153,7 +153,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnClass
(
JdbcTemplate
.
class
)
@ConditionalOnClass
(
JdbcTemplate
.
class
)
@ConditionalOnBean
(
DataSource
.
class
)
@ConditionalOnBean
(
DataSource
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"db"
)
@ConditionalOnEnabledHealthIndicator
(
"db"
)
public
static
class
DataSourcesHealthIndicatorConfiguration
extends
public
static
class
DataSourcesHealthIndicatorConfiguration
extends
CompositeHealthIndicatorConfiguration
<
DataSourceHealthIndicator
,
DataSource
>
CompositeHealthIndicatorConfiguration
<
DataSourceHealthIndicator
,
DataSource
>
implements
InitializingBean
{
implements
InitializingBean
{
...
@@ -193,7 +193,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -193,7 +193,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnBean
(
MongoTemplate
.
class
)
@ConditionalOnBean
(
MongoTemplate
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"mongo"
)
@ConditionalOnEnabledHealthIndicator
(
"mongo"
)
public
static
class
MongoHealthIndicatorConfiguration
extends
public
static
class
MongoHealthIndicatorConfiguration
extends
CompositeHealthIndicatorConfiguration
<
MongoHealthIndicator
,
MongoTemplate
>
{
CompositeHealthIndicatorConfiguration
<
MongoHealthIndicator
,
MongoTemplate
>
{
...
@@ -210,7 +210,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -210,7 +210,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnBean
(
RedisConnectionFactory
.
class
)
@ConditionalOnBean
(
RedisConnectionFactory
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"redis"
)
@ConditionalOnEnabledHealthIndicator
(
"redis"
)
public
static
class
RedisHealthIndicatorConfiguration
public
static
class
RedisHealthIndicatorConfiguration
extends
extends
CompositeHealthIndicatorConfiguration
<
RedisHealthIndicator
,
RedisConnectionFactory
>
{
CompositeHealthIndicatorConfiguration
<
RedisHealthIndicator
,
RedisConnectionFactory
>
{
...
@@ -228,7 +228,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -228,7 +228,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnBean
(
RabbitTemplate
.
class
)
@ConditionalOnBean
(
RabbitTemplate
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"rabbit"
)
@ConditionalOnEnabledHealthIndicator
(
"rabbit"
)
public
static
class
RabbitHealthIndicatorConfiguration
extends
public
static
class
RabbitHealthIndicatorConfiguration
extends
CompositeHealthIndicatorConfiguration
<
RabbitHealthIndicator
,
RabbitTemplate
>
{
CompositeHealthIndicatorConfiguration
<
RabbitHealthIndicator
,
RabbitTemplate
>
{
...
@@ -245,7 +245,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -245,7 +245,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnBean
(
SolrServer
.
class
)
@ConditionalOnBean
(
SolrServer
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"solr"
)
@ConditionalOnEnabledHealthIndicator
(
"solr"
)
public
static
class
SolrHealthIndicatorConfiguration
extends
public
static
class
SolrHealthIndicatorConfiguration
extends
CompositeHealthIndicatorConfiguration
<
SolrHealthIndicator
,
SolrServer
>
{
CompositeHealthIndicatorConfiguration
<
SolrHealthIndicator
,
SolrServer
>
{
...
@@ -261,7 +261,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -261,7 +261,7 @@ public class HealthIndicatorAutoConfiguration {
}
}
@Configuration
@Configuration
@ConditionalOnEnabled
n
HealthIndicator
(
"diskspace"
)
@ConditionalOnEnabledHealthIndicator
(
"diskspace"
)
public
static
class
DiskSpaceHealthIndicatorConfiguration
{
public
static
class
DiskSpaceHealthIndicatorConfiguration
{
@Bean
@Bean
...
@@ -280,7 +280,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -280,7 +280,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnBean
(
JavaMailSenderImpl
.
class
)
@ConditionalOnBean
(
JavaMailSenderImpl
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"mail"
)
@ConditionalOnEnabledHealthIndicator
(
"mail"
)
public
static
class
MailHealthIndicatorConfiguration
public
static
class
MailHealthIndicatorConfiguration
extends
extends
CompositeHealthIndicatorConfiguration
<
MailHealthIndicator
,
JavaMailSenderImpl
>
{
CompositeHealthIndicatorConfiguration
<
MailHealthIndicator
,
JavaMailSenderImpl
>
{
...
@@ -298,7 +298,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -298,7 +298,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnBean
(
ConnectionFactory
.
class
)
@ConditionalOnBean
(
ConnectionFactory
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"jms"
)
@ConditionalOnEnabledHealthIndicator
(
"jms"
)
public
static
class
JmsHealthIndicatorConfiguration
extends
public
static
class
JmsHealthIndicatorConfiguration
extends
CompositeHealthIndicatorConfiguration
<
JmsHealthIndicator
,
ConnectionFactory
>
{
CompositeHealthIndicatorConfiguration
<
JmsHealthIndicator
,
ConnectionFactory
>
{
...
@@ -315,7 +315,7 @@ public class HealthIndicatorAutoConfiguration {
...
@@ -315,7 +315,7 @@ public class HealthIndicatorAutoConfiguration {
@Configuration
@Configuration
@ConditionalOnBean
(
Client
.
class
)
@ConditionalOnBean
(
Client
.
class
)
@ConditionalOnEnabled
n
HealthIndicator
(
"elasticsearch"
)
@ConditionalOnEnabledHealthIndicator
(
"elasticsearch"
)
@EnableConfigurationProperties
(
ElasticsearchHealthIndicatorProperties
.
class
)
@EnableConfigurationProperties
(
ElasticsearchHealthIndicatorProperties
.
class
)
public
static
class
ElasticsearchHealthIndicatorConfiguration
extends
public
static
class
ElasticsearchHealthIndicatorConfiguration
extends
CompositeHealthIndicatorConfiguration
<
ElasticsearchHealthIndicator
,
Client
>
{
CompositeHealthIndicatorConfiguration
<
ElasticsearchHealthIndicator
,
Client
>
{
...
...
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/OnEnabledHealthIndicatorCondition.java
View file @
e2119d33
...
@@ -31,7 +31,7 @@ import org.springframework.core.type.AnnotatedTypeMetadata;
...
@@ -31,7 +31,7 @@ import org.springframework.core.type.AnnotatedTypeMetadata;
*/
*/
class
OnEnabledHealthIndicatorCondition
extends
SpringBootCondition
{
class
OnEnabledHealthIndicatorCondition
extends
SpringBootCondition
{
private
static
final
String
ANNOTATION_CLASS
=
ConditionalOnEnabled
n
HealthIndicator
.
class
private
static
final
String
ANNOTATION_CLASS
=
ConditionalOnEnabledHealthIndicator
.
class
.
getName
();
.
getName
();
@Override
@Override
...
...
spring-boot-actuator/src/test/java/org/springframework/boot/actuate/autoconfigure/HealthIndicatorAutoConfigurationTests.java
View file @
e2119d33
...
@@ -122,7 +122,7 @@ public class HealthIndicatorAutoConfigurationTests {
...
@@ -122,7 +122,7 @@ public class HealthIndicatorAutoConfigurationTests {
this
.
context
.
register
(
HealthIndicatorAutoConfiguration
.
class
,
this
.
context
.
register
(
HealthIndicatorAutoConfiguration
.
class
,
ManagementServerProperties
.
class
);
ManagementServerProperties
.
class
);
EnvironmentTestUtils
.
addEnvironment
(
this
.
context
,
EnvironmentTestUtils
.
addEnvironment
(
this
.
context
,
"management.health.enabled:false"
,
"management.health.
defaults.
enabled:false"
,
"management.health.diskspace.enabled:true"
);
"management.health.diskspace.enabled:true"
);
this
.
context
.
refresh
();
this
.
context
.
refresh
();
Map
<
String
,
HealthIndicator
>
beans
=
this
.
context
Map
<
String
,
HealthIndicator
>
beans
=
this
.
context
...
...
spring-boot/src/main/java/org/springframework/boot/context/embedded/AbstractConfigurableEmbeddedServletContainer.java
View file @
e2119d33
...
@@ -114,7 +114,7 @@ public abstract class AbstractConfigurableEmbeddedServletContainer implements
...
@@ -114,7 +114,7 @@ public abstract class AbstractConfigurableEmbeddedServletContainer implements
}
}
if
(!
contextPath
.
startsWith
(
"/"
)
||
contextPath
.
endsWith
(
"/"
))
{
if
(!
contextPath
.
startsWith
(
"/"
)
||
contextPath
.
endsWith
(
"/"
))
{
throw
new
IllegalArgumentException
(
throw
new
IllegalArgumentException
(
"ContextPath must start with '/ and not end with '/'"
);
"ContextPath must start with '/
'
and not end with '/'"
);
}
}
}
}
}
}
...
...
spring-boot/src/test/java/org/springframework/boot/context/embedded/AbstractEmbeddedServletContainerFactoryTests.java
View file @
e2119d33
...
@@ -245,14 +245,14 @@ public abstract class AbstractEmbeddedServletContainerFactoryTests {
...
@@ -245,14 +245,14 @@ public abstract class AbstractEmbeddedServletContainerFactoryTests {
@Test
@Test
public
void
contextPathMustStartWithSlash
()
throws
Exception
{
public
void
contextPathMustStartWithSlash
()
throws
Exception
{
this
.
thrown
.
expect
(
IllegalArgumentException
.
class
);
this
.
thrown
.
expect
(
IllegalArgumentException
.
class
);
this
.
thrown
.
expectMessage
(
"ContextPath must start with '/ and not end with '/'"
);
this
.
thrown
.
expectMessage
(
"ContextPath must start with '/
'
and not end with '/'"
);
getFactory
().
setContextPath
(
"missingslash"
);
getFactory
().
setContextPath
(
"missingslash"
);
}
}
@Test
@Test
public
void
contextPathMustNotEndWithSlash
()
throws
Exception
{
public
void
contextPathMustNotEndWithSlash
()
throws
Exception
{
this
.
thrown
.
expect
(
IllegalArgumentException
.
class
);
this
.
thrown
.
expect
(
IllegalArgumentException
.
class
);
this
.
thrown
.
expectMessage
(
"ContextPath must start with '/ and not end with '/'"
);
this
.
thrown
.
expectMessage
(
"ContextPath must start with '/
'
and not end with '/'"
);
getFactory
().
setContextPath
(
"extraslash/"
);
getFactory
().
setContextPath
(
"extraslash/"
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment