Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
e2289e2f
Commit
e2289e2f
authored
Oct 02, 2020
by
Madhura Bhave
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch '2.2.x' into 2.3.x
Closes gh-23569
parents
9a6d52e3
4dad8c22
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
26 additions
and
2 deletions
+26
-2
H2ConsoleAutoConfiguration.java
...ork/boot/autoconfigure/h2/H2ConsoleAutoConfiguration.java
+1
-2
H2ConsoleAutoConfigurationTests.java
...oot/autoconfigure/h2/H2ConsoleAutoConfigurationTests.java
+25
-0
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/h2/H2ConsoleAutoConfiguration.java
View file @
e2289e2f
...
@@ -17,7 +17,6 @@
...
@@ -17,7 +17,6 @@
package
org
.
springframework
.
boot
.
autoconfigure
.
h2
;
package
org
.
springframework
.
boot
.
autoconfigure
.
h2
;
import
java.sql.Connection
;
import
java.sql.Connection
;
import
java.sql.SQLException
;
import
javax.sql.DataSource
;
import
javax.sql.DataSource
;
...
@@ -74,7 +73,7 @@ public class H2ConsoleAutoConfiguration {
...
@@ -74,7 +73,7 @@ public class H2ConsoleAutoConfiguration {
logger
.
info
(
"H2 console available at '"
+
path
+
"'. Database available at '"
logger
.
info
(
"H2 console available at '"
+
path
+
"'. Database available at '"
+
connection
.
getMetaData
().
getURL
()
+
"'"
);
+
connection
.
getMetaData
().
getURL
()
+
"'"
);
}
}
catch
(
SQL
Exception
ex
)
{
catch
(
Exception
ex
)
{
// Continue
// Continue
}
}
});
});
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/h2/H2ConsoleAutoConfigurationTests.java
View file @
e2289e2f
...
@@ -17,6 +17,7 @@
...
@@ -17,6 +17,7 @@
package
org
.
springframework
.
boot
.
autoconfigure
.
h2
;
package
org
.
springframework
.
boot
.
autoconfigure
.
h2
;
import
java.sql.Connection
;
import
java.sql.Connection
;
import
java.sql.SQLException
;
import
javax.sql.DataSource
;
import
javax.sql.DataSource
;
...
@@ -31,8 +32,12 @@ import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
...
@@ -31,8 +32,12 @@ import org.springframework.boot.test.context.runner.WebApplicationContextRunner;
import
org.springframework.boot.test.system.CapturedOutput
;
import
org.springframework.boot.test.system.CapturedOutput
;
import
org.springframework.boot.test.system.OutputCaptureExtension
;
import
org.springframework.boot.test.system.OutputCaptureExtension
;
import
org.springframework.boot.web.servlet.ServletRegistrationBean
;
import
org.springframework.boot.web.servlet.ServletRegistrationBean
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
mockito
.
BDDMockito
.
given
;
import
static
org
.
mockito
.
Mockito
.
mock
;
/**
/**
* Tests for {@link H2ConsoleAutoConfiguration}
* Tests for {@link H2ConsoleAutoConfiguration}
...
@@ -40,6 +45,7 @@ import static org.assertj.core.api.Assertions.assertThat;
...
@@ -40,6 +45,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* @author Andy Wilkinson
* @author Andy Wilkinson
* @author Marten Deinum
* @author Marten Deinum
* @author Stephane Nicoll
* @author Stephane Nicoll
* @author Shraddha Yeole
*/
*/
class
H2ConsoleAutoConfigurationTests
{
class
H2ConsoleAutoConfigurationTests
{
...
@@ -117,4 +123,23 @@ class H2ConsoleAutoConfigurationTests {
...
@@ -117,4 +123,23 @@ class H2ConsoleAutoConfigurationTests {
});
});
}
}
@Test
void
h2ConsoleShouldNotFailIfDatabaseConnectionFails
()
{
this
.
contextRunner
.
withUserConfiguration
(
CustomDataSourceConfiguration
.
class
)
.
withPropertyValues
(
"spring.h2.console.enabled=true"
)
.
run
((
context
)
->
assertThat
(
context
.
isRunning
()).
isTrue
());
}
@Configuration
(
proxyBeanMethods
=
false
)
static
class
CustomDataSourceConfiguration
{
@Bean
DataSource
dataSource
()
throws
SQLException
{
DataSource
dataSource
=
mock
(
DataSource
.
class
);
given
(
dataSource
.
getConnection
()).
willThrow
(
IllegalStateException
.
class
);
return
dataSource
;
}
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment