Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
e5757946
Commit
e5757946
authored
Jul 02, 2019
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prevent endpoint's shutdown() method from being a destroy method
Closes gh-17407
parent
59978868
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
4 deletions
+14
-4
ShutdownEndpointAutoConfiguration.java
...oconfigure/context/ShutdownEndpointAutoConfiguration.java
+1
-1
ShutdownEndpointAutoConfigurationTests.java
...igure/context/ShutdownEndpointAutoConfigurationTests.java
+13
-3
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/context/ShutdownEndpointAutoConfiguration.java
View file @
e5757946
...
@@ -33,7 +33,7 @@ import org.springframework.context.annotation.Configuration;
...
@@ -33,7 +33,7 @@ import org.springframework.context.annotation.Configuration;
@ConditionalOnEnabledEndpoint
(
endpoint
=
ShutdownEndpoint
.
class
)
@ConditionalOnEnabledEndpoint
(
endpoint
=
ShutdownEndpoint
.
class
)
public
class
ShutdownEndpointAutoConfiguration
{
public
class
ShutdownEndpointAutoConfiguration
{
@Bean
@Bean
(
destroyMethod
=
""
)
@ConditionalOnMissingBean
@ConditionalOnMissingBean
public
ShutdownEndpoint
shutdownEndpoint
()
{
public
ShutdownEndpoint
shutdownEndpoint
()
{
return
new
ShutdownEndpoint
();
return
new
ShutdownEndpoint
();
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/context/ShutdownEndpointAutoConfigurationTests.java
View file @
e5757946
...
@@ -16,11 +16,15 @@
...
@@ -16,11 +16,15 @@
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
context
;
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
context
;
import
java.util.Map
;
import
org.junit.Test
;
import
org.junit.Test
;
import
org.springframework.beans.factory.config.ConfigurableListableBeanFactory
;
import
org.springframework.boot.actuate.context.ShutdownEndpoint
;
import
org.springframework.boot.actuate.context.ShutdownEndpoint
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.test.util.ReflectionTestUtils
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
@@ -35,9 +39,15 @@ public class ShutdownEndpointAutoConfigurationTests {
...
@@ -35,9 +39,15 @@ public class ShutdownEndpointAutoConfigurationTests {
.
withConfiguration
(
AutoConfigurations
.
of
(
ShutdownEndpointAutoConfiguration
.
class
));
.
withConfiguration
(
AutoConfigurations
.
of
(
ShutdownEndpointAutoConfiguration
.
class
));
@Test
@Test
public
void
runShouldHaveEndpointBean
()
{
@SuppressWarnings
(
"unchecked"
)
this
.
contextRunner
.
withPropertyValues
(
"management.endpoint.shutdown.enabled:true"
)
public
void
runShouldHaveEndpointBeanThatIsNotDisposable
()
{
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
ShutdownEndpoint
.
class
));
this
.
contextRunner
.
withPropertyValues
(
"management.endpoint.shutdown.enabled:true"
).
run
((
context
)
->
{
assertThat
(
context
).
hasSingleBean
(
ShutdownEndpoint
.
class
);
ConfigurableListableBeanFactory
beanFactory
=
context
.
getBeanFactory
();
Map
<
String
,
Object
>
disposableBeans
=
(
Map
<
String
,
Object
>)
ReflectionTestUtils
.
getField
(
beanFactory
,
"disposableBeans"
);
assertThat
(
disposableBeans
).
isEmpty
();
});
}
}
@Test
@Test
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment