Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
eaad22dd
Commit
eaad22dd
authored
Aug 16, 2019
by
Andrii Hrytsiuk
Committed by
Madhura Bhave
Aug 16, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Set up SpringLiquibase beans' dependencies by type rather than name
See gh-17805
parent
24f6c9e4
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
66 additions
and
3 deletions
+66
-3
EntityManagerFactoryDependsOnPostProcessor.java
.../data/jpa/EntityManagerFactoryDependsOnPostProcessor.java
+9
-0
JdbcOperationsDependsOnPostProcessor.java
...oconfigure/jdbc/JdbcOperationsDependsOnPostProcessor.java
+9
-0
NamedParameterJdbcOperationsDependsOnPostProcessor.java
...c/NamedParameterJdbcOperationsDependsOnPostProcessor.java
+9
-0
LiquibaseAutoConfiguration.java
...t/autoconfigure/liquibase/LiquibaseAutoConfiguration.java
+3
-3
LiquibaseAutoConfigurationTests.java
...oconfigure/liquibase/LiquibaseAutoConfigurationTests.java
+36
-0
No files found.
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/data/jpa/EntityManagerFactoryDependsOnPostProcessor.java
View file @
eaad22dd
...
@@ -40,4 +40,13 @@ public class EntityManagerFactoryDependsOnPostProcessor extends AbstractDependsO
...
@@ -40,4 +40,13 @@ public class EntityManagerFactoryDependsOnPostProcessor extends AbstractDependsO
super
(
EntityManagerFactory
.
class
,
AbstractEntityManagerFactoryBean
.
class
,
dependsOn
);
super
(
EntityManagerFactory
.
class
,
AbstractEntityManagerFactoryBean
.
class
,
dependsOn
);
}
}
/**
* Creates a new {@code EntityManagerFactoryDependsOnPostProcessor} that will set up
* dependencies upon beans with the given types.
* @param dependsOn types of the beans to depend upon
*/
public
EntityManagerFactoryDependsOnPostProcessor
(
Class
<?>...
dependsOn
)
{
super
(
EntityManagerFactory
.
class
,
AbstractEntityManagerFactoryBean
.
class
,
dependsOn
);
}
}
}
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/JdbcOperationsDependsOnPostProcessor.java
View file @
eaad22dd
...
@@ -38,4 +38,13 @@ public class JdbcOperationsDependsOnPostProcessor extends AbstractDependsOnBeanF
...
@@ -38,4 +38,13 @@ public class JdbcOperationsDependsOnPostProcessor extends AbstractDependsOnBeanF
super
(
JdbcOperations
.
class
,
dependsOn
);
super
(
JdbcOperations
.
class
,
dependsOn
);
}
}
/**
* Creates a new {@code JdbcOperationsDependsOnPostProcessor} that will set up
* dependencies upon beans with the given types.
* @param dependsOn types of the beans to depend upon
*/
public
JdbcOperationsDependsOnPostProcessor
(
Class
<?>...
dependsOn
)
{
super
(
JdbcOperations
.
class
,
dependsOn
);
}
}
}
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/NamedParameterJdbcOperationsDependsOnPostProcessor.java
View file @
eaad22dd
...
@@ -36,4 +36,13 @@ public class NamedParameterJdbcOperationsDependsOnPostProcessor extends Abstract
...
@@ -36,4 +36,13 @@ public class NamedParameterJdbcOperationsDependsOnPostProcessor extends Abstract
super
(
NamedParameterJdbcOperations
.
class
,
dependsOn
);
super
(
NamedParameterJdbcOperations
.
class
,
dependsOn
);
}
}
/**
* Creates a new {@code NamedParameterJdbcOperationsDependsOnPostProcessor} that will
* set up dependencies upon beans with the given types.
* @param dependsOn types of the beans to depend upon
*/
public
NamedParameterJdbcOperationsDependsOnPostProcessor
(
Class
<?>...
dependsOn
)
{
super
(
NamedParameterJdbcOperations
.
class
,
dependsOn
);
}
}
}
spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfiguration.java
View file @
eaad22dd
...
@@ -165,7 +165,7 @@ public class LiquibaseAutoConfiguration {
...
@@ -165,7 +165,7 @@ public class LiquibaseAutoConfiguration {
protected
static
class
LiquibaseJpaDependencyConfiguration
extends
EntityManagerFactoryDependsOnPostProcessor
{
protected
static
class
LiquibaseJpaDependencyConfiguration
extends
EntityManagerFactoryDependsOnPostProcessor
{
public
LiquibaseJpaDependencyConfiguration
()
{
public
LiquibaseJpaDependencyConfiguration
()
{
super
(
"liquibase"
);
super
(
SpringLiquibase
.
class
);
}
}
}
}
...
@@ -180,7 +180,7 @@ public class LiquibaseAutoConfiguration {
...
@@ -180,7 +180,7 @@ public class LiquibaseAutoConfiguration {
protected
static
class
LiquibaseJdbcOperationsDependencyConfiguration
extends
JdbcOperationsDependsOnPostProcessor
{
protected
static
class
LiquibaseJdbcOperationsDependencyConfiguration
extends
JdbcOperationsDependsOnPostProcessor
{
public
LiquibaseJdbcOperationsDependencyConfiguration
()
{
public
LiquibaseJdbcOperationsDependencyConfiguration
()
{
super
(
"liquibase"
);
super
(
SpringLiquibase
.
class
);
}
}
}
}
...
@@ -196,7 +196,7 @@ public class LiquibaseAutoConfiguration {
...
@@ -196,7 +196,7 @@ public class LiquibaseAutoConfiguration {
extends
NamedParameterJdbcOperationsDependsOnPostProcessor
{
extends
NamedParameterJdbcOperationsDependsOnPostProcessor
{
public
LiquibaseNamedParameterJdbcOperationsDependencyConfiguration
()
{
public
LiquibaseNamedParameterJdbcOperationsDependencyConfiguration
()
{
super
(
"liquibase"
);
super
(
SpringLiquibase
.
class
);
}
}
}
}
...
...
spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfigurationTests.java
View file @
eaad22dd
...
@@ -32,9 +32,11 @@ import org.junit.Test;
...
@@ -32,9 +32,11 @@ import org.junit.Test;
import
org.junit.rules.TemporaryFolder
;
import
org.junit.rules.TemporaryFolder
;
import
org.springframework.beans.factory.BeanCreationException
;
import
org.springframework.beans.factory.BeanCreationException
;
import
org.springframework.beans.factory.config.BeanDefinition
;
import
org.springframework.boot.SpringApplication
;
import
org.springframework.boot.SpringApplication
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.jdbc.EmbeddedDataSourceConfiguration
;
import
org.springframework.boot.autoconfigure.jdbc.EmbeddedDataSourceConfiguration
;
import
org.springframework.boot.autoconfigure.jdbc.JdbcTemplateAutoConfiguration
;
import
org.springframework.boot.context.event.ApplicationStartingEvent
;
import
org.springframework.boot.context.event.ApplicationStartingEvent
;
import
org.springframework.boot.jdbc.DataSourceBuilder
;
import
org.springframework.boot.jdbc.DataSourceBuilder
;
import
org.springframework.boot.liquibase.LiquibaseServiceLocatorApplicationListener
;
import
org.springframework.boot.liquibase.LiquibaseServiceLocatorApplicationListener
;
...
@@ -300,6 +302,26 @@ public class LiquibaseAutoConfigurationTests {
...
@@ -300,6 +302,26 @@ public class LiquibaseAutoConfigurationTests {
});
});
}
}
@Test
void
userConfigurationBeans
()
{
this
.
contextRunner
.
withUserConfiguration
(
LiquibaseUserConfiguration
.
class
,
EmbeddedDataSourceConfiguration
.
class
)
.
run
((
context
)
->
{
assertThat
(
context
).
hasBean
(
"springLiquibase"
);
assertThat
(
context
).
doesNotHaveBean
(
"liquibase"
);
});
}
@Test
void
userConfigurationJdbcTemplateDependency
()
{
this
.
contextRunner
.
withConfiguration
(
AutoConfigurations
.
of
(
JdbcTemplateAutoConfiguration
.
class
))
.
withUserConfiguration
(
LiquibaseUserConfiguration
.
class
,
EmbeddedDataSourceConfiguration
.
class
)
.
run
((
context
)
->
{
BeanDefinition
beanDefinition
=
context
.
getBeanFactory
().
getBeanDefinition
(
"jdbcTemplate"
);
assertThat
(
beanDefinition
.
getDependsOn
()).
containsExactly
(
"springLiquibase"
);
});
}
private
ContextConsumer
<
AssertableApplicationContext
>
assertLiquibase
(
Consumer
<
SpringLiquibase
>
consumer
)
{
private
ContextConsumer
<
AssertableApplicationContext
>
assertLiquibase
(
Consumer
<
SpringLiquibase
>
consumer
)
{
return
(
context
)
->
{
return
(
context
)
->
{
assertThat
(
context
).
hasSingleBean
(
SpringLiquibase
.
class
);
assertThat
(
context
).
hasSingleBean
(
SpringLiquibase
.
class
);
...
@@ -325,4 +347,18 @@ public class LiquibaseAutoConfigurationTests {
...
@@ -325,4 +347,18 @@ public class LiquibaseAutoConfigurationTests {
}
}
@Configuration
static
class
LiquibaseUserConfiguration
{
@Bean
SpringLiquibase
springLiquibase
(
DataSource
dataSource
)
{
SpringLiquibase
liquibase
=
new
SpringLiquibase
();
liquibase
.
setChangeLog
(
"classpath:/db/changelog/db.changelog-master.yaml"
);
liquibase
.
setShouldRun
(
true
);
liquibase
.
setDataSource
(
dataSource
);
return
liquibase
;
}
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment