Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
eba476ba
Commit
eba476ba
authored
Jan 29, 2018
by
Stephane Nicoll
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Disable LoggersEndpoint if the logging system is disabled
Closes gh-11793
parent
4b47a874
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
37 additions
and
2 deletions
+37
-2
LoggersEndpointAutoConfiguration.java
...toconfigure/logging/LoggersEndpointAutoConfiguration.java
+25
-1
LoggersEndpointAutoConfigurationTests.java
...figure/logging/LoggersEndpointAutoConfigurationTests.java
+12
-1
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/logging/LoggersEndpointAutoConfiguration.java
View file @
eba476ba
/*
/*
* Copyright 2012-201
7
the original author or authors.
* Copyright 2012-201
8
the original author or authors.
*
*
* Licensed under the Apache License, Version 2.0 (the "License");
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* you may not use this file except in compliance with the License.
...
@@ -19,11 +19,17 @@ package org.springframework.boot.actuate.autoconfigure.logging;
...
@@ -19,11 +19,17 @@ package org.springframework.boot.actuate.autoconfigure.logging;
import
org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint
;
import
org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint
;
import
org.springframework.boot.actuate.logging.LoggersEndpoint
;
import
org.springframework.boot.actuate.logging.LoggersEndpoint
;
import
org.springframework.boot.autoconfigure.EnableAutoConfiguration
;
import
org.springframework.boot.autoconfigure.EnableAutoConfiguration
;
import
org.springframework.boot.autoconfigure.condition.ConditionMessage
;
import
org.springframework.boot.autoconfigure.condition.ConditionOutcome
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnBean
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnBean
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean
;
import
org.springframework.boot.autoconfigure.condition.SpringBootCondition
;
import
org.springframework.boot.logging.LoggingSystem
;
import
org.springframework.boot.logging.LoggingSystem
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.ConditionContext
;
import
org.springframework.context.annotation.Conditional
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.core.type.AnnotatedTypeMetadata
;
/**
/**
* {@link EnableAutoConfiguration Auto-configuration} for the {@link LoggersEndpoint}.
* {@link EnableAutoConfiguration Auto-configuration} for the {@link LoggersEndpoint}.
...
@@ -36,10 +42,28 @@ public class LoggersEndpointAutoConfiguration {
...
@@ -36,10 +42,28 @@ public class LoggersEndpointAutoConfiguration {
@Bean
@Bean
@ConditionalOnBean
(
LoggingSystem
.
class
)
@ConditionalOnBean
(
LoggingSystem
.
class
)
@Conditional
(
OnEnabledLoggingSystemCondition
.
class
)
@ConditionalOnMissingBean
@ConditionalOnMissingBean
@ConditionalOnEnabledEndpoint
@ConditionalOnEnabledEndpoint
public
LoggersEndpoint
loggersEndpoint
(
LoggingSystem
loggingSystem
)
{
public
LoggersEndpoint
loggersEndpoint
(
LoggingSystem
loggingSystem
)
{
return
new
LoggersEndpoint
(
loggingSystem
);
return
new
LoggersEndpoint
(
loggingSystem
);
}
}
static
class
OnEnabledLoggingSystemCondition
extends
SpringBootCondition
{
@Override
public
ConditionOutcome
getMatchOutcome
(
ConditionContext
context
,
AnnotatedTypeMetadata
metadata
)
{
ConditionMessage
.
Builder
message
=
ConditionMessage
.
forCondition
(
"Logging System"
);
String
loggingSystem
=
System
.
getProperty
(
LoggingSystem
.
SYSTEM_PROPERTY
);
if
(
LoggingSystem
.
NONE
.
equals
(
loggingSystem
))
{
return
ConditionOutcome
.
noMatch
(
message
.
because
(
"system property "
+
LoggingSystem
.
SYSTEM_PROPERTY
+
" is set to none"
));
}
return
ConditionOutcome
.
match
(
message
.
because
(
"enabled"
));
}
}
}
}
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/logging/LoggersEndpointAutoConfigurationTests.java
View file @
eba476ba
/*
/*
* Copyright 2012-201
7
the original author or authors.
* Copyright 2012-201
8
the original author or authors.
*
*
* Licensed under the Apache License, Version 2.0 (the "License");
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* you may not use this file except in compliance with the License.
...
@@ -53,6 +53,17 @@ public class LoggersEndpointAutoConfigurationTests {
...
@@ -53,6 +53,17 @@ public class LoggersEndpointAutoConfigurationTests {
.
doesNotHaveBean
(
LoggersEndpoint
.
class
));
.
doesNotHaveBean
(
LoggersEndpoint
.
class
));
}
}
@Test
public
void
runWithNoneLoggerEndpointShouldNotHaveEndpointBean
()
{
this
.
contextRunner
.
withSystemProperties
(
"org.springframework.boot.logging.LoggingSystem=none"
)
.
run
((
context
)
->
{
System
.
out
.
println
(
context
.
getBean
(
LoggingSystem
.
class
));
assertThat
(
context
)
.
doesNotHaveBean
(
LoggersEndpoint
.
class
);
});
}
@Configuration
@Configuration
static
class
LoggingConfiguration
{
static
class
LoggingConfiguration
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment