Commit ec72d287 authored by Phillip Webb's avatar Phillip Webb

Merge pull request #17040 from wonwoo

* pr/17040:
  Polish "Replace anonymous class with lambdas"
  Replace anonymous class with lambdas

Closes gh-17040
parents 0fcc5611 114f9f95
...@@ -68,7 +68,6 @@ import org.mockito.InOrder; ...@@ -68,7 +68,6 @@ import org.mockito.InOrder;
import org.springframework.boot.testsupport.rule.OutputCapture; import org.springframework.boot.testsupport.rule.OutputCapture;
import org.springframework.boot.web.server.WebServerException; import org.springframework.boot.web.server.WebServerException;
import org.springframework.boot.web.servlet.ServletContextInitializer;
import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactory; import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactory;
import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactoryTests; import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactoryTests;
import org.springframework.core.io.ByteArrayResource; import org.springframework.core.io.ByteArrayResource;
...@@ -538,25 +537,19 @@ public class TomcatServletWebServerFactoryTests ...@@ -538,25 +537,19 @@ public class TomcatServletWebServerFactoryTests
throws IOException, URISyntaxException { throws IOException, URISyntaxException {
TomcatServletWebServerFactory factory = new TomcatServletWebServerFactory(0); TomcatServletWebServerFactory factory = new TomcatServletWebServerFactory(0);
AtomicReference<ServletContext> servletContextReference = new AtomicReference<>(); AtomicReference<ServletContext> servletContextReference = new AtomicReference<>();
factory.addInitializers(new ServletContextInitializer() { factory.addInitializers((servletContext) -> {
servletContextReference.set(servletContext);
@Override Dynamic servlet = servletContext.addServlet("upload", new HttpServlet() {
public void onStartup(ServletContext servletContext) throws ServletException {
servletContextReference.set(servletContext); @Override
Dynamic servlet = servletContext.addServlet("upload", new HttpServlet() { protected void doPost(HttpServletRequest req, HttpServletResponse resp)
throws ServletException, IOException {
@Override req.getParts();
protected void doPost(HttpServletRequest req, }
HttpServletResponse resp)
throws ServletException, IOException {
req.getParts();
}
});
servlet.addMapping("/upload");
servlet.setMultipartConfig(new MultipartConfigElement((String) null));
}
});
servlet.addMapping("/upload");
servlet.setMultipartConfig(new MultipartConfigElement((String) null));
}); });
this.webServer = factory.getWebServer(); this.webServer = factory.getWebServer();
this.webServer.start(); this.webServer.start();
......
...@@ -25,7 +25,6 @@ import java.io.PrintWriter; ...@@ -25,7 +25,6 @@ import java.io.PrintWriter;
import java.net.InetSocketAddress; import java.net.InetSocketAddress;
import java.net.MalformedURLException; import java.net.MalformedURLException;
import java.net.ServerSocket; import java.net.ServerSocket;
import java.net.Socket;
import java.net.URI; import java.net.URI;
import java.net.URISyntaxException; import java.net.URISyntaxException;
import java.net.URL; import java.net.URL;
...@@ -75,8 +74,6 @@ import org.apache.http.conn.ssl.TrustSelfSignedStrategy; ...@@ -75,8 +74,6 @@ import org.apache.http.conn.ssl.TrustSelfSignedStrategy;
import org.apache.http.impl.client.HttpClientBuilder; import org.apache.http.impl.client.HttpClientBuilder;
import org.apache.http.impl.client.HttpClients; import org.apache.http.impl.client.HttpClients;
import org.apache.http.protocol.HttpContext; import org.apache.http.protocol.HttpContext;
import org.apache.http.ssl.PrivateKeyDetails;
import org.apache.http.ssl.PrivateKeyStrategy;
import org.apache.http.ssl.SSLContextBuilder; import org.apache.http.ssl.SSLContextBuilder;
import org.apache.http.ssl.TrustStrategy; import org.apache.http.ssl.TrustStrategy;
import org.apache.jasper.EmbeddedServletOptions; import org.apache.jasper.EmbeddedServletOptions;
...@@ -503,16 +500,7 @@ public abstract class AbstractServletWebServerFactoryTests { ...@@ -503,16 +500,7 @@ public abstract class AbstractServletWebServerFactoryTests {
new SSLContextBuilder() new SSLContextBuilder()
.loadTrustMaterial(null, new TrustSelfSignedStrategy()) .loadTrustMaterial(null, new TrustSelfSignedStrategy())
.loadKeyMaterial(keyStore, "secret".toCharArray(), .loadKeyMaterial(keyStore, "secret".toCharArray(),
new PrivateKeyStrategy() { (aliases, socket) -> "spring-boot")
@Override
public String chooseAlias(
Map<String, PrivateKeyDetails> aliases,
Socket socket) {
return "spring-boot";
}
})
.build()); .build());
HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory) HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory)
.build(); .build();
...@@ -538,15 +526,7 @@ public abstract class AbstractServletWebServerFactoryTests { ...@@ -538,15 +526,7 @@ public abstract class AbstractServletWebServerFactoryTests {
new SSLContextBuilder() new SSLContextBuilder()
.loadTrustMaterial(null, new TrustSelfSignedStrategy()) .loadTrustMaterial(null, new TrustSelfSignedStrategy())
.loadKeyMaterial(keyStore, "password".toCharArray(), .loadKeyMaterial(keyStore, "password".toCharArray(),
new PrivateKeyStrategy() { (aliases, socket) -> "spring-boot")
@Override
public String chooseAlias(
Map<String, PrivateKeyDetails> aliases,
Socket socket) {
return "spring-boot";
}
})
.build()); .build());
HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory) HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory)
.build(); .build();
...@@ -639,15 +619,7 @@ public abstract class AbstractServletWebServerFactoryTests { ...@@ -639,15 +619,7 @@ public abstract class AbstractServletWebServerFactoryTests {
new SSLContextBuilder() new SSLContextBuilder()
.loadTrustMaterial(null, new TrustSelfSignedStrategy()) .loadTrustMaterial(null, new TrustSelfSignedStrategy())
.loadKeyMaterial(keyStore, "password".toCharArray(), .loadKeyMaterial(keyStore, "password".toCharArray(),
new PrivateKeyStrategy() { (aliases, socket) -> "spring-boot")
@Override
public String chooseAlias(
Map<String, PrivateKeyDetails> aliases,
Socket socket) {
return "spring-boot";
}
})
.build()); .build());
HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory) HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory)
.build(); .build();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment