Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
edcaee37
Commit
edcaee37
authored
Sep 02, 2019
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Consider @Deprecated on field when determining property's deprecation
Fixes gh-17550
parent
4fd7b68f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
52 additions
and
1 deletion
+52
-1
ConfigurationMetadataAnnotationProcessor.java
...onprocessor/ConfigurationMetadataAnnotationProcessor.java
+2
-1
ConfigurationMetadataAnnotationProcessorTests.java
...cessor/ConfigurationMetadataAnnotationProcessorTests.java
+10
-0
DeprecatedFieldSingleProperty.java
...igurationsample/simple/DeprecatedFieldSingleProperty.java
+40
-0
No files found.
spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/main/java/org/springframework/boot/configurationprocessor/ConfigurationMetadataAnnotationProcessor.java
View file @
edcaee37
...
...
@@ -277,7 +277,8 @@ public class ConfigurationMetadataAnnotationProcessor extends AbstractProcessor
String
sourceType
=
this
.
typeUtils
.
getQualifiedName
(
element
);
String
description
=
this
.
typeUtils
.
getJavaDoc
(
field
);
Object
defaultValue
=
fieldValues
.
get
(
name
);
boolean
deprecated
=
isDeprecated
(
getter
)
||
isDeprecated
(
setter
)
||
isDeprecated
(
source
);
boolean
deprecated
=
isDeprecated
(
getter
)
||
isDeprecated
(
setter
)
||
isDeprecated
(
field
)
||
isDeprecated
(
source
);
this
.
metadataCollector
.
add
(
ItemMetadata
.
newProperty
(
prefix
,
name
,
dataType
,
sourceType
,
null
,
description
,
defaultValue
,
deprecated
?
getItemDeprecation
(
getter
)
:
null
));
}
...
...
spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationprocessor/ConfigurationMetadataAnnotationProcessorTests.java
View file @
edcaee37
...
...
@@ -69,6 +69,7 @@ import org.springframework.boot.configurationsample.method.InvalidMethodConfig;
import
org.springframework.boot.configurationsample.method.MethodAndClassConfig
;
import
org.springframework.boot.configurationsample.method.SimpleMethodConfig
;
import
org.springframework.boot.configurationsample.simple.ClassWithNestedProperties
;
import
org.springframework.boot.configurationsample.simple.DeprecatedFieldSingleProperty
;
import
org.springframework.boot.configurationsample.simple.DeprecatedSingleProperty
;
import
org.springframework.boot.configurationsample.simple.DescriptionProperties
;
import
org.springframework.boot.configurationsample.simple.HierarchicalProperties
;
...
...
@@ -224,6 +225,15 @@ public class ConfigurationMetadataAnnotationProcessorTests {
.
withDeprecation
(
"renamed"
,
"singledeprecated.new-name"
));
}
@Test
public
void
singleDeprecatedFieldProperty
()
{
Class
<?>
type
=
DeprecatedFieldSingleProperty
.
class
;
ConfigurationMetadata
metadata
=
compile
(
type
);
assertThat
(
metadata
).
has
(
Metadata
.
withGroup
(
"singlefielddeprecated"
).
fromSource
(
type
));
assertThat
(
metadata
).
has
(
Metadata
.
withProperty
(
"singlefielddeprecated.name"
,
String
.
class
).
fromSource
(
type
)
.
withDeprecation
(
null
,
null
));
}
@Test
public
void
deprecatedOnUnrelatedSetter
()
{
Class
<?>
type
=
DeprecatedUnrelatedMethodPojo
.
class
;
...
...
spring-boot-project/spring-boot-tools/spring-boot-configuration-processor/src/test/java/org/springframework/boot/configurationsample/simple/DeprecatedFieldSingleProperty.java
0 → 100644
View file @
edcaee37
/*
* Copyright 2012-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package
org
.
springframework
.
boot
.
configurationsample
.
simple
;
import
org.springframework.boot.configurationsample.ConfigurationProperties
;
/**
* Configuration properties with a single deprecated element.
*
* @author Andy Wilkinson
*/
@ConfigurationProperties
(
"singlefielddeprecated"
)
public
class
DeprecatedFieldSingleProperty
{
@Deprecated
private
String
name
;
public
String
getName
()
{
return
this
.
name
;
}
public
void
setName
(
String
name
)
{
this
.
name
=
name
;
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment