Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
f7127e55
Commit
f7127e55
authored
May 23, 2017
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Ensure that closing a JarFile closes all underlying resources
Closes gh-8871
parent
50876382
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
1 deletion
+11
-1
JarFile.java
...ain/java/org/springframework/boot/loader/jar/JarFile.java
+1
-0
JarFileTests.java
...ava/org/springframework/boot/loader/jar/JarFileTests.java
+10
-1
No files found.
spring-boot-tools/spring-boot-loader/src/main/java/org/springframework/boot/loader/jar/JarFile.java
View file @
f7127e55
...
@@ -298,6 +298,7 @@ public class JarFile extends java.util.jar.JarFile {
...
@@ -298,6 +298,7 @@ public class JarFile extends java.util.jar.JarFile {
@Override
@Override
public
void
close
()
throws
IOException
{
public
void
close
()
throws
IOException
{
super
.
close
();
this
.
rootFile
.
close
();
this
.
rootFile
.
close
();
}
}
...
...
spring-boot-tools/spring-boot-loader/src/test/java/org/springframework/boot/loader/jar/JarFileTests.java
View file @
f7127e55
/*
/*
* Copyright 2012-201
6
the original author or authors.
* Copyright 2012-201
7
the original author or authors.
*
*
* Licensed under the Apache License, Version 2.0 (the "License");
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* you may not use this file except in compliance with the License.
...
@@ -469,4 +469,13 @@ public class JarFileTests {
...
@@ -469,4 +469,13 @@ public class JarFileTests {
}
}
}
}
@Test
public
void
jarFileCanBeDeletedOnceItHasBeenClosed
()
throws
Exception
{
File
temp
=
this
.
temporaryFolder
.
newFile
();
TestJarCreator
.
createTestJar
(
temp
);
JarFile
jf
=
new
JarFile
(
temp
);
jf
.
close
();
assertThat
(
temp
.
delete
()).
isTrue
();
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment