Commit feb2452f authored by Phillip Webb's avatar Phillip Webb

Simplify WebApplicationContext class guard

See gh-3856
parent cb4e709b
...@@ -20,6 +20,7 @@ import org.springframework.beans.factory.annotation.Autowired; ...@@ -20,6 +20,7 @@ import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.CommandLineRunner; import org.springframework.boot.CommandLineRunner;
import org.springframework.boot.SpringApplication; import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication; import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
import sample.simple.service.HelloWorldService; import sample.simple.service.HelloWorldService;
...@@ -39,6 +40,9 @@ public class SampleSimpleApplication implements CommandLineRunner { ...@@ -39,6 +40,9 @@ public class SampleSimpleApplication implements CommandLineRunner {
} }
public static void main(String[] args) throws Exception { public static void main(String[] args) throws Exception {
SpringApplication application = new SpringApplication(
SampleSimpleApplication.class);
application.setApplicationContextClass(AnnotationConfigApplicationContext.class);
SpringApplication.run(SampleSimpleApplication.class, args); SpringApplication.run(SampleSimpleApplication.class, args);
} }
} }
...@@ -227,12 +227,21 @@ public class SpringApplication { ...@@ -227,12 +227,21 @@ public class SpringApplication {
if (sources != null && sources.length > 0) { if (sources != null && sources.length > 0) {
this.sources.addAll(Arrays.asList(sources)); this.sources.addAll(Arrays.asList(sources));
} }
this.webEnvironment = isSpringWebAvailable(); this.webEnvironment = deduceWebEnvironment();
setInitializers((Collection) getSpringFactoriesInstances(ApplicationContextInitializer.class)); setInitializers((Collection) getSpringFactoriesInstances(ApplicationContextInitializer.class));
setListeners((Collection) getSpringFactoriesInstances(ApplicationListener.class)); setListeners((Collection) getSpringFactoriesInstances(ApplicationListener.class));
this.mainApplicationClass = deduceMainApplicationClass(); this.mainApplicationClass = deduceMainApplicationClass();
} }
private boolean deduceWebEnvironment() {
for (String className : WEB_ENVIRONMENT_CLASSES) {
if (!ClassUtils.isPresent(className, null)) {
return false;
}
}
return true;
}
private Class<?> deduceMainApplicationClass() { private Class<?> deduceMainApplicationClass() {
try { try {
StackTraceElement[] stackTrace = new RuntimeException().getStackTrace(); StackTraceElement[] stackTrace = new RuntimeException().getStackTrace();
...@@ -864,12 +873,20 @@ public class SpringApplication { ...@@ -864,12 +873,20 @@ public class SpringApplication {
public void setApplicationContextClass( public void setApplicationContextClass(
Class<? extends ConfigurableApplicationContext> applicationContextClass) { Class<? extends ConfigurableApplicationContext> applicationContextClass) {
this.applicationContextClass = applicationContextClass; this.applicationContextClass = applicationContextClass;
if (!isSpringWebAvailable() || !WebApplicationContext.class.isAssignableFrom( if (!isWebApplicationContext(applicationContextClass)) {
applicationContextClass)) {
this.webEnvironment = false; this.webEnvironment = false;
} }
} }
private boolean isWebApplicationContext(Class<?> applicationContextClass) {
try {
return WebApplicationContext.class.isAssignableFrom(applicationContextClass);
}
catch (NoClassDefFoundError ex) {
return false;
}
}
/** /**
* Sets the {@link ApplicationContextInitializer} that will be applied to the Spring * Sets the {@link ApplicationContextInitializer} that will be applied to the Spring
* {@link ApplicationContext}. * {@link ApplicationContext}.
...@@ -928,15 +945,6 @@ public class SpringApplication { ...@@ -928,15 +945,6 @@ public class SpringApplication {
return asUnmodifiableOrderedSet(this.listeners); return asUnmodifiableOrderedSet(this.listeners);
} }
private boolean isSpringWebAvailable() {
for (String className : WEB_ENVIRONMENT_CLASSES) {
if (!ClassUtils.isPresent(className, null)) {
return false;
}
}
return true;
}
/** /**
* Static helper that can be used to run a {@link SpringApplication} from the * Static helper that can be used to run a {@link SpringApplication} from the
* specified source using default settings. * specified source using default settings.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment