- 14 Jul, 2020 6 commits
-
-
Andy Wilkinson authored
* gh-22112: Cleanup temporary files after Maven plugin execution Closes gh-22112
-
dreis2211 authored
See gh-22112
-
Andy Wilkinson authored
* gh-22294: Reduce started threads in OnClassCondition Closes gh-22294
-
dreis2211 authored
Prior to this commit, OnClassCondition started a thread even if the number of passed autoconfiguration class candidates never exceeded 1. This commit only starts a thread if there is actually work to split in half. See gh-22294
-
Andy Wilkinson authored
Closes gh-22325
-
Andy Wilkinson authored
Previously, regular bean definitions for configuration properties classes that attempt to use constructor binding were detected in a bean factory post-processor, ConfigurationPropertiesBeanDefinitionValidator. This validation examined every standard bean definition and failed if it encountered one for a class that should have used constructor binding. There were two downsides to this approach: 1. Reflection used to identify if the bean should be using constructor binding triggered class loading that could prevent subsequent instrumentation by a load-time weaver. 2. The cost of the validation was incurred when there was no misconfiguration to report. This commit replaces ConfigurationPropertiesBeanDefinitionValidator with a failure analyzer. This failure analyzer only runs once a failure has occurred and the application context is not going to complete refresh. This avoids causing problems with subsequent instrumentation and also avoids the cost of validation and error reporting unless there is an error. Fixes gh-20798
-
- 13 Jul, 2020 1 commit
-
-
Andy Wilkinson authored
Closes gh-22277
-
- 10 Jul, 2020 1 commit
-
-
Andy Wilkinson authored
Fixes gh-22300
-
- 09 Jul, 2020 10 commits
-
-
Andy Wilkinson authored
Closes gh-22292
-
Andy Wilkinson authored
Closes gh-22290
-
Andy Wilkinson authored
Closes gh-22288
-
Andy Wilkinson authored
Previously, the tests used absolute values to verify that the work had completed sufficiently quickly. This led to flaky tests in environments where the performance can be variable such as CI. This commit tries to make the tests more robust by comparing the performance to a baseline and requiring it to be twice as fast. Closes gh-22137
-
Andy Wilkinson authored
Previously, spring-boot-docs used the java-base-plugin and then added configuration on top. This has proven to be error prone, with the most recent problem being that the tests were not being compiled and run. This commit changes approach and applies the java plugin to the project instead of the java-base plugin. Now, rather than adding the necessary configuration to the base, the unwanted pieces of the java plugin's configuration – specifically the jar and javadoc tasks – are disabled instead. The DeployedPlugin has also been updated so that it does not create a publication from the java component for projects that have a disabled jar task. Closes gh-22284
-
Andy Wilkinson authored
Closes gh-22282
-
Andy Wilkinson authored
Fixes gh-22275
-
Andy Wilkinson authored
Closes gh-22268
-
Andy Wilkinson authored
Closes gh-22269
-
Andy Wilkinson authored
Closes gh-22271
-
- 08 Jul, 2020 4 commits
-
-
Scott Frederick authored
This commit improves the validation of URLs provided in the property 'spring.redis.url' used to auto-configure a Spring Data Redis connection. In particular, only the URL schemes 'redis://' and 'rediss://' are allowed, and any other scheme will result in a configuration error. A failure analyzer is also provided to improve diagnostics for common mis-configurations detected by this validation. Fixes gh-21999
-
Andy Wilkinson authored
Closes gh-22264
-
Andy Wilkinson authored
Closes gh-22262
-
Andy Wilkinson authored
Previously, the import selector for `@ImportAutoConfiguration` did not consider the spring.autoconfigure.exclude property when determining which auto-configurations to exclude. This meant that tests using a slice that included a particular auto-configuration would include it even if the application's configuration excluded it via spring.autoconfigure.exclude. Confusingly, this could result in a sliced test using an auto-configuration that would be excluded in a broader `@SpringBootTest`. This commit updates the ImportAutoConfigurationImportSelector to consider the spring.autoconfigure.exclude property so that sliced tests will use a subset of the auto-configurations that a `@SpringBootTest` would use. Fixes gh-21736
-
- 07 Jul, 2020 14 commits
-
-
Andy Wilkinson authored
Fixes gh-22233
-
Andy Wilkinson authored
Closes gh-22251
-
Andy Wilkinson authored
Closes gh-22231
-
Andy Wilkinson authored
Closes gh-22249
-
Andy Wilkinson authored
Closes gh-22248
-
Andy Wilkinson authored
Fixes gh-22169
-
Andy Wilkinson authored
Closes gh-22246
-
Andy Wilkinson authored
* gh-22207: Polish "Rename NoneOfNestedConditions to NoneNestedConditions in example docs" Rename NoneOfNestedConditions to NoneNestedConditions in example docs Closes gh-22207
-
Andy Wilkinson authored
See gh-22207
-
Clayton Walker authored
See gh-22207
-
Andy Wilkinson authored
Closes gh-22243
-
Andy Wilkinson authored
* gh-22214: Polish "Fix unwrapping of captured PrintStream in test support's OutputCapture" Fix unwrapping of captured PrintStream in test support's OutputCapture Closes gh-22214
-
Andy Wilkinson authored
See gh-22214
-
XenoAmess authored
See gh-22214
-
- 06 Jul, 2020 4 commits
-
-
Andy Wilkinson authored
Fixes gh-22225
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Closes gh-22234
-
Andy Wilkinson authored
Since Spring Framework 4.3.0.RC2, a default embedded value resolver has been registered with the bean factory when one is not otherwise configured. This meant that placeholders in `@Value` would be resolved with or without PropertyPlaceholderAutoConfiguration defining a PropertySourcesPlaceholderConfigurer bean. However, placeholders in bean definitions would only be resolved if a PropertySourcesPlaceholderConfigurer was defined. This commit updates PropertyPlaceholderAutoConfigurationTests to align with this change in Framework. We now test that placeholders are resolved in `@Value` annotations with or without the auto-configuration and that placeholders in bean definitions are only resolved with the auto-configured. Closes gh-22230
-