- 14 Apr, 2015 4 commits
-
-
Andy Wilkinson authored
Previously, if a call to doFilter in MetricFilter failed (i.e. it threw an exception), it would be handled as if it had a response status of 200. This is because the servlet container was yet to handle the exception and set the response status to 500. This commit updates MetricFilter to assume that an exception thrown from doFilter will result in a response with a status of 500. Strictly speaking, even though the filter has highest precedence and will therefore run last on the way back out, this may not always be the case. For example, a custom Tomcat Valve could handle the exception and result in a 200 response but that’s an edge case that’s into shooting yourself in the foot territory. Closes gh-2818
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Hibernate depends on antlr:antlr:2.7.7 (the latest version on Antlr 2) and fails with earlier 2.7.x versions due to a missing method. This can cause problems for Maven users if they also depend on something that pulls in an earlier version of Antlr, such as spring-boot-starter-velocity. Gradle users are unaffected as, when multiple versions of a dependency are found in the graph, Gradle will choose the latest version. This commit adds dependency management for antlr:antlr:2.7.7 to ensure that the latest, and Hibernate compatible, version of Antlr 2 is used. Closes gh-2814
-
Stephane Nicoll authored
-
- 13 Apr, 2015 2 commits
-
-
Phillip Webb authored
Include getters and setters with the sample class. Fixes gh-2813
-
Stephane Nicoll authored
-
- 09 Apr, 2015 3 commits
-
-
Phillip Webb authored
-
Dave Syer authored
When reverse==false we have to be careful to remove the right element when capacity is reached.
-
Dave Syer authored
Default to true (so existing apps change their behaviour, but that seems to be the majority vote). Fixes gh-2794
-
- 08 Apr, 2015 4 commits
-
-
izeye authored
Previously GsonHttpMessageConvertersConfiguration was unconditional with its nested configuration class being @ConditionalOnClass(Gson.class). This led to the unnecessary registration of the GsonHttpMessageConvertersConfiguration bean when Gson isn't on the classpath. This commit moves the condition up onto the outer class so that no Gson-related beans are created when Gson is not on the classpath. Closes gh-2778
-
Andy Wilkinson authored
Closes gh-2788
-
Andy Wilkinson authored
Closes gh-2787 (I hope)
-
Andy Wilkinson authored
This commit improves upon the changes made in a8bf9d34 by adding support for relaxed binding of the endpoints.enabled and endpoints.<name>.enabled properties. This is achieved by replacing use of @ConditionalOnExpression (which does not support relaxed binding) with a custom condition implementation that uses RelaxedPropertyResolver. Closes gh-2767
-
- 07 Apr, 2015 8 commits
-
-
izeye authored
Closes gh-2779
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Previously, only invocations of /metricName/ would honour the enabled property and return a not found (404) response. For endpoints which support nested paths, access to /metricName/foo would ignore the enabled flag and return an OK (200) response. Furthermore, there was a comment in EndpointMvcAdapter that suggested that an endpoint shouldn’t be called when it is disabled, however this was not the case. This commit updates EndpointWebMvcAutoConfiguration and JolokiaAutoConfiguration to only register their MvcEndpoint beans if the underlying endpoint is enabled. This means that an EndpointMvcAdapter should not be called if its delegate is disabled, making the comment described above accurate. The check for the delegate being enabled has been retained so as not to rely upon the auto-configurations’ behaviour. The methods which handle nested paths (MetricsMvcEndpoint.value() and EnvironmentMvcEndpoint.value()) have been updated to add the same check for the enablement of their delegate. Fixes gh-2767
-
Andy Wilkinson authored
See gh-2776
-
Andy Wilkinson authored
Closes gh-2776
-
Andy Wilkinson authored
Closes gh-2782
-
Andy Wilkinson authored
Closes gh-2781
-
Andy Wilkinson authored
Closes gh-2775
-
- 03 Apr, 2015 1 commit
-
-
Stephane Nicoll authored
Initial update to the documentation to mention how a 3rd party starter should be named. The current doc sends a completely inconsistent message to what we actually intend. See gh-2537
-
- 31 Mar, 2015 6 commits
-
-
Phillip Webb authored
Conflicts: pom.xml spring-boot-actuator/pom.xml spring-boot-autoconfigure/pom.xml spring-boot-cli/pom.xml spring-boot-dependencies/pom.xml spring-boot-docs/pom.xml spring-boot-full-build/pom.xml spring-boot-integration-tests/pom.xml spring-boot-integration-tests/spring-boot-gradle-tests/pom.xml spring-boot-integration-tests/spring-boot-security-tests/pom.xml spring-boot-integration-tests/spring-boot-security-tests/spring-boot-security-tests-web-helloworld/pom.xml spring-boot-parent/pom.xml spring-boot-samples/pom.xml spring-boot-samples/spring-boot-sample-actuator-log4j/pom.xml spring-boot-samples/spring-boot-sample-actuator-noweb/pom.xml spring-boot-samples/spring-boot-sample-actuator-ui/pom.xml spring-boot-samples/spring-boot-sample-actuator/build.gradle spring-boot-samples/spring-boot-sample-actuator/build.xml spring-boot-samples/spring-boot-sample-actuator/pom.xml spring-boot-samples/spring-boot-sample-amqp/pom.xml spring-boot-samples/spring-boot-sample-aop/pom.xml spring-boot-samples/spring-boot-sample-batch/pom.xml spring-boot-samples/spring-boot-sample-data-elasticsearch/pom.xml spring-boot-samples/spring-boot-sample-data-gemfire/pom.xml spring-boot-samples/spring-boot-sample-data-jpa/pom.xml spring-boot-samples/spring-boot-sample-data-mongodb/pom.xml spring-boot-samples/spring-boot-sample-data-redis/pom.xml spring-boot-samples/spring-boot-sample-data-rest/pom.xml spring-boot-samples/spring-boot-sample-data-solr/pom.xml spring-boot-samples/spring-boot-sample-flyway/pom.xml spring-boot-samples/spring-boot-sample-hateoas/pom.xml spring-boot-samples/spring-boot-sample-hornetq/pom.xml spring-boot-samples/spring-boot-sample-integration/pom.xml spring-boot-samples/spring-boot-sample-jetty/pom.xml spring-boot-samples/spring-boot-sample-liquibase/pom.xml spring-boot-samples/spring-boot-sample-parent-context/pom.xml spring-boot-samples/spring-boot-sample-profile/build.gradle spring-boot-samples/spring-boot-sample-profile/pom.xml spring-boot-samples/spring-boot-sample-secure/pom.xml spring-boot-samples/spring-boot-sample-servlet/pom.xml spring-boot-samples/spring-boot-sample-simple/build.gradle spring-boot-samples/spring-boot-sample-simple/pom.xml spring-boot-samples/spring-boot-sample-tomcat-jsp/pom.xml spring-boot-samples/spring-boot-sample-tomcat-multi-connectors/pom.xml spring-boot-samples/spring-boot-sample-tomcat-ssl/pom.xml spring-boot-samples/spring-boot-sample-tomcat/pom.xml spring-boot-samples/spring-boot-sample-traditional/pom.xml spring-boot-samples/spring-boot-sample-velocity/pom.xml spring-boot-samples/spring-boot-sample-web-freemarker/pom.xml spring-boot-samples/spring-boot-sample-web-groovy-templates/pom.xml spring-boot-samples/spring-boot-sample-web-jsp/pom.xml spring-boot-samples/spring-boot-sample-web-method-security/pom.xml spring-boot-samples/spring-boot-sample-web-secure-custom/pom.xml spring-boot-samples/spring-boot-sample-web-secure-jdbc/pom.xml spring-boot-samples/spring-boot-sample-web-secure/pom.xml spring-boot-samples/spring-boot-sample-web-static/build.gradle spring-boot-samples/spring-boot-sample-web-static/pom.xml spring-boot-samples/spring-boot-sample-web-ui/build.gradle spring-boot-samples/spring-boot-sample-web-ui/pom.xml spring-boot-samples/spring-boot-sample-web-velocity/pom.xml spring-boot-samples/spring-boot-sample-websocket-tomcat/pom.xml spring-boot-samples/spring-boot-sample-ws/pom.xml spring-boot-samples/spring-boot-sample-xml/pom.xml spring-boot-starters/pom.xml spring-boot-starters/spring-boot-starter-actuator/pom.xml spring-boot-starters/spring-boot-starter-amqp/pom.xml spring-boot-starters/spring-boot-starter-aop/pom.xml spring-boot-starters/spring-boot-starter-batch/pom.xml spring-boot-starters/spring-boot-starter-data-elasticsearch/pom.xml spring-boot-starters/spring-boot-starter-data-gemfire/pom.xml spring-boot-starters/spring-boot-starter-data-jpa/pom.xml spring-boot-starters/spring-boot-starter-data-mongodb/pom.xml spring-boot-starters/spring-boot-starter-data-rest/pom.xml spring-boot-starters/spring-boot-starter-data-solr/pom.xml spring-boot-starters/spring-boot-starter-freemarker/pom.xml spring-boot-starters/spring-boot-starter-groovy-templates/pom.xml spring-boot-starters/spring-boot-starter-hornetq/pom.xml spring-boot-starters/spring-boot-starter-integration/pom.xml spring-boot-starters/spring-boot-starter-jdbc/pom.xml spring-boot-starters/spring-boot-starter-jetty/pom.xml spring-boot-starters/spring-boot-starter-log4j/pom.xml spring-boot-starters/spring-boot-starter-logging/pom.xml spring-boot-starters/spring-boot-starter-mobile/pom.xml spring-boot-starters/spring-boot-starter-parent/pom.xml spring-boot-starters/spring-boot-starter-redis/pom.xml spring-boot-starters/spring-boot-starter-remote-shell/pom.xml spring-boot-starters/spring-boot-starter-security/pom.xml spring-boot-starters/spring-boot-starter-social-facebook/pom.xml spring-boot-starters/spring-boot-starter-social-linkedin/pom.xml spring-boot-starters/spring-boot-starter-social-twitter/pom.xml spring-boot-starters/spring-boot-starter-test/pom.xml spring-boot-starters/spring-boot-starter-thymeleaf/pom.xml spring-boot-starters/spring-boot-starter-tomcat/pom.xml spring-boot-starters/spring-boot-starter-velocity/pom.xml spring-boot-starters/spring-boot-starter-web/pom.xml spring-boot-starters/spring-boot-starter-websocket/pom.xml spring-boot-starters/spring-boot-starter-ws/pom.xml spring-boot-starters/spring-boot-starter/pom.xml spring-boot-tools/pom.xml spring-boot-tools/spring-boot-dependency-tools/pom.xml spring-boot-tools/spring-boot-gradle-plugin/pom.xml spring-boot-tools/spring-boot-loader-tools/pom.xml spring-boot-tools/spring-boot-loader/pom.xml spring-boot-tools/spring-boot-maven-plugin/pom.xml spring-boot-versions/pom.xml spring-boot/pom.xml
-
Phillip Webb authored
-
Phillip Webb authored
-
Spring Buildmaster authored
-
Phillip Webb authored
This reverts commit 3a22443f.
-
Spring Buildmaster authored
-
- 30 Mar, 2015 9 commits
-
-
Phillip Webb authored
Add a note to the logging documentation to point out a potential gotcha. Fixes gh-2709
-
Dave Syer authored
The property in XADataSourceAutoConfigurationTests should be `data-source-class-name`. Previously the `-name` was missing.
-
Dave Syer authored
Update RelaxedDataBinder so that multiple overlapping nested property names can be bound to a Map. Prior to this commit, properties of the following form could not be bound to Maps: foo: baz foo.bar: spam This was due to BeanWrapperImpl throwing an InvalidPropertyException when binding `map[foo][bar]` because `foo` is already bound to `baz`. The updated code now detects such cases and instead uses the binding property `map[foo.bar]`. Fixes gh-2610
-
Phillip Webb authored
-
Phillip Webb authored
-
Marcin Zajączkowski authored
(cherry-picked from commit 99f1c7bf)
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Closes gh-2723
-
Andy Wilkinson authored
Tomcat uses the strings “on” and “off” to enable and disable compression. YAML interprets on as true and off as false, leaving ServerProperties.Tomcat.compression configured with “true” and “false” respectively. One solution is to use “on” rather than on and “off” rather than off in the YAML file but users may not realise that they need to do so. This commit updates the connector customiser that configures compression to map “true” to “on” and “false” to “off”. Closes gh-2737
-
- 26 Mar, 2015 3 commits
-
-
Andy Wilkinson authored
When configured with a context path of "", Undertow 1.1.3 changes the context path to be "/". The change [1] was made to fix UNDERTOW-350 [2]. [1] https://github.com/undertow-io/undertow/commit/3db7707b8b34095d8d2fafecf94a10d101c62320 [2] https://issues.jboss.org/browse/UNDERTOW-350 See gh-2732
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Closes gh-2670
-