- 17 Jun, 2016 1 commit
-
-
Andy Wilkinson authored
DevTools deliberately throws an uncaught exception on the main thread as a safe way of causing it to stop processing. This exception is caught and swallowed by an uncaught exception handler. Unfortunately, this has the unwanted side-effect of causing the JVM to exit with 1 once all running threads are daemons. Normally, this isn't a problem. Non-daemon threads, such as those started by an embedded servlet container, will keep the JVM alive and restarts of the application context will occur when the user makes to their application. However, if the user adds DevTools to an application that doesn't start any non-daemon threads, i.e. it starts, runs, and then exits, it will exit with 1. This causes both bootRun in Gradle and spring-boot:run in Maven to report that the build has failed. While there's no benefit to using DevTools with an application that behaves in this way, the side-effect of causing the JVM to exit with 1 is unwanted. This commit address the problem by updating the uncaught exception handler to call System.exit(0) if the JVM is going to exit as a result of the uncaught exception causing the main thread to die. In other words, if the main thread was the only non-daemon thread, its death as a result of the uncaught exception will now cause the JVM to exit with 1 rather than 0. If there are other non-daemon threads that will keep the JVM alive, the behaviour is unchanged. Closes gh-5968
-
- 16 Jun, 2016 2 commits
-
-
Stephane Nicoll authored
Closes gh-5653
-
Andy Wilkinson authored
Closes gh-6172
-
- 15 Jun, 2016 4 commits
-
-
Andy Wilkinson authored
Closes gh-5971
-
Andy Wilkinson authored
Closes gh-5956
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Closes gh-6160
-
- 14 Jun, 2016 2 commits
-
-
Stephane Nicoll authored
Closes gh-6165
-
Dave Syer authored
In fact the folder was already created if the app is running as a different user, but not if running as the current user, so it was just a question of moving one line out of an if block. Fixes gh-5986
-
- 11 Jun, 2016 4 commits
-
-
Phillip Webb authored
* 1.3.x-liquibase-endpoint: Close connection after use in LiquibaseEndpoint
-
Johannes Edmeier authored
Update LiquibaseEndpoint so that connections are closed and returned to the pool after use. Fixes gh-6118
-
Phillip Webb authored
Update SpringApplicationBuilder so that properties of the form `abc=d:e:f` are correctly parsed. Prior to this commit the `:` delimiter would always be chosen over `=`, even if `=` occurred first. Fixes gh-6121
-
Phillip Webb authored
Update TypeUtils to guard against the use of older Java versions. Both `Collection` and `Map` type lookups now fallback to generic free versions of the classes. Prior to this commit using `xmlbeans-maven-plugin` in combination with Spring Boot's annotation processor could result in `IllegalArgumentException: Incorrect number of type arguments`. Fixes gh-6122
-
- 10 Jun, 2016 3 commits
-
-
Phillip Webb authored
Update BeanDefinitionLoader to support loading from package names that do not contain dots. Prior to this commit `new BeanDefinitionLoader(registry, "somepackage")` would fail because "somepackage" exists and is a resource but does not contain valid XML. Somewhat surprisingly the InputStream returned by the resource actually contains the listing of files in the package. Fixes gh-6126
-
Ivan Sopov authored
Update BasicJsonParser to fix potential exceptions if strings happen to be empty. Fixes gh-6136
-
Phillip Webb authored
-
- 09 Jun, 2016 2 commits
-
-
Stephane Nicoll authored
* pr/6125: Update DataSourceBuilder aliases
-
Vedran Pavic authored
This commit adds a `user` alias for the `username` property which permits the use of `OracleDataSource`. Closes gh-6124, gh-6027, gh-6125
-
- 03 Jun, 2016 1 commit
-
-
Dave Syer authored
-
- 01 Jun, 2016 12 commits
-
-
Andy Wilkinson authored
Closes gh-6105
-
Andy Wilkinson authored
* gh-6056: Check factory method metadata to avoid NPE in devtools condition
-
Martin Lippert authored
Closes gh-6056
-
Andy Wilkinson authored
- Limit shared state between FileSystemWatcher and the watching thread - Use a private monitor rather than synchronizing on this - Use a Runnable implementation rather than subclassing Thread - Synchronize consistently when reading and writing state Closes gh-6039
-
Andy Wilkinson authored
Previously, JarURLConnection didn't override getPermission(). This meant that it required all permissions. This was at odds with the Oracle JVM's concrete sun.net.www.protocol.jar.JarURLConnection which overrides getPermission to return a FilePermission with the read action for the path of the underlying jar. This commit updates our JarURLConnection to align its behaviour with sun.net.www.protocol.jar.JarURLConnection. Closes gh-5411
-
Andy Wilkinson authored
This reverts commit 66e093ed. There's a regression [1] in Tomcat 8.0.35 that causes it to throw an NPE when it scans a jar file without a manifest. It's already been fixed [2]. See gh-6087 [1] https://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java?annotate=1742274#l369 [2] https://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java?annotate=1744197#l369
-
Andy Wilkinson authored
Closes gh-6090
-
Andy Wilkinson authored
Closes gh-6089
-
Andy Wilkinson authored
Closes gh-6088
-
Andy Wilkinson authored
Closes gh-6087
-
Andy Wilkinson authored
Closes gh-6086
-
Andy Wilkinson authored
Closes gh-6085
-
- 26 May, 2016 1 commit
-
-
Stephane Nicoll authored
Closes gh-6033
-
- 25 May, 2016 2 commits
-
-
Andy Wilkinson authored
The list of changes is written to on one thread and read from on another. Without some form of sychronization this is not thread-safe. This commit makes changes a synchronized list which should guarantee that the reading thread can see the changes made by the writing thread. It also removes a redundant call to clear the list of changes at the start of waitsForPollingInterval. See gh-6038
-
Andy Wilkinson authored
Closes gh-6036
-
- 24 May, 2016 1 commit
-
-
Andy Wilkinson authored
Neither Cassandra nor Elasticsearch starts reliably on Windows. This commit adds a custom class rule to the associated sample application tests to skip them on Windows. A class rule is used rather than a Unit assumption as we want to avoid starting Elasticsearch (done by the application context) and Cassandra (done by a test execution listener) and an assumption would be too late.
-
- 13 May, 2016 5 commits
-
-
Andy Wilkinson authored
Closes gh-5949
-
Andy Wilkinson authored
Closes gh-5947
-
Andy Wilkinson authored
Closes gh-5946
-
Andy Wilkinson authored
Closes gh-5945
-
Andy Wilkinson authored
Previously, arguments passed to the script were handled in one way if a service was being started using start-stop-daemon and in another way if start-stop-daemon wasn’t available or the application is being launched in run mode. This meant that quoted arguments were only handled correctly when the application was being started using start-stop-daemon. This commit updates the launch script so that argument handling is the same across all three different way that the application can be launched. Closes gh-5942
-