1. 27 Nov, 2019 1 commit
    • Madhura Bhave's avatar
      Clarify contradictory advice on the use of `@PropertySource` · 53da8da5
      Madhura Bhave authored
      In general we do not recommend using @PropertySource due to them being
      added to the environment too late for auto-configuration to use them. This
      commit updates the documentation to mention them in the list of external
      sources along with a note.
      
      Closes gh-18900
      53da8da5
  2. 26 Nov, 2019 1 commit
  3. 25 Nov, 2019 14 commits
  4. 22 Nov, 2019 2 commits
  5. 21 Nov, 2019 5 commits
  6. 20 Nov, 2019 4 commits
  7. 19 Nov, 2019 3 commits
  8. 16 Nov, 2019 2 commits
  9. 13 Nov, 2019 4 commits
  10. 12 Nov, 2019 1 commit
  11. 08 Nov, 2019 2 commits
    • Andy Wilkinson's avatar
      3f0367e2
    • Andy Wilkinson's avatar
      Allow 5 seconds for child to handle SIGINT before destroying it · 5765cfe0
      Andy Wilkinson authored
      Previously, when RunProcess handled a SIGINT it would immediately
      attempt to destroy the process that it had run. This created a race
      condition between the SIGINT being handled by the child process
      and RunProcess destroying the child. The exact behavior of destroy
      is implementation dependent and it may result in forcible termination
      of the process where shutdown hooks are not called. This is what
      happens on Windows. The exit code in such a case is 1 which prevents
      anything from waiting for the process to complete from detecting
      that it ended as a result of a SIGINT, leaving it with no choice but
      to report an error. This is what happens with mvn spring-boot:run
      with a forked process on Windows and results in the build failing.
      
      This commit updates RunProcess to allow the child process to handle
      the SIGINT itself, waiting for up to five seconds for that to happen
      before the process is then destroyed. Given this time, the child
      process exits with 130 which RunMojo already handles correctly as
      indicating that the process died due to SIGINT and the build completes
      with success as a result.
      
      Fixes gh-18936
      5765cfe0
  12. 07 Nov, 2019 1 commit
    • Andy Wilkinson's avatar
      Trim whitespace in BasicJsonParser · a11661d2
      Andy Wilkinson authored
      Previously, whitespace in between the keys and values in the JSON was
      not trimmed correctly in BasicJsonParser which lead to it incorrectly
      parsing JSON with whitespace between the opening of a list ([) and the
      opening of a map ({).
      
      This commit updates the parser to trim unwanted whitespace and adds a
      test to AbstractJsonParserTests to verify the whitespace handling
      behaviour across all JsonParser implementations.
      
      Closes gh-18911
      a11661d2