1. 10 Nov, 2015 20 commits
  2. 09 Nov, 2015 12 commits
  3. 08 Nov, 2015 2 commits
  4. 07 Nov, 2015 1 commit
  5. 06 Nov, 2015 5 commits
    • Phillip Webb's avatar
      Merge branch '1.2.x' · 4451df21
      Phillip Webb authored
      4451df21
    • Phillip Webb's avatar
      Polish · e06198e9
      Phillip Webb authored
      e06198e9
    • Phillip Webb's avatar
      Restore original embedded container shutdown order · f08f8727
      Phillip Webb authored
      Update EmbeddedWebApplicationContext so that the servlet container is
      shutdown after the context is closed. Unfortunately shutting the
      container down before the context has been closed causes exceptions if
      the `/shutdown` actuator endpoint is used. It can also cause the Tomcat
      classloader to throw IllegalStateExceptions if resources are accessed
      during shutdown.
      
      As this commit effectively reverts 0069e41c we need to fix the shutdown
      deadlock issue reported in gh-4130 in a different way. The deadlock can
      be caused when an incoming HTTP connection occurs whilst the context is
      closing. The incoming connection triggers the `FrameworkServlet` to
      call `initWebApplicationContext` which in turn calls `refresh`. The
      `FrameworkServlet` checks `ApplicationContext.isActive()` before
      performing an initialization but prior to this commit we would set
      active to `false` before stopping the servlet container. We now override
      `onClose` rather than `doClose` in `EmbeddedWebApplicationContext` to
      ensure that the active flag is only set to `false` once the servlet
      container has been stopped.
      
      See gh-4130
      Fixes gh-4396
      f08f8727
    • Stephane Nicoll's avatar
      Merge branch '1.2.x' · ce73dec9
      Stephane Nicoll authored
      ce73dec9
    • Stephane Nicoll's avatar
      Fix Maven/Gradle wrapper executable flag · 6d90188a
      Stephane Nicoll authored
      Spring Initalizr now bundles a wrapper script for the build system. While
      that wrapper has the necessary execute flag in the zip archive, that flag
      is lost as the zip abstraction does not honor those.
      
      The init command now makes sure to restore the execute flag on `mvnw`
      and `gradlew` if necessary.
      
      Unfortunately, this can't be tested as the Windows build would fail to
      assert that the executable flag has been propertly set.
      
      Closes gh-4392
      6d90188a