1. 21 Nov, 2019 2 commits
  2. 20 Nov, 2019 4 commits
  3. 19 Nov, 2019 3 commits
  4. 16 Nov, 2019 2 commits
  5. 13 Nov, 2019 4 commits
  6. 12 Nov, 2019 1 commit
  7. 08 Nov, 2019 2 commits
    • Andy Wilkinson's avatar
      3f0367e2
    • Andy Wilkinson's avatar
      Allow 5 seconds for child to handle SIGINT before destroying it · 5765cfe0
      Andy Wilkinson authored
      Previously, when RunProcess handled a SIGINT it would immediately
      attempt to destroy the process that it had run. This created a race
      condition between the SIGINT being handled by the child process
      and RunProcess destroying the child. The exact behavior of destroy
      is implementation dependent and it may result in forcible termination
      of the process where shutdown hooks are not called. This is what
      happens on Windows. The exit code in such a case is 1 which prevents
      anything from waiting for the process to complete from detecting
      that it ended as a result of a SIGINT, leaving it with no choice but
      to report an error. This is what happens with mvn spring-boot:run
      with a forked process on Windows and results in the build failing.
      
      This commit updates RunProcess to allow the child process to handle
      the SIGINT itself, waiting for up to five seconds for that to happen
      before the process is then destroyed. Given this time, the child
      process exits with 130 which RunMojo already handles correctly as
      indicating that the process died due to SIGINT and the build completes
      with success as a result.
      
      Fixes gh-18936
      5765cfe0
  8. 07 Nov, 2019 2 commits
    • Andy Wilkinson's avatar
      Trim whitespace in BasicJsonParser · a11661d2
      Andy Wilkinson authored
      Previously, whitespace in between the keys and values in the JSON was
      not trimmed correctly in BasicJsonParser which lead to it incorrectly
      parsing JSON with whitespace between the opening of a list ([) and the
      opening of a map ({).
      
      This commit updates the parser to trim unwanted whitespace and adds a
      test to AbstractJsonParserTests to verify the whitespace handling
      behaviour across all JsonParser implementations.
      
      Closes gh-18911
      a11661d2
    • Andy Wilkinson's avatar
      Fix @ServletComponentScan with a component index · d1ead884
      Andy Wilkinson authored
      Previously @ServletComponentScan did not work when there was a
      component index on the classpath as it made an assumption about
      the concrete type of the BeanDefinitions produced by scanning that
      does not hold true when an index is present.
      
      This commit updates the scanning and the handlers to correct the
      assumpution by working with a bean definition type that is produced
      by scanning both when there is and when there is not an index present.
      
      To prevent the problem from reoccuring, a test that uses and index
      has been added and the import of ScannedGenericBeanDefinition is now
      prohibited by Checkstyle.
      
      Closes gh-18910
      d1ead884
  9. 06 Nov, 2019 7 commits
  10. 05 Nov, 2019 13 commits
    • Andy Wilkinson's avatar
      Prevent recursive config props from causing a stack overflow · 59bc3c56
      Andy Wilkinson authored
      Previously, when the configuration properties annotation processor
      encountered a property that was the same as an outer type that had
      already been processed, it would fail with a stack overflow error.
      
      This commit introduces the use of a stack to track the types that
      have been processed. Types that have been seen before are skipped,
      thereby preventing a failure from occurring. We do not fail upon
      encountering a recursive type to allow metadata generation to
      complete. At runtime, the recursive property will not cause a problem
      if it is not bound.
      
      Fixes gh-18365
      59bc3c56
    • Andy Wilkinson's avatar
      Improve documentation on using Jersey alongside Spring MVC · 8b62f448
      Andy Wilkinson authored
      Previously, the documentation did not provide any guidance on using
      Jersey alongside Spring MVC or any other web framework.
      
      This improves the documentation in two ways:
      
      1. It notes that, in the presence of both Jersey and Spring MVC, the
         Actuator will prefer Spring MVC for exposing HTTP endpoints.
      2. It adds a how-to describing how to configure Jersey to forward
         requests for which it has no handler on to the rest of the filter
         chain. When Spring MVC is the other framework, this allows them to
         be handled by its dispatcher servlet.
      
      Closes gh-17523
      8b62f448
    • Andy Wilkinson's avatar
      Recommend more overrides when using starter parent · bd06a91a
      Andy Wilkinson authored
      This commit is a continuation of the work done in 987a5f81. In
      addition to developers and licenses that are covered in the earlier
      commit, a number of other settings are still inherited from the
      starter parent. This commit updates the documentation to show them
      being overridden as well.
      
      Closes gh-18532
      bd06a91a
    • Stephane Nicoll's avatar
      Merge pull request #18808 from markpollack · 9b3d625a
      Stephane Nicoll authored
      * pr/18808:
        Polish "Support amqps:// URIs in spring.rabbitmq.addresses"
        Support amqps:// URIs in spring.rabbitmq.addresses
      
      Closes gh-18808
      9b3d625a
    • Stephane Nicoll's avatar
      Polish "Support amqps:// URIs in spring.rabbitmq.addresses" · 4d1373c9
      Stephane Nicoll authored
      See gh-18808
      4d1373c9
    • Mark Pollack's avatar
      Support amqps:// URIs in spring.rabbitmq.addresses · 0fedb24c
      Mark Pollack authored
      See gh-18808
      Co-Authored-By: 's avatarBryan Kelly <xyloman@gmail.com>
      0fedb24c
    • Andy Wilkinson's avatar
      Honour EndpointFilter configured on an endpoint's superclass · ed50bf24
      Andy Wilkinson authored
      Previously, @EndpointFilter would only have an effect when used as
      an annotation or meta-annotation on the endpoint class itself. It
      would have no effect when used on a super-class of the endpoint
      bean's class.
      
      This commit updates EndpointDiscoverer so that an @EndpointFilter
      annotation or meta-annotation on a super-class will be found and
      applied to the discovery process. This is achieved by using find…
      rather than get… when retrieving the attributes for the EndpointFilter
      annotation.
      
      Fixes gh-17866
      ed50bf24
    • Andy Wilkinson's avatar
      cb76502a
    • Andy Wilkinson's avatar
      Clarify how to configure a Filter's order · 1c6f2af4
      Andy Wilkinson authored
      Closes gh-18266
      1c6f2af4
    • Andy Wilkinson's avatar
      Allow dependsOn relationships created by post-processor to be overridden · 69a95ce5
      Andy Wilkinson authored
      Previously, AbstractDependsOnBeanFactoryPostProcessor was unordered
      which meant that it was impossible to guarantee that another bean
      factory post-processor would run after it. This prevented overriding
      of the dependsOn relationships that is creates.
      
      This commit updates AbstractDependsOnBeanFactoryPostProcessor to give
      it a default order of zero. This will allow additional bean factory
      post-processors to be configured with a lower precedence order (values
      greater than 0) so that they run after any
      AbstractDependsOnBeanFactoryPostProcessor and can override the
      dependencies that it has configured.
      
      Fixes gh-18362
      69a95ce5
    • Andy Wilkinson's avatar
      Recommend overriding licences and developers when using starter parent · 987a5f81
      Andy Wilkinson authored
      Publishing to Maven Central requires spring-boot-starter-parent to
      declare its license and developers. When a user then uses
      spring-boot-starter-parent as their project's parent, these values
      are inherited and this is almost certainly unwanted.
      
      This commit updates the documentation to recommend and demonstrate
      overriding the license and developers that are inherited from the
      starter parent.
      
      Closes gh-18532
      987a5f81
    • Andy Wilkinson's avatar
      Document security risks of DevTools' remote support more clearly · 89e050d7
      Andy Wilkinson authored
      Previously, the security risks and our recommendations on how to
      mitigate them were not documented as clearly as they could have been.
      This commit makes some changes to try to address this:
      
      1. The security risk is now noted at the beginning of the section
      2. The recommendation to use SSL is now documented more prominently
         and an alternative recommendation to only use remote support on
         a trusted network has been added.
      3. The example secret has been removed to prevent copy and paste
      4. A recommendation to use a secret that is unique and strong has been
         added
      
      Closes gh-18825
      89e050d7
    • Stephane Nicoll's avatar
      Merge pull request #18870 from djarnis73 · c7801059
      Stephane Nicoll authored
      * pr/18870:
        Polish "Document Settings as jooq supported auto-configuration type"
        Document Settings as jooq supported auto-configuration type
      
      Closes gh-18870
      c7801059