- 12 Feb, 2016 5 commits
-
-
Stephane Nicoll authored
Previously, if one wants to create a custom `JmsListenerContainerFactory` or `RabbitListenerContainerFactory`, a bunch of code from the auto- configuration must be duplicated. This commit introduces two services to configure such factory for JMS and AMQP with the same sensible defaults that were applied by the auto-configufrations. Closes gh-5138
-
Andy Wilkinson authored
Previously, if an application had been started without remote debugging enabled, an attempt to connect to it via RemoteSpringApplication and the HTTP tunnel would result in the application being hammered by connection attempts for 30 seconds. This commit updates the tunnel server to respond with Service Unavailable (503) when a connection attempt is made and the JVM does not have remote debugging enabled. When the client receives a 503 response, it now logs a warning message describing the possible problem before closing the connection. The client has also been updated to provide improved diagnostics when a connection to the tunnel server cannot be established, for example because the remote URL is incorrect, or the remote application isn't running. Lastly, the client has been updated so that it continues to accept connections when a connection to the server is closed. This allows the user to correct a problem with the remote application, such as restarting it with remote debugging enabled, without having to also restart the process that's running RemoteSpringApplication. Closes gh-5021
-
Andy Wilkinson authored
Previously, WebRequestTraceFilter would call request.getParameterMap() before deciding whether or not the parameters should be included in the trace. For a POST request, this had the unwanted side-effect of always reading the request body. This commit updates WebRequestTraceFilter so that it checks that parameters are to be included in the trace before calling request.getParameterMap() Closes gh-5089
-
Andy Wilkinson authored
Closes gh-5122
-
Andy Wilkinson authored
-
- 11 Feb, 2016 10 commits
-
-
Andy Wilkinson authored
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Closes gh-5073
-
Stephane Nicoll authored
Closes gh-5131
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Previously an in-memory database that wasn’t pooled (an EmbeddedDatabase) would be shutdown when the context restarted, but an in-memory database wrapped in a connection pool was not. This meant that the former would be be wiped clean after each restart, whereas the latter would not. In addition to being inconsistent, this also caused problems with schema.sql and data.sql scripts when using DevTools. If you were using an in-memory database wrapped in a connection pool, a failure may occur during a restart as the scripts were not being run against in clean database. This commit adds an auto-configured bean to DevTools that, when the context is being closed, will execute “SHUTDOWN” if it identifies that the DataSource is not an EmbeddedDatabase and is for an in-memory database. Closes gh-4699
-
Stephane Nicoll authored
Also, the section on `server.*` configuration was poor so this commit also improves it. Closes gh-4989
-
Andy Wilkinson authored
Previously, WebSocketMessagingAutoConfiguration added a single additional converter. This was a MappingJackson2MessageConverter configured with the auto-configured ObjectMapper. AbstractMessageBrokerConfiguration places additional converters before any of the default converters. This meant that the auto-configuration had the unwanted side-effect of changing the ordering of the converters. A MappingJackson2MessageConverter was now first in the list, whereas, by default, it's last in the list after a StringMessageConverter and a ByteArrayMessageConverter. This commit updates WebSocketMessagingAutoConfiguration so that it switches off the registration of the default converters and registers a StringMessageConverter, ByteArrayMessageConverter and MappingJackson2MessageConverter in that order. A test has been added to verify that the types of these three converters match the types of the default converters. A second test that verifies that String responses are converted correctly has also been added alongside the existing test that verified the behaviour for JSON responses. Closes gh-5123
-
Stephane Nicoll authored
Closes gh-4936
-
Stephane Nicoll authored
When the `locations` attribute is set for a given bean annotated with `@ConfigurationProperties`, the configuration at these specified locations take precedence over any other property sources. This means that such values can't be overridden by a system property or a command line switch for instance. This commit clarifies this rules in the documentation. Closes gh-5111
-
- 10 Feb, 2016 4 commits
-
-
Stephane Nicoll authored
DriverClassNameProvider is unused but was probably restored by a merge commit at some point. It wasn't obvious and updated that class rather than `DatabaseDriver`. This commit updates `DatabaseDriver` and deletes `DriverClassNameProvider`. Closes gh-5076
-
Andy Wilkinson authored
Closes gh-5044
-
Andy Wilkinson authored
Closes gh-5108
-
Stephane Nicoll authored
Closes gh-5118
-
- 08 Feb, 2016 3 commits
-
-
Andy Wilkinson authored
* gh-5059: Remove Docker container after launch script test execution
-
Vedran Pavic authored
Closes gh-5059
-
Andy Wilkinson authored
Closes gh-5103
-
- 04 Feb, 2016 2 commits
-
-
Andy Wilkinson authored
Previously, BeanDefinitionLoader declared a field of type GroovyBeanDefinitionReader which is a GroovyObject subclass. This is problematic as BeanDefinitionLoader is always loaded but Groovy is an optional dependency. Even on a JVM where class verification is performed lazily, this can still cause problems if something reflectively tries to access the class’s declared fields. On a JVM where classes are verified at load time, it would be impossible to start a Spring Boot application without having Groovy on the classpath. This commit changes the field to be a BeanDefinitionReader, removing the indirect reference to GroovyObject form BeanDefinitionLoader’s signature. The reader is downcast to a GroovyBeanDefinitionReader in the body of a method body that will only be invoked when Groovy is on the classpath. Closes gh-5040
-
Phillip Webb authored
Update SpringBootJoranConfiguratorTests to ensure that logback is left in a sane state. Prior to this commit, running all tests in eclipse would fail due to ErrorPageFilterTests expecting specific log output.
-
- 02 Feb, 2016 3 commits
-
-
Karol Rynio authored
Closes gh-5025
-
Stephane Nicoll authored
Spring Boot fires event very early in the application lifecycle and we should make crystal clear that a regular `@Bean` registration cannot be used to register a listener on them. Closes gh-5061
-
Stephane Nicoll authored
-
- 29 Jan, 2016 1 commit
-
-
Andy Wilkinson authored
This commit enables the use of // @formatter:off and // @formatter:on to surround lines of code that should not be formatted. It also adds a code template that can be used to quickly wrap the selected lines of text with the off and on comments. Closes gh-5050
-
- 28 Jan, 2016 1 commit
-
-
Vedran Pavic authored
Closes gh-5041
-
- 24 Jan, 2016 2 commits
-
-
Stephane Nicoll authored
* pr/5013: Polish
-
Johnny Lim authored
Closes gh-5013
-
- 22 Jan, 2016 4 commits
-
-
Andy Wilkinson authored
Closes gh-4955
-
Phillip Webb authored
-
Spring Buildmaster authored
-
Phillip Webb authored
Since 2.2.5 hasn't yet been released we'll need to rollback for our release. See gh-4789
-
- 21 Jan, 2016 5 commits
-
-
Phillip Webb authored
Update the ContextIdApplicationContextInitializer default NAME_PATTERN to favor the developer defined `${spring.application.name}` value over the deployer defined `${vcap.application.name}`. Fixes gh-4926
-
Phillip Webb authored
Update TomcatEmbeddedServletContainerFactory so that logic to disable persistent sessions happens after Tomcat's standard Manager creation logic. Fixes gh-4543
-
Phillip Webb authored
Update `ResourceBundleCondition` to only enable the messages source if `messages.properties` (and not `messages*.properties`) exists. This operation is much faster that performing a pattern match since a full jar entry scan is not required. Since adding `messages.properties` is good practice and this change allows us to delete the custom `PathMatchingResourcePatternResolver` it seems like a fine compromise to make. Fixes gh-4930 See gh-4811
-
Phillip Webb authored
-
Andy Wilkinson authored
Closes gh-5003
-