- 28 Feb, 2017 4 commits
-
-
Phillip Webb authored
-
Phillip Webb authored
Rework Spring MVC JSR-303 validation support a little more to move most of the creation logic to the wrapper class. Also rename `SpringValidatorAdapterWrapper` -> `WebMvcValidator`. See gh-8223
-
Phillip Webb authored
Update MultipartAutoConfigurationTests to reset the Tomcat URL factory.
-
Phillip Webb authored
-
- 27 Feb, 2017 5 commits
-
-
Phillip Webb authored
-
Phillip Webb authored
-
Phillip Webb authored
Update Microsoft SQL Server detection logic to retain "SQL SERVER" support (just in case the server string is driver specific). See gh-8222
-
Stephane Nicoll authored
This commit improves the initial solution by actually overriding the `mvcValidator` `@Bean`. This gives us more control as whether a custom validator has been specified or not. We now wrap it regardless of it being custom or provided by auto-configuration. Closes gh-8223
-
Stephane Nicoll authored
`MethodValidationPostProcessor` requires a `Validator` so we need to flag it as an infrastructure bean to prevent an additional log that indicates it won't be post-processed. We obviously don't want to post-process the `Validator` here so adding the additional meta-data is a good idea anyway. Closes gh-8422
-
- 26 Feb, 2017 1 commit
-
-
Stephane Nicoll authored
Closes gh-8412
-
- 24 Feb, 2017 1 commit
-
-
Stephane Nicoll authored
This commit makes sure that the Spring `Validator` used by the MVC layer doesn't expose a JSR-303 contract, if any. The default implementation of the `mvcValidator` is `LocalValidatorFactoryBean`. While this object is exposed as a Spring `Validator` only, its runtime capabilities expose that contract as well as the standard `Validator` and `ValidatorFactory` ones. Concretely, if an auto-configuration is checking if a `javax.validation.Validator` bean is missing, the condition will match since we only know about "advertized types": beans haven't been created yet so we can't inspect their runtime capabilities. Since the condition match, we will auto-configure a bean. At runtime though, we're no longer ale to inject a `javax.validation.Validator` by type since two candidates are available. This commit introduces `SpringValidatorAdapterWrapper`, a wrapper class on any `SpringValidatorAdapter` (`LocalValidatorFactoryBean` being one of the available implementations) that only exposes the Spring contract. Also, if a `javax.validation.Validator` bean is available, we will use it for the MVC layer, rather than creating a new one. Closes gh-8223
-
- 22 Feb, 2017 25 commits
-
-
Andy Wilkinson authored
Closes gh-8374
-
Andy Wilkinson authored
Closes gh-8373
-
Andy Wilkinson authored
Closes gh-8372
-
Andy Wilkinson authored
Closes gh-8371
-
Andy Wilkinson authored
Closes gh-8370
-
Andy Wilkinson authored
Closes gh-8369
-
Andy Wilkinson authored
Closes gh-8368
-
Andy Wilkinson authored
- Apply standard code formatting - Add class javadoc to MultipleResourceServerConfigurationTests - Add missing @Override annotations - Remove unused ExpectedException field - Remove use of SpringApplicationBuilder from the tests - Use @ImportAutoConfiguration to import auto-configuration - Add assertions to verify that the orders haven't been changed - Remove unnecessary mocking of EmbeddedServletContainerFactory See gh-8347
-
Andy Wilkinson authored
-
Andy Wilkinson authored
In Logback 1.1.10, the logback-classic module contains a META-INF/services/javax.servlet.ServletContainerInitializer file that contains a comment. This triggers a bug in Wildfly 8 [1] that has been fixed [2] in Wildfly 9 and later. As a result, this commit also updates our Wildfly deployment test to use 9.0.2 rather than 8.2.0. Closes gh-8354 [1] https://issues.jboss.org/browse/WFLY-4089 [2] https://github.com/wildfly/wildfly/commit/fef57ebdc7f93fe975d9234dd86265b79d705ce2
-
Dave Syer authored
Fixes gh-8347
-
Andy Wilkinson authored
-
Andy Wilkinson authored
This reverts commit 05113d05. See gh-8354
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Closes gh-8364
-
Andy Wilkinson authored
Closes gh-8363
-
Andy Wilkinson authored
Closes gh-8362
-
Andy Wilkinson authored
Closes gh-8361
-
Andy Wilkinson authored
Closes gh-8360
-
Andy Wilkinson authored
Closes gh-8359
-
Andy Wilkinson authored
Closes gh-8358
-
Andy Wilkinson authored
Closes gh-8357
-
Andy Wilkinson authored
Closes gh-8356
-
Andy Wilkinson authored
Closes gh-8355
-
Andy Wilkinson authored
Closes gh-8354
-
- 21 Feb, 2017 4 commits
-
-
Andy Wilkinson authored
-
Andy Wilkinson authored
Previously, @SpyBean's name attribute was not used when determining the name of the bean to spy upon. When there were multiple candidates, none of which were primary, this would lead to a failure to find the bean to spy upon. This behaviour is also inconsistent with @MockBean which does use the name attribute to identify the bean to mock. This commit updates MockitoPostProcessor to use the name attribute, when set, to identify the bean that should be spied upon. For consistency with @MockBean it is always used when set. When not set the previous logic will continue to be used. Closes gh-8315
-
Madhura Bhave authored
Closes gh-8350
-
Andy Wilkinson authored
-