• Andy Wilkinson's avatar
    Don’t call ignoring.antMatchers([]) as empty array now maps to /** · 02d7e282
    Andy Wilkinson authored
    Previously, if security.ignored was set to none and the error controller
    was disabled, there would be no paths to ignore and we would call
    IgnoredRequestConfigurer.antMatchers with an empty array. While a bit
    pointless, this had no effect on Spring Security’s configuration.
    
    This behaviour has changed in the latest 4.0.3 snapshots [1]. An empty
    array passed to IgnoredRequestConfigurer.antMatchers now maps to /**. As
    Spring Boot configures its ignored paths with highest precedence this
    means that security is now disabled for every path.
    
    This commit updates both the management security and application
    security configuration to avoid calling antMatchers with an empty
    array, thereby ensuring that we don’t inadvertently ignore every path.
    Even if the change to Spring Security is reverted we can keep this
    change. The behaviour will remain the same and, arguably, it makes the
    intent of our configuration clearer.
    
    Closes gh-4345
    
    [1] https://github.com/spring-projects/spring-security/commit/8663ac41731ead18c549a24c2c94b78ce0cceb1b
    02d7e282
Name
Last commit
Last update
.mvn Loading commit data...
docs Loading commit data...
eclipse Loading commit data...
spring-boot Loading commit data...
spring-boot-actuator Loading commit data...
spring-boot-actuator-docs Loading commit data...
spring-boot-autoconfigure Loading commit data...
spring-boot-cli Loading commit data...
spring-boot-dependencies Loading commit data...
spring-boot-deployment-tests Loading commit data...
spring-boot-devtools Loading commit data...
spring-boot-docs Loading commit data...
spring-boot-full-build Loading commit data...
spring-boot-integration-tests Loading commit data...
spring-boot-parent Loading commit data...
spring-boot-samples Loading commit data...
spring-boot-starters Loading commit data...
spring-boot-tools Loading commit data...
.gitignore Loading commit data...
.settings-template.xml Loading commit data...
.travis.yml Loading commit data...
CONTRIBUTING.adoc Loading commit data...
LICENSE.txt Loading commit data...
README.adoc Loading commit data...
mvnw Loading commit data...
mvnw.cmd Loading commit data...
pom.xml Loading commit data...