• Andy Wilkinson's avatar
    Defer removal of Connectors until after ServletContext initialization · 145d8d26
    Andy Wilkinson authored
    Previously, we removed the Connectors from Tomcat's Service before
    the Context was started. The removal of the Connectors is required as
    it prevents Tomcat from accepting requests before we're ready to
    handle them.
    
    Part of starting the Context is creating and initializing the
    ServletContext. ServerProperties uses a ServletContextInitializer to
    set the session tracking modes and Tomcat rejects the SSL tracking
    mode if there is no SSL-enabled connector available. With the previous
    arrangement this led to a failure as the Connectors had been removed
    so the SSL-enabled connector could not be found.
    
    This commit updates the embedded Tomcat container to defer the
    removal of the Connectors until after the context has been started
    but still at a point that is before the Connectors themselves would
    have been started.
    
    Closes gh-12058
    145d8d26
Name
Last commit
Last update
.github Loading commit data...
.mvn Loading commit data...
eclipse Loading commit data...
spring-boot Loading commit data...
spring-boot-actuator Loading commit data...
spring-boot-actuator-docs Loading commit data...
spring-boot-autoconfigure Loading commit data...
spring-boot-cli Loading commit data...
spring-boot-dependencies Loading commit data...
spring-boot-deployment-tests Loading commit data...
spring-boot-devtools Loading commit data...
spring-boot-docs Loading commit data...
spring-boot-full-build Loading commit data...
spring-boot-integration-tests Loading commit data...
spring-boot-parent Loading commit data...
spring-boot-samples Loading commit data...
spring-boot-starters Loading commit data...
spring-boot-test Loading commit data...
spring-boot-test-autoconfigure Loading commit data...
spring-boot-tools Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.settings-template.xml Loading commit data...
.travis.yml Loading commit data...
CODE_OF_CONDUCT.adoc Loading commit data...
CONTRIBUTING.adoc Loading commit data...
LICENSE.txt Loading commit data...
README.adoc Loading commit data...
mvnw Loading commit data...
mvnw.cmd Loading commit data...
pom.xml Loading commit data...