• Adrian Cole's avatar
    Improves metrics performance by not guarding map.get · 38e3b39d
    Adrian Cole authored
    ConcurrentHashMap implements `containsKey` with `get`. By removing a
    redundant call to `containsKey`, we guarantee better performance in our
    counter services.
    
    The geek inside measured this with JMH, and found under 4 threads of
    contention, throughput on this check was 40% higher in success case.
    
    Benchmark                                  Mode  Cnt     Score     Error   Units
    TestBenchmarks.containsKeyAndGet_success  thrpt   30   432.389 ±  20.616  ops/us
    TestBenchmarks.get_success                thrpt   30   606.789 ±  10.848  ops/us
    
    Closes gh-6379
    38e3b39d
Name
Last commit
Last update
.github Loading commit data...
.mvn Loading commit data...
eclipse Loading commit data...
spring-boot Loading commit data...
spring-boot-actuator Loading commit data...
spring-boot-actuator-docs Loading commit data...
spring-boot-autoconfigure Loading commit data...
spring-boot-cli Loading commit data...
spring-boot-dependencies Loading commit data...
spring-boot-deployment-tests Loading commit data...
spring-boot-devtools Loading commit data...
spring-boot-docs Loading commit data...
spring-boot-full-build Loading commit data...
spring-boot-integration-tests Loading commit data...
spring-boot-parent Loading commit data...
spring-boot-samples Loading commit data...
spring-boot-starters Loading commit data...
spring-boot-test Loading commit data...
spring-boot-test-autoconfigure Loading commit data...
spring-boot-tools Loading commit data...
.gitignore Loading commit data...
.settings-template.xml Loading commit data...
.travis.yml Loading commit data...
CODE_OF_CONDUCT.adoc Loading commit data...
CONTRIBUTING.adoc Loading commit data...
LICENSE.txt Loading commit data...
README.adoc Loading commit data...
mvnw Loading commit data...
mvnw.cmd Loading commit data...
pom.xml Loading commit data...