• Andy Wilkinson's avatar
    Don't forward to welcome page that won't exist due to custom mapping · b280e309
    Andy Wilkinson authored
    Previously, WelcomePageHandlerMapping would forward to index.html.
    This assumed that the static path pattern was always /**. If it had
    been customised to, for example, /foo/**, then the forward would still
    be to index.html and a 404 would result as the page is actually
    available at /foo/index.html.
    
    At first glance, it would appear that the forward should be made to
    foo/index.html. However, as it's a forward rather than a redirect,
    any relative URLs in the index.html page would then be resolved using
    / whereas they should be resolved using /foo/. This could be addressed
    by using a redirect rather than a forward, but we don't want to do
    that as it's more invasive and would require a roundtrip back to the
    client. Instead, this commit simply stops performing the forward when
    the static path pattern is not /**.
    
    Closes gh-8788
    b280e309
Name
Last commit
Last update
.github Loading commit data...
.mvn Loading commit data...
eclipse Loading commit data...
spring-boot Loading commit data...
spring-boot-actuator Loading commit data...
spring-boot-actuator-docs Loading commit data...
spring-boot-autoconfigure Loading commit data...
spring-boot-cli Loading commit data...
spring-boot-dependencies Loading commit data...
spring-boot-deployment-tests Loading commit data...
spring-boot-devtools Loading commit data...
spring-boot-docs Loading commit data...
spring-boot-full-build Loading commit data...
spring-boot-integration-tests Loading commit data...
spring-boot-parent Loading commit data...
spring-boot-samples Loading commit data...
spring-boot-starters Loading commit data...
spring-boot-test Loading commit data...
spring-boot-test-autoconfigure Loading commit data...
spring-boot-tools Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.settings-template.xml Loading commit data...
.travis.yml Loading commit data...
CODE_OF_CONDUCT.adoc Loading commit data...
CONTRIBUTING.adoc Loading commit data...
LICENSE.txt Loading commit data...
README.adoc Loading commit data...
mvnw Loading commit data...
mvnw.cmd Loading commit data...
pom.xml Loading commit data...