Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RESOLVED - BATCH-1815: RunIdIncrementer goes against java best practices

Browse Source
This commit is contained in:
Robert Kasanicky
2011-11-20 21:21:51 +01:00
parent 202c26dec8
commit 488ba7a37b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-batch-core/src/main/java/org/springframework/batch/core/launch/support/RunIdIncrementer.java
View File

@@ -41,11 +41,11 @@ public class RunIdIncrementer implements JobParametersIncrementer {
* Increment the run.id parameter (starting with 1).
*/
public JobParameters getNext(JobParameters parameters) {
if (parameters == null) {
parameters = new JobParameters();
}
long id = parameters.getLong(key, 0L) + 1;
return new JobParametersBuilder(parameters).addLong(key, id).toJobParameters();
JobParameters params = (parameters == null) ? new JobParameters() : parameters;
long id = params.getLong(key, 0L) + 1;
return new JobParametersBuilder(params).addLong(key, id).toJobParameters();
}
}