Commit Graph

2256 Commits

Author SHA1 Message Date
Mahmoud Ben Hassine
dc6a4eb12d Replace hardcoded charsets with StandardCharsets 2023-06-22 09:38:50 +02:00
Mahmoud Ben Hassine
510d4768dd Remove tests that do not belong to Spring Batch test suite
Those tests test a class from Spring Framework.
2023-06-21 17:55:26 +02:00
Mahmoud Ben Hassine
502253bdd9 Remove unused class in tests 2023-06-21 17:53:15 +02:00
Mahmoud Ben Hassine
fd8f65b761 Remove unused bean in JobLoaderConfigurationTests 2023-06-21 17:47:01 +02:00
Mahmoud Ben Hassine
93d911e100 Use lambdas and method references where appropriate 2023-06-12 16:43:46 +02:00
Mahmoud Ben Hassine
c5b4f1a777 Remove unnecessary boxing/unboxing 2023-06-12 16:17:32 +02:00
Mahmoud Ben Hassine
7babb341f5 Replace for loops with enhanced for loop where appropriate 2023-06-12 16:05:44 +02:00
Mahmoud Ben Hassine
8c5456cff6 Replace for loops with String.repeat where appropriate 2023-06-12 16:00:45 +02:00
Mahmoud Ben Hassine
0f44e2bad1 Use pattern matching variables where appropriate 2023-06-12 15:47:57 +02:00
Mahmoud Ben Hassine
a2be6ba0c3 Replace unmodifiable collection creation with collection factory methods 2023-06-12 15:42:02 +02:00
Mahmoud Ben Hassine
cb1b68d165 Replace if statements with switch statements where appropriate 2023-06-12 15:39:25 +02:00
Mahmoud Ben Hassine
0bfe31e569 Remove stack traces from tests 2023-06-07 15:54:19 +02:00
Mahmoud Ben Hassine
7f80b7230b Remove System.err.println from tests 2023-06-07 15:47:56 +02:00
Mahmoud Ben Hassine
98c426ca4f Remove System.out.println from tests 2023-06-07 15:47:56 +02:00
Mahmoud Ben Hassine
12b412f60a Use Objects#equals where appropriate 2023-06-05 14:09:32 +02:00
Mahmoud Ben Hassine
92159cbc2b Use diamond operator where appropriate 2023-06-05 13:48:49 +02:00
Mahmoud Ben Hassine
8070751da8 Improve String concatenation where appropriate 2023-06-05 13:19:28 +02:00
Mahmoud Ben Hassine
106c4a589d Replace single operations inside loops with bulk methods 2023-06-05 13:14:01 +02:00
Mahmoud Ben Hassine
6d3e48a0bc Simplify assertions in tests 2023-06-05 13:08:15 +02:00
Mahmoud Ben Hassine
c25cd55901 Upgrade spring-javaformat maven plugin to version 0.0.39 2023-06-05 11:11:48 +02:00
Mahmoud Ben Hassine
bb5598e569 Remove unused method parameters in BatchRegistrar 2023-06-05 11:07:47 +02:00
Mahmoud Ben Hassine
7f304a1a79 Refine contribution #4364
Add integration test

Related to #4246
2023-05-16 07:01:47 +02:00
jinwoo-Bae
e329b61d18 Fix retrieval of job parameters in SimpleJobExplorer#getJobExecutions
Before this commit, SimpleJobExplorer#getJobExecutions returned
job executions with wrong job parameters, ie a job execution could
have the parameter of another execution.

This commit fixes the implementation so that each returned job
execution has its own parameters.

Resolves #4246
2023-05-16 06:57:47 +02:00
Mahmoud Ben Hassine
4a4c822274 Temporarily disable testWriteRetryOnTwoExceptions
Issue #4370
2023-05-11 13:52:57 +02:00
Sukanth Gunda
ef5ef1e6c6 Disable Docker-based tests when Docker is not available
Resolves #4360
2023-05-08 22:32:44 +02:00
Mahmoud Ben Hassine
a33f0e9a32 Fix migration script for SQLServer
Issue #4349
2023-05-08 12:04:39 +02:00
Henning Poettker
4faa842bb1 Upgrade to Mockito 5
Issue #4366
2023-05-04 00:09:11 +02:00
Minsoo Kim
4a971a0764 Enhance switch statements
Issue #4365
2023-05-03 23:59:16 +02:00
Mahmoud Ben Hassine
972951a40a Remove unused imports and apply imports code style 2023-04-11 16:28:36 +02:00
Henning Poettker
e61065ab00 Reduce use of deprecated APIs 2023-03-29 15:34:48 +02:00
Mahmoud Ben Hassine
30ce3326d1 Improve performance of JdbcJobInstanceDao#getLastJobInstance
Credit to @chenglongyan for the fix

Resolves #4024
2023-03-29 11:37:06 +02:00
Mahmoud Ben Hassine
dbdbf787e6 Update Javadocs 2023-03-21 17:51:53 +01:00
Glenn Renfro
386277ddc7 Fix tiny misspelling in the sybase integration test comments 2023-03-21 16:18:21 +01:00
Tatiana Slednikova
145c31b86f Change JobParameters to HashMap
Resolves #4179
2023-03-21 15:01:06 +01:00
Mahmoud Ben Hassine
4513d78ba5 Use text blocks for SQL queries
This commit replaces String concatenation with
text blocks for SQL queries in various DAOs.
This improves the readability of the code.

NB: Not all SQL queries in the code base were
changed to use text blocks, but only those where
readability became an issue.
2023-03-03 06:31:25 +01:00
Henning Poettker
93800c6bae Improve step execution polling and retrieval
Resolves #3790

---
Ported from c68da18 without the JSR related bits
2023-02-22 10:10:11 +01:00
Philippe Marschall
c707284f80 Use batch inserts for job parameters
Use batch inserts for job parameters to reduce
the number of database round trips.

Issue #3867
2023-02-21 20:00:49 +01:00
jinwoo-Bae
2cc0be4a0c Replace usage of deprecated jobOperator#start method with newer version
Related to #4303
2023-02-21 15:52:25 +01:00
Min-soo
b76993ca3d Fix version in Javadoc's since tag of DefaultBatchConfiguration
Issue #4312
2023-02-21 15:33:44 +01:00
Stephan Freund
5fae33185f Fix TARGET_NAME_PREFIX in StepScope
Resolves #3936
2023-02-21 10:47:29 +01:00
Mahmoud Ben Hassine
40109584bf Add missing AOT hints for Spring Batch integration module
Resolves #4307
2023-02-20 11:10:03 +01:00
Mahmoud Ben Hassine
0103ef025d Fix object graph deletion in SimpleJobRepository#deleteJobInstance
Before this commit, SimpleJobRepository#deleteJobInstance
was only deleting the given job instance and not the entire
object graph, which leads to data inconsistency (orphan job
executions and invalid foreign keys).

This commit fixes the contract and the implementation of the method
to delete the entire object graph.

Resolves #4250
2023-02-20 09:57:08 +01:00
Mahmoud Ben Hassine
4629294b65 Fix object graph deletion in SimpleJobRepository#deleteJobExecution
Before this commit, SimpleJobRepository#deleteJobExecution
did not delete associated step executions as specified in the
contract of the method.

This commit fixes the implementation to delete the entire
object graph as specified.

Resolves #4249
2023-02-20 08:41:34 +01:00
Mahmoud Ben Hassine
a547fe5b0a Deprecate JobOperator#start(String, String)
This method accepts job parameters as a string,
which can cause parsing issues.

Resolves #4304
2023-02-17 17:14:24 +01:00
Jinho Han
fa70bcd775 Add final to RunIdIncrementer and Job/Step BuilderFactory fields
Issue #4143
2023-02-16 20:53:32 +01:00
Mahmoud Ben Hassine
46c8ebbe7e Fix parameters parsing in JobOperator and MetaDataInstanceFactory
Before this commit, the parsing of job parameters in
JobOperator#start and MetaDataInstanceFactory#createJobExecution
was accepting the comma separated key=value pairs format,
which is incompatible with the new job parameters format
introduced in v5.

This commit updates the contract as well as the implementation
of those APIs to be compatible with v5.

Resolves #4253
Resolves #4301
2023-02-16 16:19:04 +01:00
Mahmoud Ben Hassine
9883cbc30e Add default converters for java.time types
Resolves #4257
2023-02-15 23:50:45 +01:00
Mahmoud Ben Hassine
30563cd25c Polish date converters 2023-02-15 23:46:03 +01:00
Mahmoud Ben Hassine
7ecac1c2ff Add default converters for java.util.Date parameter type
Resolves #4297
Resolves #4270
2023-02-15 19:05:47 +01:00
Mahmoud Ben Hassine
8aaf1d3d52 Fix decoding of default job parameter type in extended notation
Resolves #4299
2023-02-13 17:32:08 +01:00