Spring/spring-graphql
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polishing.

Browse Source 
Refine assertions to ignore locale-specific error messages.

See gh-1085
This commit is contained in:
Mark Paluch
2024-11-08 11:24:08 +01:00
committed by rstoyanchev
parent 821d480c3a
commit 2cafc7cc1b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-graphql/src/test/java/org/springframework/graphql/observation/GraphQlObservationInstrumentationTests.java
View File

@@ -343,12 +343,14 @@ class GraphQlObservationInstrumentationTests {
assertThat(response.errorCount()).isEqualTo(1);
assertThat(response.error(0).errorType()).isEqualTo("InvalidSyntax");
assertThat(response.error(0).message()).startsWith("Invalid syntax with offending token 'invalid'");
assertThat(response.error(0).message()).containsIgnoringCase("syntax")
.containsIgnoringCase("token").contains("'invalid'");
assertThat(observationHandler.getEvents()).hasSize(1);
Observation.Event errorEvent = observationHandler.getEvents().get(0);
assertThat(errorEvent.getName()).isEqualTo("InvalidSyntax");
assertThat(errorEvent.getContextualName()).startsWith("Invalid syntax with offending token 'invalid'");
assertThat(errorEvent.getContextualName()).containsIgnoringCase("syntax")
.containsIgnoringCase("token").contains("'invalid'");
TestObservationRegistryAssert.assertThat(this.observationRegistry).hasObservationWithNameEqualTo("graphql.request")
.that().hasLowCardinalityKeyValue("graphql.outcome", "REQUEST_ERROR")