Commit Graph

336 Commits

Author SHA1 Message Date
Dave Syer
271fb74b17 Update docs 2016-02-03 15:43:38 +00:00
Dave Syer
9bfe364518 SamplerConfiguration -> SamplerProperties
Plus tidy up docs a bit
2016-02-02 16:15:35 +00:00
Marcin Grzejszczak
9170ab4d0e Merge pull request #139 from spring-cloud/issues_#50_unnecessary_frb
[#50] Removed FRB.
2016-02-02 11:57:15 +01:00
Marcin Grzejszczak
055137bb72 [#50] Removed FRB.
fixes #50
2016-02-02 11:46:34 +01:00
Dave Syer
948d9e7886 Ensure sampled traces are exportable in test 2016-02-02 08:34:45 +00:00
Spencer Gibb
8918057a7f Updated readme for code of conduct.
See https://github.com/spring-cloud/spring-cloud-build/issues/26
2016-02-01 20:01:50 -07:00
Dave Syer
d8b72473d1 Ensure sampler is called with the new span if it is to be started 2016-02-01 18:01:34 +00:00
Dave Syer
6d3b8ffc60 Removes testcontainers and mouldy jackson dependencies 2016-02-01 17:30:15 +00:00
Dave Syer
70b18054e1 Add Span to Sampler method params
Also allows us to actually create a PercentageBasedSampler (I
don't think anyone tried it before) without resorting to
lazy beans and proxies.

Another freature added here is a default percentage sampler
if we know that spans need to be exported (zipkin or stream
is present).

Fixes gh-138
2016-02-01 17:00:00 +00:00
Dave Syer
065338118b Reomve unecessary custom log config 2016-02-01 16:08:38 +00:00
Dave Syer
12620a4725 Fix NPE in TracePreZuulFilter
Fixes gh-135
2016-01-30 16:47:23 +00:00
Dave Syer
39998a5def Ensure clients set X-Not-Sampled header for non-exportable Span
It also turns out that there's a bug in Spring MVC which makes an
empty header blow up in RequestHeaderMapMethodArgumentResolver
so we set the header to "true" instead of empty.

Fixes gh-136
2016-01-30 16:19:15 +00:00
Dave Syer
4f3c731d37 Fix trace filter so async requests are handled properly
Previously, if a trace id came into the filter from the caller and
the controller was async, the span context was not properly managed
resulting in warnings in logs.

Fixes gh-137
2016-01-30 12:19:07 +00:00
Marcin Grzejszczak
cd37335153 Removed kill at the end for Cloud Foundry e2e 2016-01-28 20:02:13 +01:00
Dave Syer
e2419d8cc0 Set default binding group name to "sleuth"
Can be changed by user with spring.sleuth.stream.group.

Fixes gh-134
2016-01-28 17:27:36 +00:00
Marcin Grzejszczak
35f1b0c496 Removed the build directory var export 2016-01-28 13:36:53 +01:00
Marcin Grzejszczak
8dd261edb9 Altered e2e scripts 2016-01-28 13:29:07 +01:00
Dave Syer
78365fe3c3 Fix test that fails because we asert a duration 2016-01-28 12:04:56 +00:00
Dave Syer
2ce2189799 Remove unused configuration 2016-01-27 11:10:32 +00:00
Dave Syer
0c5c984e4a Use accumulated millisecs instead of computing span duration 2016-01-26 13:53:44 +00:00
Dave Syer
ab1fd1c234 Removes message propagating interceptor
Now that the span data is stored in a header it is safe to remove
the slightly clunky propagation implentation that used a subclass.

Also removed the Stomp* features because they were diverging from
the mainstream integration support and no-one seems to understand
why they are needed. If the original author of #96 can explain
why they were needed we can ask for a new PR to re-instate a version
that works with the new model.
2016-01-26 13:00:07 +00:00
Marcin Grzejszczak
2ef5ba2a80 Fixed checkstyle issues 2016-01-26 13:50:45 +01:00
Dave Syer
5e2c0e9bd4 Use Message headers to propagate span not thread local
Otherwise we can end up closing spans that we shouldn't, or not
closing ones that we should.
2016-01-26 12:43:27 +00:00
Marcin Grzejszczak
0fc2c1a809 [#132] Fixed closing of spans in messaging
fixes #132
2016-01-26 12:57:34 +01:00
Marcin Grzejszczak
eeb57a6e11 Merge pull request #131 from spring-cloud/issues_#128_missing_spans
[#128] Added spans for messaging
2016-01-25 16:45:45 +01:00
Marcin Grzejszczak
91ba8cd981 [#128] Changes after review 2016-01-25 16:28:34 +01:00
Marcin Grzejszczak
0ff1cf92bd [#128] Added spans for messaging
fixes #128
2016-01-25 15:57:28 +01:00
Adrian Cole
4dca83f248 Merge pull request #130 from spring-cloud/log-even
Prefers the word event when adding to a Span's timeline
2016-01-25 11:34:39 +01:00
Adrian Cole
ef7e70dde3 Prefers the word event when adding to a Span's timeline
Span.logs are really timestamped events. This clarifies the naming and
documentation around that.
2016-01-25 11:24:07 +01:00
Adrian Cole
763d2d027c Updates to latest zipkin, which encourages new http tags 2016-01-25 10:51:05 +01:00
Adrian Cole
b6054bfbe4 Clarifies configuration in zipkin sample 2016-01-25 09:24:54 +01:00
Adrian Cole
d83e0dea3c Merge pull request #129 from spring-cloud/dots
Changes http key delimiter to dot and adds size keys
2016-01-24 17:57:01 +01:00
Dave Syer
a3a15fb69e Use classpath*: to ensure all binders are located 2016-01-24 14:48:16 +00:00
Dave Syer
205d9c1a84 Move stream header environment properties to stream library 2016-01-24 11:25:31 +00:00
Adrian Cole
9417110e90 Changes http key delimiter to dot and adds size keys 2016-01-23 17:28:12 +01:00
Marcin Grzejszczak
8258289550 [#128] Added an integration test 2016-01-22 13:24:42 +01:00
Marcin Grzejszczak
301c6b230a [#99] Basic Health Metrics
Changes following review
    - Reusing CounterService to automatically profit from Dropwizard if present
    - NoOp is the default impl for SpanReporterService
    - SpanReporterService has configurable metric names (it's enough to change the
    name to 'meter.a.b.c' to profit from Dropwizard's meters)

    Fixes gh-99
2016-01-21 15:55:26 +01:00
Dave Syer
3a4554d8c1 Tidy up conditionals in trace autoconfig 2016-01-21 14:05:16 +00:00
Dave Syer
689955a1f6 Add some javadocs for Sleuth{Source,Sink} 2016-01-21 14:00:36 +00:00
Dave Syer
0bbd7cb70f Fix messaging and ribbon instrumentation for hex headers
It still feels brittle because it's up to the suthor of the
instrumentation. This patches all the places where we were still
using Long instead of Long.toHexString(..).

Fixes gh-125
2016-01-21 09:48:34 +00:00
Dave Syer
7f58eab435 Make span collection thread safe in message source 2016-01-20 17:00:05 +00:00
Marcin Grzejszczak
10325e9547 Removed obsolete converter 2016-01-20 15:47:29 +01:00
Marcin Grzejszczak
72574f31ed Added comment with the difference between OpenTracing Span and Sleuth's Span 2016-01-20 14:53:16 +01:00
Marcin Grzejszczak
f48fc04049 Added Gitter badge 2016-01-20 14:39:08 +01:00
Marcin Grzejszczak
d22a497b0c TraceAccessor -> SpanAccessor 2016-01-20 14:39:08 +01:00
Marcin Grzejszczak
e560d414f1 Merge pull request #122 from spring-cloud/issues_#98_match_opentracing_sampler
[Match OpenTracing] Matching Sampler
2016-01-20 13:36:05 +01:00
Marcin Grzejszczak
3c5625a9de Changed sampler method to be consistent with open tracing API
https://github.com/opentracing/opentracing-python/blob/master/example/zipkin_like/sampler.py#L36
2016-01-20 13:05:29 +01:00
Marcin Grzejszczak
e948855d98 Removed redundant import 2016-01-20 13:04:16 +01:00
Marcin Grzejszczak
2698e0b9c2 Added Redundant Imports rule for checkstyle 2016-01-20 12:55:19 +01:00
Marcin Grzejszczak
556ff64f99 Added Unused Imports rule for checkstyle 2016-01-20 12:49:30 +01:00