Reinstate checkstyle running by default

- Rely on `checkstyle.skip` instead of a custom property
- Remove configuration from plugin definition, rely on execution only to set project-specific dependencies. This prevents inheritors from outside the project to fail on not finding the configuration. Note: on the long run, we will want to create a `build-tools` submodule that hold the configurations.
This commit is contained in:
Marius Bogoevici
2016-04-15 14:48:26 -04:00
committed by Ilayaperumal Gopinathan
parent c815420305
commit bfff729b81

View File

@@ -19,7 +19,6 @@
</scm>
<properties>
<java.version>1.7</java.version>
<disable.checks>true</disable.checks>
</properties>
<dependencyManagement>
<dependencies>
@@ -51,9 +50,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<configuration>
<configLocation>src/checkstyle/checkstyle.xml</configLocation>
</configuration>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
@@ -87,7 +83,6 @@
<id>checkstyle-validation</id>
<phase>validate</phase>
<configuration>
<skip>${disable.checks}</skip>
<configLocation>src/checkstyle/checkstyle.xml</configLocation>
<headerLocation>src/checkstyle/checkstyle-header.txt</headerLocation>
<propertyExpansion>checkstyle.build.directory=${project.build.directory}</propertyExpansion>