1. 20 Jan, 2015 1 commit
    • Andy Wilkinson's avatar
      Avoid race between file creation and its contents being written · f10c9b53
      Andy Wilkinson authored
      Previously, SampleIntegrationParentApplicationTests assumed that when
      an output file existed on disk its contents would have been written
      in their entirety. This assumption does not hold true and causes the
      test to fail intermittently as it incorrectly determines that the test
      has produced no output.
      
      This commit updates the test to wait for up to 30 seconds for the
      output files to appear on disk and for the expected content to be
      found in one of those files. If the files exist but do not
      contain the expected content the test will keep trying until it does
      or until too much time as elapsed.
      
      Fixes gh-2380
      f10c9b53
  2. 16 Jan, 2015 1 commit
  3. 15 Jan, 2015 1 commit
  4. 14 Jan, 2015 6 commits
    • Andy Wilkinson's avatar
      Don't remove @GrabResolver in JarCommand, disable initClass instead · 376de016
      Andy Wilkinson authored
      Previously, JarCommand removed all @GrabResolver annotations in an
      AST transformation. This was being performed as custom resolver
      configuration is not necessary in a jar as all of the dependencies are
      available from the jar. Furthermore, leaving the annotations in place
      caused a failure when the jar was run due to a missing Ivy dependency
      that's required by Groovy's default GrapeEngine, GrapeIvy.
      
      The removal of @GrabResolver annotations was being done before they
      could be used by Groovy's GrabAnnotationTransformation to configure
      the GrapeEngine's resolvers. This resulted in the annotations having
      no effect such that a dependency that was only available from a
      repository made available by @GrabResolver would fail to resolve if
      it was not cached locally.
      
      This commit updates the AST transformation to leave the @GrabResolver
      annotations in place but to set their initClass attribute to false.
      This allows the annotation to be used while the jar's being compiled,
      but supresses the generation of the static initializer that adds the
      custom resolver to the GrapeEngine when the compiled code's run via
      java -jar.
      
      Fixes gh-2330
      376de016
    • Andy Wilkinson's avatar
      Uninstall SLF4J’s Java logging bridge handler during shutdown · 9744d282
      Andy Wilkinson authored
      Previously, when LogbackLoggingSystem or Log4JLoggingSystem were
      initialized during application start up, they would install SLF4J’s Java
      logging bridge handler, however no corresponding uninstall was performed
      during application shutdown. When deployed to a servlet container, where
      the application’s lifecycle doesn’t match the JVM’s lifecycle, this lead
      to a memory leak.
      
      This commit updates LoggingSystem to introduce a new cleanUp method. An
      empty implementation is provided to preserve backwards compatibility
      with existing LoggingSystem subclasses. Both LogbackLoggingSystem and
      Log4JLoggingSystem have been updated to implement cleanUp and uninstall
      the SLF4J bridge handler. LoggingApplicationListener has been updated
      to call LoggingSystem.cleanUp in response to a ContextClosedEvent.
      
      Closes gh-2324
      9744d282
    • Andy Wilkinson's avatar
      Upgrade to Spring Integration 4.0.6.RELEASE · 92c8b75a
      Andy Wilkinson authored
      Closes gh-2358
      92c8b75a
    • Andy Wilkinson's avatar
      Upgrade to Spring AMQP 1.3.8.RELEASE · 3ef768e7
      Andy Wilkinson authored
      Closes gh-2357
      3ef768e7
    • Andy Wilkinson's avatar
      Upgrade to SLF4J 1.7.10 · 91206069
      Andy Wilkinson authored
      Closes gh-2336
      91206069
    • Andy Wilkinson's avatar
      Upgrade to Hibernate 4.3.8 · ca1716e9
      Andy Wilkinson authored
      Closes gh-2335
      ca1716e9
  5. 13 Jan, 2015 1 commit
    • Andy Wilkinson's avatar
      Tighten up conditions: a web application may not be using Spring MVC · b875a00e
      Andy Wilkinson authored
      Previously, some classes that were annotatated with
      @ConditionalOnWebApplication assumed that, if the application was a
      web application, Spring MVC (spring-webmvc) would be on the classpath.
      If it was not, the application would fail to start, typically with an
      error relating to WebMvcConfigurerAdapter being unavailable.
      
      This commit updates the affected configuration classes and annotates
      them with @ConditionalOnClass(WebMvcConfigurerAdapter.class) to
      ensure that their auto-configuration only takes effect if its a web
      application and Spring MVC is on the classpath.
      
      Fixes gh-2345
      b875a00e
  6. 07 Jan, 2015 1 commit
    • Andy Wilkinson's avatar
      Prevent Gradle from pulling in groovy-all with the remote shell starter · ac1d0cab
      Andy Wilkinson authored
      Sadly, Gradle handle's exclusions differently to Maven even when it's
      processing a Maven pom.
      
      In this case groovy-all is pulled in via org.crashub:crash.shell where
      we've excluded it. This is enough to prevent Maven from pulling in
      groovy-all when you depend on the remote shell starter.
      org.crashub:crash.shell is also pulled in as a transitive dependency
      of a number of other dependencies and Gradle requires each of these
      to also exclude groovy-all for it to actually be excluded.
      
      This commit adds the additional exclusions that are required to make
      Gradle's behaviour sane.
      
      Fixes gh-2257
      ac1d0cab
  7. 06 Jan, 2015 1 commit
    • Phillip Webb's avatar
      Fix InMemoryAuditEventRepository search by date · bd83aca6
      Phillip Webb authored
      Update InMemoryAuditEventRepository to consider the date when searching
      for events. Also switch to a circular buffer implementation and update
      the capacity to limit the total number of items rather than limiting
      per principal.
      
      Fixes gh-2291
      bd83aca6
  8. 05 Jan, 2015 1 commit
    • Phillip Webb's avatar
      Fix documentation code example error · 0622b3e9
      Phillip Webb authored
      The "Customizing ConfigurableEmbeddedServletContainer directly"
      section should use `HttpStatus.NOT_FOUND` and not `HttpStatus.404` in
      the sample code.
      
      Fixes gh-2258
      0622b3e9
  9. 03 Jan, 2015 2 commits
  10. 02 Jan, 2015 2 commits
    • Phillip Webb's avatar
      Fix ParentAwareNamingStrategy and JMX auto-config · 7e771bb6
      Phillip Webb authored
      Fix ParentAwareNamingStrategy to set ObjectName properties for the
      'identity' and 'context' attributes. Also update JmxAutoConfiguration
      to ensure that the ParentAwareNamingStrategy is created in each context
      and that the `mbeanExporter` bean is created. Prior to this commit the
      nested @EnableMBeanExport class always meant that the mbeanExporter
      condition never matched.
      
      Fixes gh-2243
      7e771bb6
    • Phillip Webb's avatar
      Guard for multiple ContentNegotiatingViewResolvers · c46478f9
      Phillip Webb authored
      Update WebMvcAutoConfiguration to ensure than the viewResolver bean
      is not created if a user defined ContentNegotiatingViewResolver bean
      is defined.
      
      Fixes gh-2269
      c46478f9
  11. 30 Dec, 2014 3 commits
  12. 28 Dec, 2014 2 commits
  13. 27 Dec, 2014 1 commit
  14. 26 Dec, 2014 1 commit
    • Phillip Webb's avatar
      Make RequestMappingHandlerMapping @Primary · 96d479c3
      Phillip Webb authored
      Update WebMvcAutoConfiguration so that the RequestMappingHandlerMapping
      bean is @Primary. Prior to this commit a NoUniqueBeanDefinitionException
      would be thrown then using the MvcUriComponentsBuilder.
      
      Fixes gh-2237
      96d479c3
  15. 23 Dec, 2014 2 commits
  16. 18 Dec, 2014 2 commits
  17. 17 Dec, 2014 1 commit
  18. 15 Dec, 2014 1 commit
  19. 14 Dec, 2014 2 commits
  20. 12 Dec, 2014 2 commits
  21. 11 Dec, 2014 2 commits
  22. 10 Dec, 2014 2 commits
  23. 09 Dec, 2014 1 commit
    • Phillip Webb's avatar
      Fix session timeout default value · 1c031abd
      Phillip Webb authored
      Update DEFAULT_SESSION_TIMEOUT to use TimeUnit.MINUTES.toSeconds(30)
      rather than TimeUnit.SECONDS.toMinutes(30) which would always return
      0.
      
      See gh-2084
      (cherry picked from commit b33bbd56)
      1c031abd
  24. 08 Dec, 2014 1 commit
    • Phillip Webb's avatar
      Set the default session timeout to 30 mins · c23a764a
      Phillip Webb authored
      Update AbstractConfigurableEmbeddedServletContainer to set the default
      session timeout to 30 minutes. Also correct Javadoc to specify that
      the default is '30 minutes'.
      
      Fixes gh-2084
      c23a764a