- 20 Jan, 2015 1 commit
-
-
Andy Wilkinson authored
Previously, SampleIntegrationParentApplicationTests assumed that when an output file existed on disk its contents would have been written in their entirety. This assumption does not hold true and causes the test to fail intermittently as it incorrectly determines that the test has produced no output. This commit updates the test to wait for up to 30 seconds for the output files to appear on disk and for the expected content to be found in one of those files. If the files exist but do not contain the expected content the test will keep trying until it does or until too much time as elapsed. Fixes gh-2380
-
- 16 Jan, 2015 1 commit
-
-
Dave Syer authored
The ErrorPageFilter exposes a wrapped response to the downstream chain and unless more care is taken the chain will be able to set the response status, but not inspect it. Fixes gh-2367
-
- 15 Jan, 2015 1 commit
-
-
Andy Wilkinson authored
-
- 14 Jan, 2015 6 commits
-
-
Andy Wilkinson authored
Previously, JarCommand removed all @GrabResolver annotations in an AST transformation. This was being performed as custom resolver configuration is not necessary in a jar as all of the dependencies are available from the jar. Furthermore, leaving the annotations in place caused a failure when the jar was run due to a missing Ivy dependency that's required by Groovy's default GrapeEngine, GrapeIvy. The removal of @GrabResolver annotations was being done before they could be used by Groovy's GrabAnnotationTransformation to configure the GrapeEngine's resolvers. This resulted in the annotations having no effect such that a dependency that was only available from a repository made available by @GrabResolver would fail to resolve if it was not cached locally. This commit updates the AST transformation to leave the @GrabResolver annotations in place but to set their initClass attribute to false. This allows the annotation to be used while the jar's being compiled, but supresses the generation of the static initializer that adds the custom resolver to the GrapeEngine when the compiled code's run via java -jar. Fixes gh-2330
-
Andy Wilkinson authored
Previously, when LogbackLoggingSystem or Log4JLoggingSystem were initialized during application start up, they would install SLF4J’s Java logging bridge handler, however no corresponding uninstall was performed during application shutdown. When deployed to a servlet container, where the application’s lifecycle doesn’t match the JVM’s lifecycle, this lead to a memory leak. This commit updates LoggingSystem to introduce a new cleanUp method. An empty implementation is provided to preserve backwards compatibility with existing LoggingSystem subclasses. Both LogbackLoggingSystem and Log4JLoggingSystem have been updated to implement cleanUp and uninstall the SLF4J bridge handler. LoggingApplicationListener has been updated to call LoggingSystem.cleanUp in response to a ContextClosedEvent. Closes gh-2324
-
Andy Wilkinson authored
Closes gh-2358
-
Andy Wilkinson authored
Closes gh-2357
-
Andy Wilkinson authored
Closes gh-2336
-
Andy Wilkinson authored
Closes gh-2335
-
- 13 Jan, 2015 1 commit
-
-
Andy Wilkinson authored
Previously, some classes that were annotatated with @ConditionalOnWebApplication assumed that, if the application was a web application, Spring MVC (spring-webmvc) would be on the classpath. If it was not, the application would fail to start, typically with an error relating to WebMvcConfigurerAdapter being unavailable. This commit updates the affected configuration classes and annotates them with @ConditionalOnClass(WebMvcConfigurerAdapter.class) to ensure that their auto-configuration only takes effect if its a web application and Spring MVC is on the classpath. Fixes gh-2345
-
- 07 Jan, 2015 1 commit
-
-
Andy Wilkinson authored
Sadly, Gradle handle's exclusions differently to Maven even when it's processing a Maven pom. In this case groovy-all is pulled in via org.crashub:crash.shell where we've excluded it. This is enough to prevent Maven from pulling in groovy-all when you depend on the remote shell starter. org.crashub:crash.shell is also pulled in as a transitive dependency of a number of other dependencies and Gradle requires each of these to also exclude groovy-all for it to actually be excluded. This commit adds the additional exclusions that are required to make Gradle's behaviour sane. Fixes gh-2257
-
- 06 Jan, 2015 1 commit
-
-
Phillip Webb authored
Update InMemoryAuditEventRepository to consider the date when searching for events. Also switch to a circular buffer implementation and update the capacity to limit the total number of items rather than limiting per principal. Fixes gh-2291
-
- 05 Jan, 2015 1 commit
-
-
Phillip Webb authored
The "Customizing ConfigurableEmbeddedServletContainer directly" section should use `HttpStatus.NOT_FOUND` and not `HttpStatus.404` in the sample code. Fixes gh-2258
-
- 03 Jan, 2015 2 commits
-
-
Phillip Webb authored
See gh-2180
-
Phillip Webb authored
Update spring-boot-dependencies to include all Jetty modules. The helps to prevent issues when modules are pulled in transitively (for example via solr). Fixes gh-2180
-
- 02 Jan, 2015 2 commits
-
-
Phillip Webb authored
Fix ParentAwareNamingStrategy to set ObjectName properties for the 'identity' and 'context' attributes. Also update JmxAutoConfiguration to ensure that the ParentAwareNamingStrategy is created in each context and that the `mbeanExporter` bean is created. Prior to this commit the nested @EnableMBeanExport class always meant that the mbeanExporter condition never matched. Fixes gh-2243
-
Phillip Webb authored
Update WebMvcAutoConfiguration to ensure than the viewResolver bean is not created if a user defined ContentNegotiatingViewResolver bean is defined. Fixes gh-2269
-
- 30 Dec, 2014 3 commits
-
-
Russell Allen authored
Closes gh-2262
-
Stephane Nicoll authored
Closes gh-2259
- 28 Dec, 2014 2 commits
-
-
Phillip Webb authored
-
Stephane Nicoll authored
Closes gh-2244
-
- 27 Dec, 2014 1 commit
-
-
Stephane Nicoll authored
Closes gh-2234
-
- 26 Dec, 2014 1 commit
-
-
Phillip Webb authored
Update WebMvcAutoConfiguration so that the RequestMappingHandlerMapping bean is @Primary. Prior to this commit a NoUniqueBeanDefinitionException would be thrown then using the MvcUriComponentsBuilder. Fixes gh-2237
-
- 23 Dec, 2014 2 commits
-
-
Stephane Nicoll authored
Closes gh-2215
-
Phillip Webb authored
-
- 18 Dec, 2014 2 commits
-
-
Andy Wilkinson authored
Closes gh-2199
-
Andy Wilkinson authored
The various servlet containers that we support vary in the quality of their diagnostics when ServletContext.addListener fails. To make problem diagnosis easier, this commit ensures that the toString of the the listener that was being added is included in the exception that's thrown when a failure occurs. Closes gh-2197
-
- 17 Dec, 2014 1 commit
-
-
Andy Wilkinson authored
Fixes gh-2187
-
- 15 Dec, 2014 1 commit
-
-
Michael Cramer authored
Closes gh-2151
-
- 14 Dec, 2014 2 commits
-
-
Phillip Webb authored
Update LogbackLoggingSystem to protect against a potential null CodeSource result. Fixes gh-2149
-
Phillip Webb authored
-
- 12 Dec, 2014 2 commits
-
-
Stephane Nicoll authored
-
Stephane Nicoll authored
Health indicator configuration keys have moved from the health.* to the management.health.* namespace. This commit makes sure that these are documented properly in 1.1.x as well. See gh-2118
-
- 11 Dec, 2014 2 commits
-
-
Phillip Webb authored
-
Spring Buildmaster authored
-
- 10 Dec, 2014 2 commits
-
-
Phillip Webb authored
Fixes gh-2110
-
Andy Wilkinson authored
Closes gh-2021
-
- 09 Dec, 2014 1 commit
-
-
Phillip Webb authored
Update DEFAULT_SESSION_TIMEOUT to use TimeUnit.MINUTES.toSeconds(30) rather than TimeUnit.SECONDS.toMinutes(30) which would always return 0. See gh-2084 (cherry picked from commit b33bbd56)
-
- 08 Dec, 2014 1 commit
-
-
Phillip Webb authored
Update AbstractConfigurableEmbeddedServletContainer to set the default session timeout to 30 minutes. Also correct Javadoc to specify that the default is '30 minutes'. Fixes gh-2084
-